From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <crazylht@gmail.com>
Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com
 [IPv6:2607:f8b0:4864:20::92f])
 by sourceware.org (Postfix) with ESMTPS id 590DC3842405
 for <gcc-patches@gcc.gnu.org>; Fri, 10 Jul 2020 09:23:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 590DC3842405
Received: by mail-ua1-x92f.google.com with SMTP id b24so1624537uak.2
 for <gcc-patches@gcc.gnu.org>; Fri, 10 Jul 2020 02:23:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rWll6pagMfLpy91Nda3YYTMEniRu9aZK7PfHeJsa5x8=;
 b=crcd87qAIzqUF7ngi+J0vZVMOEDWwTY9py1nGnCBKRnKZIvzh0jmjhyMWrj0id5Ouq
 uXmH+yNcAdfox2DucIlzSv2557JcGv2ZJ88bCf4oApJI+SgTPzEP35n3CGmD8Gd0x2zQ
 Si9CWBqt7XOWMRxtYy4ysBE8+JGwEL+QAYjF5PxpOnlBMSRDElaNq+XaZBqhyDdRzF6b
 PPjMJr+YMtNXb1fvVqccBiOoH2aK9fODGWaTKdBMhHzkiWI29SlYMQrr6ROEDNwu8eTh
 AsSujnWa+5OKHyk1pLO0mI0McucwhVUtgFbC+xyw9/JEyYjsveixJLD4/EMXkmXT+0Py
 WZgA==
X-Gm-Message-State: AOAM532i8+Z00ScNxpK00GCxCQNvCiqS3Goli45+W7HTRKM/PpPg+7FX
 5h5AS9BxRsOyzaU0GxYKOmlEGNB7un/2Tzo3QT6HBE6J
X-Google-Smtp-Source: ABdhPJxJA0VGtpoTRrNul9hy/F8NJ7yJkkvfpKd9ijtdNGfRhZitpFknWj9IvdMhJ6Y7YxKs65qt+1HAJkyVZ79RlLI=
X-Received: by 2002:ab0:720b:: with SMTP id u11mr17006743uao.35.1594373034792; 
 Fri, 10 Jul 2020 02:23:54 -0700 (PDT)
MIME-Version: 1.0
References: <CAMZc-bxdgUxqd=ZRyQ0ciPpLr=Deg=U8vhERov0f+B2Rgm17yA@mail.gmail.com>
In-Reply-To: <CAMZc-bxdgUxqd=ZRyQ0ciPpLr=Deg=U8vhERov0f+B2Rgm17yA@mail.gmail.com>
From: Hongtao Liu <crazylht@gmail.com>
Date: Fri, 10 Jul 2020 17:24:10 +0800
Message-ID: <CAMZc-byGa_S8S2qh698LjGBb=JK5doSCnzkYUHyzS2Vs0E+-0Q@mail.gmail.com>
Subject: Re: [PATCH] [AVX512] [PR87767] Optimize memory broadcast for constant
 vector under AVX512
To: GCC Patches <gcc-patches@gcc.gnu.org>, kirill.yukhin@gmail.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2020 09:23:56 -0000

+ maintainer.
cc H.J

On Thu, Jul 9, 2020 at 4:33 PM Hongtao Liu <crazylht@gmail.com> wrote:
>
> Hi:
>   For a constant vector having one duplicated value, there's no need
> to put the whole vector in the constant pool, using embedded broadcast
> instead.
>
>   Bootstrap test is Ok, regression test for i386/x86-64 backend is ok.
>
> gcc/ChangeLog:
>
>         PR target/87767
>         * config/i386/i386-features.c
>         (replace_constant_pool_with_broadcast): New function.
>         (constant_pool_broadcast): Ditto.
>         (class pass_constant_pool_broadcast): New pass.
>         (make_pass_constant_pool_broadcast): Ditto.
>         * config/i386/i386-passes.def: Insert new pass after combine.
>         * config/i386/i386-protos.h
>         (make_pass_constant_pool_broadcast): Declare.
>         * config/i386/sse.md (*avx512dq_mul<mode>3<mask_name>_bcst,
>         *avx512f_mul<mode>3<mask_name>_bcst): New define_insn.
>
> gcc/testsuite/ChangeLog:
>
>         PR target/87767
>         * gcc.target/i386/avx2-broadcast-pr87767-1.c: New test.
>         * gcc.target/i386/avx512f-broadcast-pr87767-1.c: New test.
>         * gcc.target/i386/avx512f-broadcast-pr87767-2.c: New test.
>         * gcc.target/i386/avx512vl-broadcast-pr87767-1.c: New test.
>         * gcc.target/i386/pr92865-1.c: Adjust testcase.
>
>
>
>
> --
> BR,
> Hongtao



-- 
BR,
Hongtao