From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by sourceware.org (Postfix) with ESMTPS id 3E6833858C74 for ; Sat, 26 Mar 2022 06:35:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E6833858C74 Received: by mail-vk1-xa36.google.com with SMTP id w128so5330745vkd.3 for ; Fri, 25 Mar 2022 23:35:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ewvHqegINmFrX/1e4loNKq2iFryJ/gyTJgAemJu8wvc=; b=QmNqWE0VNEVffwvyasOHlwl2A5wB51p/k7zCG7dfXiFbrbVqFlm2F6hOiwKBPzj0jm A+Jh9H3iQOpJU7Ypib+rKruPYTaNyq47yNNKhE/Ew1T1bHp3QtBDWKwaf8fIsRovWe94 5PY/T//RIETF9qjIyb370bOluxf09GeJm5kew41QCl0qShw/usoE4w9sIGOMLrI+lCiF /kcm+QyvO6IJvHmB6WgWPJGqtRXaMx2XlaUtN/vGQDO9XUNPbOyf9MHFTZQ24G+xM8Z6 Ut6eFxK4fw6JMrLyS2ifu5+Lq5mMF4aZp2itR2QIDxHb02+UWWntQG7UFxCCb5crC9KC M8zw== X-Gm-Message-State: AOAM530Eu9caThyI0+zeGUxW9PSqWAMVKhyZhPCrjeksCydQd2ygzBB4 PUlhsngOAxQMs4NY+7PRPMcDaya8GPg+WLOYM7k= X-Google-Smtp-Source: ABdhPJwTcrgGZmmnd7Er9XPUqyxRdeaYLR+yJOskXVpJU5dh7xQVPTUrVEhpKsKxwoZ+rGk3RPA48aDPl1mptKAZMC8= X-Received: by 2002:a05:6122:1da:b0:33f:c6b3:ac58 with SMTP id h26-20020a05612201da00b0033fc6b3ac58mr5399058vko.1.1648276529597; Fri, 25 Mar 2022 23:35:29 -0700 (PDT) MIME-Version: 1.0 References: <20220325205014.32895-1-hjl.tools@gmail.com> In-Reply-To: <20220325205014.32895-1-hjl.tools@gmail.com> From: Hongtao Liu Date: Sat, 26 Mar 2022 14:35:18 +0800 Message-ID: Subject: Re: [PATCH] x86: Use x constraint on KL patterns To: "H.J. Lu" Cc: GCC Patches , liuhongt Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2022 06:35:33 -0000 On Sat, Mar 26, 2022 at 4:50 AM H.J. Lu via Gcc-patches wrote: > > Since KL instructions have no AVX512 version, replace the "v" register > constraint with the "x" register constraint. > > PR target/105058 > * config/i386/sse.md (loadiwkey): Replace "v" with "x". > (aesu8): Likewise. LGTM, please backport to GCC11. > --- > gcc/config/i386/sse.md | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index 29802d00ce6..33bd2c4768a 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -28364,8 +28364,8 @@ (define_insn "avx512f_dpbf16ps__mask" > > ;; KEYLOCKER > (define_insn "loadiwkey" > - [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "v") > - (match_operand:V2DI 1 "register_operand" "v") > + [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "x") > + (match_operand:V2DI 1 "register_operand" "x") > (match_operand:V2DI 2 "register_operand" "Yz") > (match_operand:SI 3 "register_operand" "a")] > UNSPECV_LOADIWKEY) > @@ -28498,7 +28498,7 @@ (define_int_attr aesklvariant > (UNSPECV_AESENC256KLU8 "enc256kl")]) > > (define_insn "aesu8" > - [(set (match_operand:V2DI 0 "register_operand" "=v") > + [(set (match_operand:V2DI 0 "register_operand" "=x") > (unspec_volatile:V2DI [(match_operand:V2DI 1 "register_operand" "0") > (match_operand:BLK 2 "memory_operand" "m")] > AESDECENCKL)) > -- > 2.35.1 > -- BR, Hongtao