From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <crazylht@gmail.com>
Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com
 [IPv6:2607:f8b0:4864:20::e34])
 by sourceware.org (Postfix) with ESMTPS id A37A7383D030
 for <gcc-patches@gcc.gnu.org>; Thu, 13 May 2021 05:48:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A37A7383D030
Received: by mail-vs1-xe34.google.com with SMTP id 66so13144035vsk.9
 for <gcc-patches@gcc.gnu.org>; Wed, 12 May 2021 22:48:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=xHVcIeuGzfglQkJ6gospM0ocGVugFazrQW41pQ4DJV8=;
 b=Qc4JrNGRad3XAy6Bi/JcuWnG09/osM6tNU4CpY3CeHdzdfDZQmvtiAWRJBME745YM8
 pi2hPDm7+GKChdYXIjcs5JNChEZmJlxhPKC2s1N6cf+P+GXjo2u/Ttn8o4NOYOAy4zuI
 Yswr/AkOYKBObXAkB0TDMSBY6Z43YgBQnjU1+F48azKBUKWHEx3nrKw0EFXmLyHb/LsY
 +NXpi7hzACWjC112aNcMvO3d8noEWOdP2MrAA1LbcwFJmMCVUYmpnpo9xm4+t/d3HP0F
 oL7b14aXyjA0W4CzxYi7yMGfyi8nv0t21WFvYTkb8JY8qDDfjA+0Rp0/iOsYesdODrEf
 c6YQ==
X-Gm-Message-State: AOAM533O2WlO1NRCMWVXsJMBnrl4IvjZZZq1sjqXTQIbkXo65xi6emJy
 0rOUU3XuUyvCHd76/OQ+vVEPoauAQITL06ZO44o=
X-Google-Smtp-Source: ABdhPJwAMcQ2pdFCr/yI3AMc5dFQtDCfKYgeFCfOeZksPwfL+Gx2vYPRErvYnrcblbXNAyOy5jMXwg+7nCs7/ZDZNEM=
X-Received: by 2002:a67:fd01:: with SMTP id f1mr17409346vsr.45.1620884888294; 
 Wed, 12 May 2021 22:48:08 -0700 (PDT)
MIME-Version: 1.0
References: <CAMZc-byCJGFwdui=Zj7Gkcub9=QaUACOAn1YtozbcPR5JLr0DQ@mail.gmail.com>
 <20210423091336.GX1179226@tucnak>
 <CAMZc-bzdX=HM87wSf4eUYO0gsZzY6GCK_S9vp8uQt=EjbFOxKw@mail.gmail.com>
 <20210512141941.GR1179226@tucnak>
 <CAMZc-bym2qO+XhSYfVDwgYz+C7QFieck4s79F_s8Hnke14LRVg@mail.gmail.com>
In-Reply-To: <CAMZc-bym2qO+XhSYfVDwgYz+C7QFieck4s79F_s8Hnke14LRVg@mail.gmail.com>
From: Hongtao Liu <crazylht@gmail.com>
Date: Thu, 13 May 2021 13:52:37 +0800
Message-ID: <CAMZc-byNVjqO=766hrR5RC6POwhjK8AmFNjpPAEj17bUG-s8Bg@mail.gmail.com>
Subject: Re: [PATCH] [i386] Optimize __builtin_shuffle when it's used to zero
 the upper bits of the dest. [PR target/94680]
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 May 2021 05:48:09 -0000

There's a typo in the testcase, I've committed the patch as an obvious fix.

    Fix typo in testcase.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/avx-pr94680.c: Fix typo in testcase.

diff --git a/gcc/testsuite/gcc.target/i386/avx-pr94680.c
b/gcc/testsuite/gcc.target/i386/avx-pr94680.c
index a89e4967f64..cb5041b6af3 100644
--- a/gcc/testsuite/gcc.target/i386/avx-pr94680.c
+++ b/gcc/testsuite/gcc.target/i386/avx-pr94680.c
@@ -76,7 +76,7 @@ foo_v16hi_l (v16hi x)
 {
   return __builtin_shuffle ((v16hi)  { 0, 0, 0, 0, 0, 0, 0, 0,
                                       0, 0, 0, 0, 0, 0, 0, 0 }, x,
-                           (v16hi) { 16, 17, 18, 20, 21, 22, 23,
+                           (v16hi) { 16, 17, 18, 19, 20, 21, 22, 23,
                                      15, 0, 13, 2, 11, 4, 9, 6 });
 }

-- 
BR,
Hongtao