From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id B36E83851C07; Thu, 21 Jan 2021 05:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B36E83851C07 Received: by mail-io1-xd2d.google.com with SMTP id x21so1638530iog.10; Wed, 20 Jan 2021 21:22:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=faIbCz33occNFBrfbqxbkGPFDClkxAs89fq4MBLwFG8=; b=RuPy339GxskWGFvDn9zf3w5QWhWzGKE7smxgY/ZEvQo7LgH6UHPoO8yT9zjCKw+nef vp4QEfqvSQGoV/HFW/UgefUGwCuSAHxWhq30cwGlJWeVE2wWVSAkYN8CCrg3T/dpVtqY jglx6PkyqBUQaKM6uGW9bFixR5ra+HXyZCOethUKpVyeQ6vuJWUfm6SnpYPjT37tbMB4 0LwppaI+7X3+VfX0BdFfsjBqtjE1qnlkoA38nmGmAKn5KtjT7fy1V112emQbnJrhxjAX OBDEOSuiv8XtijIJUCQ8yxAlzTqDMsJnygI8mBbt8jiD3GB11KULnv1xxEjkHRc3Hh03 GmnA== X-Gm-Message-State: AOAM533cvoWUZ8uLBE9yomCOu33swmrtpgFhW2DAjntiZS54m0Vhs8gZ e9TmKxY0aHmGUCW/cWnX5yxhpdMk0x7Y3oUIm/g= X-Google-Smtp-Source: ABdhPJw2C+6YFHxxCJaPQ82IoqTas4Xf7ZY5wwO2Qienx/0oVa1qu273WZdzJ77h7k+NXk6Myt1oRvA4daQNpmbQ470= X-Received: by 2002:a92:cd81:: with SMTP id r1mr10777421ilb.252.1611206534274; Wed, 20 Jan 2021 21:22:14 -0800 (PST) MIME-Version: 1.0 References: <20210119144514.GA4020736@tucnak> In-Reply-To: From: Hongtao Liu Date: Thu, 21 Jan 2021 13:25:08 +0800 Message-ID: Subject: Re: [PATCH] [PR rtl/optimization/98694] Fix incorrect optimization by cprop_hardreg. To: Hongtao Liu , Jakub Jelinek via Gcc-patches , ebotcazou@libertysurf.fr, steven@gcc.gnu.org, Jakub Jelinek , Richard Sandiford Content-Type: multipart/mixed; boundary="00000000000022c54805b9624134" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 05:22:17 -0000 --00000000000022c54805b9624134 Content-Type: text/plain; charset="UTF-8" > OK with those changes and the one that HJ asked for. > This is the patch I'm checking in, thanks for the review. > Thanks, > Richard -- BR, Hongtao --00000000000022c54805b9624134 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-PR-rtl-optimization-98694-Fix-incorrect-optimization_V3.patch" Content-Disposition: attachment; filename="0001-PR-rtl-optimization-98694-Fix-incorrect-optimization_V3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kk6eue5i0 RnJvbSBiODA2ZTBjZWNlNjI2MjBlMzFhNGE4NjEyMDhkMzc2MTYwNTlhMjEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBsaXVob25ndCA8aG9uZ3Rhby5saXVAaW50ZWwuY29tPgpEYXRl OiBNb24sIDE4IEphbiAyMDIxIDE2OjU1OjMyICswODAwClN1YmplY3Q6IFtQQVRDSF0gW1BSIHJ0 bC9vcHRpbWl6YXRpb24vOTg2OTRdIEZpeCBpbmNvcnJlY3Qgb3B0aW1pemF0aW9uIGJ5CiBjcHJv cF9oYXJkcmVnLgoKSWYgU1JDIGhhZCBiZWVuIGFzc2lnbmVkIGEgbW9kZSBuYXJyb3dlciB0aGFu IHRoZSBjb3B5LCB3ZSBjYW4ndAphbHdheXMgbGluayBERVNUIGludG8gdGhlIGNoYWluIGV2ZW4g dGhleSBoYXZlIHNhbWUKaGFyZF9yZWdub19ucmVncyhpLmUuIEhJbW9kZS9TSW1vZGUgaW4gaTM4 NiBiYWNrZW5kKS4KCmkuZQogICAgICAgIGttb3Z3ICAgJWswLCAlZWRpCiAgICAgICAgdm1vdmQg ICAlZWRpLCAleG1tMgoJdnBzaHVmbHcgICAgICAgICQwLCAleG1tMiwgJXhtbTAKICAgICAgICBr bW92dyAgICVrMCwgJXI4ZAogICAgICAgIGttb3ZkICAgJWswLCAlcjlkCi4uLgotCSBtb3ZsICVy OWQsICVyMTFkCisJIHZtb3ZkICV4bW0yLCAlcjExZAoKZ2NjL0NoYW5nZUxvZzoKCglQUiBydGwt b3B0aW1pemF0aW9uLzk4Njk0CgkqIHJlZ2Nwcm9wLmMgKGNvcHlfdmFsdWUpOiBJZiBTUkMgaGFk IGJlZW4gYXNzaWduZWQgYSBtb2RlCgluYXJyb3dlciB0aGFuIHRoZSBjb3B5LCB3ZSBjYW4ndCBs aW5rIERFU1QgaW50byB0aGUgY2hhaW4gZXZlbgoJdGhleSBoYXZlIHNhbWUgaGFyZF9yZWdub19u cmVncyhpLmUuIEhJbW9kZS9TSW1vZGUgaW4gaTM4NgoJYmFja2VuZCkuCgpnY2MvdGVzdHN1aXRl L0NoYW5nZUxvZzoKCglQUiBydGwtb3B0aW1pemF0aW9uLzk4Njk0CgkqIGdjYy50YXJnZXQvaTM4 Ni9wcjk4Njk0LmM6IE5ldyB0ZXN0LgotLS0KIGdjYy9yZWdjcHJvcC5jICAgICAgICAgICAgICAg ICAgICAgICAgICB8IDI5ICsrKysrKysrKysrKysrKysrCiBnY2MvdGVzdHN1aXRlL2djYy50YXJn ZXQvaTM4Ni9wcjk4Njk0LmMgfCA0MSArKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVz IGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnY2MvdGVzdHN1 aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk4Njk0LmMKCmRpZmYgLS1naXQgYS9nY2MvcmVnY3Byb3Au YyBiL2djYy9yZWdjcHJvcC5jCmluZGV4IGRkNjJjYjM2MDEzLi5lMTM0MmY1NmJkMSAxMDA2NDQK LS0tIGEvZ2NjL3JlZ2Nwcm9wLmMKKysrIGIvZ2NjL3JlZ2Nwcm9wLmMKQEAgLTM1OCw2ICszNTgs MzUgQEAgY29weV92YWx1ZSAocnR4IGRlc3QsIHJ0eCBzcmMsIHN0cnVjdCB2YWx1ZV9kYXRhICp2 ZCkKICAgZWxzZSBpZiAoc24gPiBoYXJkX3JlZ25vX25yZWdzIChzciwgdmQtPmVbc3JdLm1vZGUp KQogICAgIHJldHVybjsKIAorICAvKiBJdCBpcyBub3Qgc2FmZSB0byBsaW5rIERFU1QgaW50byB0 aGUgY2hhaW4gaWYgU1JDIHdhcyBkZWZpbmVkIGluIHNvbWUKKyAgICAgbmFycm93ZXIgbW9kZSBN IGFuZCBpZiBNIGlzIGFsc28gbmFycm93ZXIgdGhhbiB0aGUgbW9kZSBvZiB0aGUgZmlyc3QKKyAg ICAgcmVnaXN0ZXIgaW4gdGhlIGNoYWluLiAgRm9yIGV4YW1wbGU6CisgICAgIChzZXQgKHJlZzpE SSByMSkgKHJlZzpESSByMCkpCisgICAgIChzZXQgKHJlZzpISSByMikgKHJlZzpISSByMSkpCisg ICAgIChzZXQgKHJlZzpTSSByMykgKHJlZzpTSSByMikpIC8vU2hvdWxkIGJlIGEgbmV3IGNoYWlu IHN0YXJ0IGF0IHIzCisgICAgIChzZXQgKHJlZzpTSSByNCkgKHJlZzpTSSByMSkpCisgICAgIChz ZXQgKHJlZzpTSSByNSkgKHJlZzpTSSByNCkpCisKKyAgICAgdGhlIHVwcGVyIHBhcnQgb2YgcjMg aXMgdW5kZWZpbmVkLiAgSWYgd2UgYWRkZWQgaXQgdG8gdGhlIGNoYWluLAorICAgICBpdCBtYXkg YmUgdXNlZCB0byByZXBsYWNlIHI1LCB3aGljaCBoYXMgZGVmaW5lZCB1cHBlciBiaXRzLgorICAg ICBTZWUgUFI5ODY5NCBmb3IgZGV0YWlscy4KKworICAgICBbQV0gcGFydGlhbF9zdWJyZWdfcCAo dmQtPmVbc3JdLm1vZGUsIEdFVF9NT0RFIChzcmMpKQorICAgICBbQl0gcGFydGlhbF9zdWJyZWdf cCAodmQtPmVbc3JdLm1vZGUsIHZkLT5lW3ZkLT5lW3NyXS5vbGRlc3RfcmVnbm9dLm1vZGUpCisg ICAgIENvbmRpdGlvbiBCIGlzIGFkZGVkIHRvIHRvIGNhdGNoIG9wdGltaXphdGlvbiBvcHBvcnR1 bml0aWVzIG9mCisKKyAgICAgKHNldCAocmVnOkhJIFIxKSAocmVnOkhJIFIwKSkKKyAgICAgKHNl dCAocmVnOlNJIFIyKSAocmVnOlNJIFIxKSkgLy8gW0FdCisgICAgIChzZXQgKHJlZzpESSBSMykg KHJlZzpESSBSMikpIC8vIFtBXQorICAgICAoc2V0IChyZWc6U0kgUjQpIChyZWc6U0kgUlswLTNd KSkKKyAgICAgKHNldCAocmVnOkhJIFI1KSAocmVnOkhJIFJbMC00XSkpCisKKyAgICAgaW4gd2hp Y2ggYWxsIHJlZ2lzdGVycyBoYXZlIG9ubHkgMTYgZGVmaW5lZCBiaXRzLiAgKi8KKyAgZWxzZSBp ZiAocGFydGlhbF9zdWJyZWdfcCAodmQtPmVbc3JdLm1vZGUsIEdFVF9NT0RFIChzcmMpKQorCSAg ICYmIHBhcnRpYWxfc3VicmVnX3AgKHZkLT5lW3NyXS5tb2RlLAorCQkJCXZkLT5lW3ZkLT5lW3Ny XS5vbGRlc3RfcmVnbm9dLm1vZGUpKQorICAgIHJldHVybjsKKwogICAvKiBMaW5rIERSIGF0IHRo ZSBlbmQgb2YgdGhlIHZhbHVlIGNoYWluIHVzZWQgYnkgU1IuICAqLwogCiAgIHZkLT5lW2RyXS5v bGRlc3RfcmVnbm8gPSB2ZC0+ZVtzcl0ub2xkZXN0X3JlZ25vOwpkaWZmIC0tZ2l0IGEvZ2NjL3Rl c3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHI5ODY5NC5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFy Z2V0L2kzODYvcHI5ODY5NC5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw Li40NTg4OWQ0ODJjMQotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdl dC9pMzg2L3ByOTg2OTQuYwpAQCAtMCwwICsxLDQxIEBACisvKiBQUiBydGwtb3B0aW1pemF0aW9u Lzk4Njk0ICovCisvKiB7IGRnLWRvIHJ1biB7IHRhcmdldCB7ICEgaWEzMiB9IH0gfSAqLworLyog eyBkZy1vcHRpb25zICItTzIgLW1hdng1MTJidyIgfSAqLworLyogeyBkZy1yZXF1aXJlLWVmZmVj dGl2ZS10YXJnZXQgYXZ4NTEyYncgfSAqLworCisjaW5jbHVkZTxpbW1pbnRyaW4uaD4KK3R5cGVk ZWYgc2hvcnQgdjRoaSBfX2F0dHJpYnV0ZV9fICgodmVjdG9yX3NpemUgKDgpKSk7Cit0eXBlZGVm IGludCB2MnNpIF9fYXR0cmlidXRlX18gKCh2ZWN0b3Jfc2l6ZSAoOCkpKTsKK3Y0aGkgYjsKKwor X19hdHRyaWJ1dGVfXyAoKG5vaXBhKSkKK3Yyc2kKK2ZvbyAoX19tNTEyaSBzcmMxLCBfX201MTJp IHNyYzIpCit7CisgIF9fbW1hc2s2NCBtID0gX21tNTEyX2NtcGVxX2VwdThfbWFzayAoc3JjMSwg c3JjMik7CisgIHNob3J0IHMgPSAoc2hvcnQpIG07CisgIGludCBpID0gKGludCltOworICBiID0g X19leHRlbnNpb25fXyAodjRoaSkge3MsIHMsIHMsIHN9OworICByZXR1cm4gX19leHRlbnNpb25f XyAodjJzaSkge2ksIGl9OworfQorCitpbnQgbWFpbiAoKQoreworICBpZiAoIV9fYnVpbHRpbl9j cHVfc3VwcG9ydHMgKCJhdng1MTJidyIpKQorICAgIHJldHVybiAwOworCisgIF9fbTUxMmkgc3Jj MSA9IF9tbTUxMl9zZXR6ZXJvX3NpNTEyICgpOworICBfX201MTJpIHNyYzIgPSBfbW01MTJfc2V0 X2VwaTggKDAsIDEsIDAsIDEsIDAsIDEsIDAsIDEsCisJCQkJICAwLCAxLCAwLCAxLCAwLCAxLCAw LCAxLAorCQkJCSAgMCwgMSwgMCwgMSwgMCwgMSwgMCwgMSwKKwkJCQkgIDAsIDEsIDAsIDEsIDAs IDEsIDAsIDEsCisJCQkJICAwLCAxLCAwLCAxLCAwLCAxLCAwLCAxLAorCQkJCSAgMCwgMSwgMCwg MSwgMCwgMSwgMCwgMSwKKwkJCQkgIDAsIDEsIDAsIDEsIDAsIDEsIDAsIDEsCisJCQkJICAwLCAx LCAwLCAxLCAwLCAxLCAwLCAxKTsKKyAgX19tbWFzazY0IG0gPSBfbW01MTJfY21wZXFfZXB1OF9t YXNrIChzcmMxLCBzcmMyKTsKKyAgdjJzaSBhID0gZm9vIChzcmMxLCBzcmMyKTsKKyAgaWYgKGFb MF0gIT0gKGludCltKQorICAgIF9fYnVpbHRpbl9hYm9ydCAoKTsKKyAgcmV0dXJuIDA7Cit9Ci0t IAoyLjE4LjEKCg== --00000000000022c54805b9624134--