From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <crazylht@gmail.com>
Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f])
	by sourceware.org (Postfix) with ESMTPS id ED26E3858D3C
	for <gcc-patches@gcc.gnu.org>; Wed,  9 Nov 2022 01:12:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED26E3858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-yb1-xb2f.google.com with SMTP id n85so13755068yba.1
        for <gcc-patches@gcc.gnu.org>; Tue, 08 Nov 2022 17:12:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=r2uJK81IDrOP3XU8WCnAdQ86Lsbl9IuReVZ69rMGCkY=;
        b=KHDrU33hQZ+tzHLWRgfbIIQeZy39aOav1GeVfJd6uJaScV4OyHYPt7aJIMOntTZxc/
         5kScoC8Njz87t4Fd6vAJlUdcMZuhmsKOTYCztWxIzVIHqIe+ljisdpqQuiNXvMfoO8PE
         8WXMvicBFDJSAX4C3JdJNBZy2BgPArdDbMW4SK+uhASSDanUcs7QC32+XnmCvQVWyZAj
         ykwSW6xtugs7SUpGCEHE+/P1HbdRJ5SMPvytt649ZQtalI+8RfVy+78c4Q3CT3XTi14o
         WoRxDtFAKEREevmuQdVTNSRZTF2NapgZLQ+ZqF0q98QL/L2hi+lTYGdFKpJTWP04PPiD
         rtYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=r2uJK81IDrOP3XU8WCnAdQ86Lsbl9IuReVZ69rMGCkY=;
        b=Ok8e0VEJ83d7bRpaTJe0CBP5YFgr88FZtedKi4leC/OBMwv+abQweP0g3Pj2c6RqDi
         8MxctSXgJ42stQccBUVwxfYzNsvXt5FCgUpq98n85uNpcX5DWNwtP5InvZHDcTg5L0tb
         b9hBoAu2Dx6UxFUIfNrpibkliNn4QVtAzD1hPs01zhSVlWEBl1ZNXMZn8Zw/J7V6fqhw
         F8LukKSF99UAOLJQsQnMhmfVSN/By1V7zYf6P81XE516kolttSTelq1YzZDc00its9wS
         EERkYQTwdx1WBXB2X7UgRCXhJNTXU4xkmrc6YrZU4ijNHhy8dkLGKiuVtl/RVU8qpyEs
         wJzQ==
X-Gm-Message-State: ACrzQf0cieZuQmDjNehXUwD0Tm1LQTASUcqQq1zcpbT3f1uRjHPjhzYA
	ySwrpzB7lVvj1/C9O+B4w9LJCwIVfBXvwTDi7rk=
X-Google-Smtp-Source: AMsMyM7/ChepKW+uwtvw1ad+xBnlvlVrXkDEiDKR4xTetzJ4LtFnBObtsl3Rtd55nnhRfAeoLkMQUjMQzlryx7F2mmg=
X-Received: by 2002:a05:6902:154d:b0:6d0:a97c:ac62 with SMTP id
 r13-20020a056902154d00b006d0a97cac62mr34219168ybu.296.1667956376299; Tue, 08
 Nov 2022 17:12:56 -0800 (PST)
MIME-Version: 1.0
References: <20221108011751.286433-1-hongtao.liu@intel.com>
In-Reply-To: <20221108011751.286433-1-hongtao.liu@intel.com>
From: Hongtao Liu <crazylht@gmail.com>
Date: Wed, 9 Nov 2022 09:16:04 +0800
Message-ID: <CAMZc-byaRUSxKXrfknv4vwdMZVLMneP1uMQeHS=BD+SE9erXcA@mail.gmail.com>
Subject: Re: [PATCH] Fix incorrect insn type to avoid ICE in memory attr auto-detection.
To: liuhongt <hongtao.liu@intel.com>
Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com, ubizjak@gmail.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Nov 8, 2022 at 9:17 AM liuhongt <hongtao.liu@intel.com> wrote:
>
> Memory attribute auto detection will check operand 2 for type sselog,
> and check operand 1 for type sselog1. For below 2 insns, there's no
> operand 2. Change type to sselog1.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok for trunk?
Committed as an obvious fix.

>
> gcc/ChangeLog:
>
>         PR target/107540
>         * config/i386/sse.md (avx512f_movddup512<mask_name>): Change
>         type from sselog to sselog1.
>         (avx_movddup256<mask_name>): Ditto.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/i386/pr107540.c: New test.
> ---
>  gcc/config/i386/sse.md                   |  4 ++--
>  gcc/testsuite/gcc.target/i386/pr107540.c | 12 ++++++++++++
>  2 files changed, 14 insertions(+), 2 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/i386/pr107540.c
>
> diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> index fa93ae7bf21..4e8463addc3 100644
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -12203,7 +12203,7 @@ (define_insn "avx512f_movddup512<mask_name>"
>                      (const_int 6) (const_int 14)])))]
>    "TARGET_AVX512F"
>    "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
> -  [(set_attr "type" "sselog")
> +  [(set_attr "type" "sselog1")
>     (set_attr "prefix" "evex")
>     (set_attr "mode" "V8DF")])
>
> @@ -12234,7 +12234,7 @@ (define_insn "avx_movddup256<mask_name>"
>                      (const_int 2) (const_int 6)])))]
>    "TARGET_AVX && <mask_avx512vl_condition>"
>    "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
> -  [(set_attr "type" "sselog")
> +  [(set_attr "type" "sselog1")
>     (set_attr "prefix" "<mask_prefix>")
>     (set_attr "mode" "V4DF")])
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr107540.c b/gcc/testsuite/gcc.target/i386/pr107540.c
> new file mode 100644
> index 00000000000..a0351ff9cb5
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr107540.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-flive-range-shrinkage -mavx" } */
> +
> +typedef double __attribute__((__vector_size__ (32))) V;
> +
> +V v;
> +
> +void
> +foo (void)
> +{
> +  v = __builtin_ia32_movddup256 (v);
> +}
> --
> 2.27.0
>


--
BR,
Hongtao