From: Hongtao Liu <crazylht@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461]
Date: Mon, 4 Jan 2021 16:59:22 +0800 [thread overview]
Message-ID: <CAMZc-byka-94i0SwV2iG1rSYek07eL_re9ha76LqBsy3ExFExQ@mail.gmail.com> (raw)
In-Reply-To: <20210104084920.GK3788@tucnak>
On Mon, Jan 4, 2021 at 4:49 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Mon, Jan 04, 2021 at 01:56:44PM +0800, Hongtao Liu via Gcc-patches wrote:
> > +(define_insn_and_split "*sse2_pmovskb_zexthisi"
> > + [(set (match_operand:SI 0 "register_operand")
> > + (zero_extend:SI (subreg:HI (unspec:SI
> > + [(match_operand:V16QI 1 "register_operand")]
> > + UNSPEC_MOVMSK) 0)))]
>
> Also, please fix up formatting. Should be:
> (zero_extend:SI
> (subreg:HI
> (unspec:SI
> [(match_operand:V16QI 1 "register_operand")]
> UNSPEC_MOVMSK) 0)))]
> I think.
>
> Jakub
>
Yes, thanks for the review both, and happy new year!
--
BR,
Hongtao
next prev parent reply other threads:[~2021-01-04 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 5:56 Hongtao Liu
2021-01-04 7:40 ` Uros Bizjak
2021-01-04 7:54 ` Hongtao Liu
2021-01-04 8:42 ` Uros Bizjak
2021-01-04 8:49 ` Jakub Jelinek
2021-01-04 8:59 ` Hongtao Liu [this message]
2021-01-05 6:32 ` Hongtao Liu
2021-01-05 7:04 ` Uros Bizjak
2021-01-05 7:19 ` Uros Bizjak
2021-01-05 10:28 ` Hongtao Liu
2021-01-05 10:30 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZc-byka-94i0SwV2iG1rSYek07eL_re9ha76LqBsy3ExFExQ@mail.gmail.com \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).