From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by sourceware.org (Postfix) with ESMTPS id 4E1BA3858D3C for ; Mon, 17 Oct 2022 01:02:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E1BA3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-333a4a5d495so93998717b3.10 for ; Sun, 16 Oct 2022 18:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L1F3ykfqCAXefiIQfZXw/09OzGvrsEkGyUYRqrmHpLQ=; b=fEVwyt/gOzvo1Ia+0S015dPKfk9AgSZb7gAhSDz0jUAOURR8OtIftgyUMwNEjH6pga EqaVAx/57XnlDNqPfAMx/m3Ul+dOzhrZXhFJu9AzKE6inhB3GneTMbbFrHJWwg2GlmUq fG0ffov2yBNntqB2VG2m/G/8TRAnunjztGy81hd7nuRZGVSN62zllixWFykyRtxtMils CF4jl9xrij7va6B47ggEbiyGDSwuyzPI93+GKS3VUMxl8+4b809carqCA0sqK0C6mlpr UM7Aa3SkbHrQswhxwQuPN/SLFpJd+RB44ZhWM+kL2Pz3TP40NVjfk6WtIgi2YZh2Zfmp b4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L1F3ykfqCAXefiIQfZXw/09OzGvrsEkGyUYRqrmHpLQ=; b=nDk3GMqLDbrGIO7GmzYn/fEJbl2PZPnkIVL/Wb84W1XrbtK/cSnbt38/m8zf7wHPKL H9lkwZVVPd263SZDVwDO8q8lHR+yV5nr4/2oYvQ4P9IxsETJN06oYBMfrgzjrTN6oR8W K0jWE1AfW2WOVtuiYHE8DAbduPKqxTiKlruTzMlcOoXNIKnCJj0VAEvgjO0hDfoHVhFW a4OHPDjHyboyyU+DhMr9FnnNHAv9j043zFHlWPyouQmMaiZzTPe+SkvEP8LerWyXKsAw 75ldZ+VGrCsP7yBh1TTDV3t8guU70htvTyCUdQTAr32x0F8XSLMfGEgEQC+DBlOx03v1 R99g== X-Gm-Message-State: ACrzQf3ipZJq8qnQgdS5zoQ3rkADMiq6SUKWwuOh5vRxsWRheUvg0rWv b/wbz2juSOwtKHkXemamtu266+/VUfPURhXtvJM= X-Google-Smtp-Source: AMsMyM7hImpFLK7LZHeQanyPUV45Ik2YQOZ9Bi8HIiSAffZjm9CABSg+SN5++JRslLp1cowRZdHBrqHPa3u1IXN23h4= X-Received: by 2002:a81:9e51:0:b0:354:8aab:84ac with SMTP id n17-20020a819e51000000b003548aab84acmr7210147ywj.241.1665968553592; Sun, 16 Oct 2022 18:02:33 -0700 (PDT) MIME-Version: 1.0 References: <20221014075445.7938-1-haochen.jiang@intel.com> In-Reply-To: From: Hongtao Liu Date: Mon, 17 Oct 2022 09:02:22 +0800 Message-ID: Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions To: Iain Sandoe Cc: "Lu, Hongjiu" , Haochen Jiang , hongtao.liu@intel.com, GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 14, 2022 at 4:36 PM Iain Sandoe wrote= : > > > > > On 14 Oct 2022, at 09:30, Hongtao Liu wrote: > > > > On Fri, Oct 14, 2022 at 4:24 PM Iain Sandoe w= rote: > >> > >> > >> > >>> On 14 Oct 2022, at 09:20, Hongtao Liu wrote: > >>> > >>> On Fri, Oct 14, 2022 at 4:14 PM Iain Sandoe via Gcc-patches > >>> wrote: > >>>> > >>>> Hi Haochen > >>>> > >>>>> On 14 Oct 2022, at 08:54, Haochen Jiang via Gcc-patches wrote: > >>>>> > >>>> > >>>>> These six patches aimed to add Intel Sierra Forest instructions, in= cluding > >>>>> AVX-IFMA, AVX-VNNI0INT8, AVX-NE-CONVERT, CMPccXADD. We also added i= ntrinsic > >>>>> for vector __bf16 in this series of patch and Sierra Forest Support= . > >>>>> > >>>>> The information is based on newly released > >>>>> Intel Architecture Instruction Set Extensions and Future Features. > >>>>> > >>>>> The document comes following: > >>>>> https://www.intel.com/content/www/us/en/develop/download/intel-arch= itecture-instruction-set-extensions-programming-reference.html > >>>>> > >>>>> Regtested on x86_64-pc-linux-gnu. Ok for trunk? > >>>> > >>>> Have you tested that the testcases work on older platforms that do n= ot have support > >>>> for the new instructions in their assemblers? > >>>> > >>>> I could not see any target-requires changes in the testcases .. henc= e my question. > >>>> > >>> Guess you are looking at compile tests? > >> > >> yes, compile tests would need support from the assembler. > > oops, not enough coffee - I=E2=80=99m talking rubbish here - assembler ou= tput should be fine, > > >>> For runtime test, we have add assembler check(target-requires changed= ) > >>> plus runtime check(builtin_cpu_supports) > >>> .i.e. > >>> > >>> +++ b/gcc/testsuite/gcc.target/i386/avx-ifma-vpmaddhuq-2.c > >>> @@ -0,0 +1,72 @@ > >>> +/* { dg-do run } */ > >>> +/* { dg-options "-O2 -mavxifma" } */ > >>> +/* { dg-require-effective-target avxifma } */ > >>> > >>> Do I miss some? > >> > >> I would need to look at the sources after patching (perhaps they alrea= dy have > >> suitable target-requires that did not show up in the patch). > >> > >> Do you have this series as a branch somewhere that I can try on one of= the > >> like affected platforms? > > > > Not yet. > > Do we have any external place to put those patches so folks from the > > community can validate before it's committed, HJ? > > I=E2=80=99d still like to be able to test if that can be done - I=E2=80= =99ve already got a large number of > fails from new testcases in earlier additions. I've upstream those patches to public https://gitlab.com/x86-gcc/gcc/-/tree/users/intel/liuhongt/upstream Also if you're intereted in Binutils patches, it's in https://gitlab.com/x86-binutils/binutils-gdb/-/tree/users/intel/liuhongt/up= stream > > Iain --=20 BR, Hongtao