From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by sourceware.org (Postfix) with ESMTPS id 717BD3858D1E for ; Mon, 18 Mar 2024 11:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 717BD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 717BD3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710759784; cv=none; b=GPtaojyLC7kZhbJrUt67jMHrNZQlCXf1ODB3ZCEU5dT2ywZpvBW5UzfS/+FW9di3eHKK+/6lg5CtdkpzE5D06G+N3y1GR6Yc7vS9TJK16Eu3gTIcbeLr2LeSJhNsKBIxJ/Acx1E//dKbM4yp1ZV77LrAbDulE7dwY+oc5+rXddY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710759784; c=relaxed/simple; bh=EprEImG58vG3w0hoTWZl4xPcyBp9GcjQjmxkhtD0WyY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZobnxJtPNxL+Z3YboVv6vpDozJWCTlDrzujFbqaEcP9nGRbQ+RNXyWuOenvary8XJ7kEzOltSJiQoRrCK1sr2G7TY/ULLSXpVKCybq8a44jPH8n2LeOacq08mk0eSClck/9ez8dKkwjrh/3eSmysFIKmfY2mZqRIjmeSHvVCvZ4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-690caa6438aso26810686d6.0 for ; Mon, 18 Mar 2024 04:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710759771; x=1711364571; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ANDWrg7mjd1pr8JCcsE5A5aPmc2wFED93uCYjHuT0r0=; b=LAez2L8oTPrb8+FGr9yIGMasNJYPSz7QeZHutRhaep5JPTKYLSe49CMOs98YNj4vYZ XU/qCqEMUgYHUdbplVn1pLmDgP0PyKgLyrxx9GeNYF0Lhk5f6yHlVzBK4Q6k7PC3jkF2 LnNKr1QD53zn+uJwlDeAFGz5vxz87vLX07o/ugL7/H5AvE+3ukVPBd0PlWVyESyezkYE DYyzA6N0ZXdER/wmSAfMe/sOBFxl0b05aAnUX+urPQC6wClkrR05AwIKLytDMbHIoUVE dMCDRDOvkDVIrpE/Ng0kPAxJ0tLxk+xb1vbbwf7/ts03cO4raUPoAtOFSfVHibOsfpCM wHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710759771; x=1711364571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ANDWrg7mjd1pr8JCcsE5A5aPmc2wFED93uCYjHuT0r0=; b=Gpci9829ib0UvFQ90ijpdJouaFwKs9iyijDCgqSr3kOnWu4VLDVuw0W1Vcr0e7NulL 7eWMRSSYeOcVJGiPnrPuZfRhBT4Cxsn8CO5oaXZWveK3qYTq3i8GtqyaszadcPDEAqwW uQDJsQWm2WrhJyTBkA8ZUBXIo3Q+cBAfPn5Z5bSVS/ZHCEcqh46plfr1DsC+BhfAW3gv NX9wFh+cUk1+OpJaQDRrzTjnZRws4d1qn7XmvBfU8/IWyxhxzO3K8ZuKkCUkLVDRcxqI c9Q3u6d/ZWU2BQDWIlOcDWmzvwWQ+acpgXuFy3LrFSwm3Bdl85uXdeFcI6rfh9Tv6TeE hdeQ== X-Forwarded-Encrypted: i=1; AJvYcCUd5j1Rv/me8R4qewax2W3RWPPVtGrT3xWFu1kbfCniY+YURHp0sbhl1VRdsF99gRY811zEg2cWLpRshtLRnO4JlMxTjMQI6A== X-Gm-Message-State: AOJu0YyyRMkAU5NCEsABP6Z8MbJQNBH/xMLVeKVXEjf9HtvekrVF7Od3 85Gp7O9Jc0zMMfWHYKC281nrt0lFjXV4bWfX7mTjaYK8RP6yxnD8D/XNjbDJm3K2JvilRPjac/A N0QWcQUWFKvd+nHb0dpSykwu6EWM= X-Google-Smtp-Source: AGHT+IFjtl6z7afkhdGiAZPxZfpidoNr6BMgyD4va9+aG7QTF82MeoRgxVVmQdJP6ZtzFFUsxlQKHhTAQpOC1UB5jCk= X-Received: by 2002:a05:6214:8d2:b0:691:51d4:c40c with SMTP id da18-20020a05621408d200b0069151d4c40cmr10825782qvb.18.1710759771707; Mon, 18 Mar 2024 04:02:51 -0700 (PDT) MIME-Version: 1.0 References: <20240318105200.3555938-1-hongtao.liu@intel.com> In-Reply-To: From: Hongtao Liu Date: Mon, 18 Mar 2024 19:02:40 +0800 Message-ID: Subject: Re: [PATCH] i386 [stv]: Handle REG_EH_REGION note [pr111822]. To: Uros Bizjak Cc: liuhongt , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 18, 2024 at 6:59=E2=80=AFPM Uros Bizjak wro= te: > > On Mon, Mar 18, 2024 at 11:52=E2=80=AFAM liuhongt = wrote: > > > > Commit r14-9459-g618e34d56cc38e only handles > > general_scalar_chain::convert_op. The patch also handles > > timode_scalar_chain::convert_op to avoid potential similar bug. > > > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > > Ok for trunk and backport to releases/gcc-13 branch? > > I have the following patch in testing that merges > {general,timode}_scalar_chain::convert_op, so in addition to less code > duplication, it will fix the issue for both chains. WDYT? It would be better for maintenance, I prefer your patch. > > Uros. > > > > > gcc/ChangeLog: > > > > PR target/111822 > > * config/i386/i386-features.cc > > (timode_scalar_chain::convert_op): Handle REG_EH_REGION note. > > --- > > gcc/config/i386/i386-features.cc | 20 +++++++++++++++++--- > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > diff --git a/gcc/config/i386/i386-features.cc b/gcc/config/i386/i386-fe= atures.cc > > index c7d7a965901..38f57d96df5 100644 > > --- a/gcc/config/i386/i386-features.cc > > +++ b/gcc/config/i386/i386-features.cc > > @@ -1794,12 +1794,26 @@ timode_scalar_chain::convert_op (rtx *op, rtx_i= nsn *insn) > > *op =3D gen_rtx_SUBREG (V1TImode, *op, 0); > > else if (MEM_P (*op)) > > { > > + rtx_insn* eh_insn; > > rtx tmp =3D gen_reg_rtx (V1TImode); > > - emit_insn_before (gen_rtx_SET (tmp, > > - gen_gpr_to_xmm_move_src (V1TImode,= *op)), > > - insn); > > + eh_insn > > + =3D emit_insn_before (gen_rtx_SET (tmp, > > + gen_gpr_to_xmm_move_src (V1TIm= ode, > > + *op))= , > > + insn); > > *op =3D tmp; > > > > + if (cfun->can_throw_non_call_exceptions) > > + { > > + /* Handle REG_EH_REGION note. */ > > + rtx note =3D find_reg_note (insn, REG_EH_REGION, NULL_RTX); > > + if (note) > > + { > > + control_flow_insns.safe_push (eh_insn); > > + add_reg_note (eh_insn, REG_EH_REGION, XEXP (note, 0)); > > + } > > + } > > + > > if (dump_file) > > fprintf (dump_file, " Preloading operand for insn %d into r%d\= n", > > INSN_UID (insn), REGNO (tmp)); > > -- > > 2.31.1 > > --=20 BR, Hongtao