From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id 1D4523858426 for ; Sun, 19 Sep 2021 03:49:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D4523858426 Received: by mail-vs1-xe34.google.com with SMTP id u8so13340701vsp.1 for ; Sat, 18 Sep 2021 20:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iyVvurcrAtyWpERC9QQvqd0jv3EiYzpcBXe8pBnHZyU=; b=UyhFFNq12dKySWhbPCuBwE/ep2rD33JKKqxsm5A8WU58Pxq3Nd7Ci8mdpTvYPpwCqg keOnwvA3e0qVpJ+6jYX/N/JkUivY4hsooHJJ5bZ2IMcAC5p5UMqd16SbdQKeftgiJimh rcIyFnLEuC3imtPHuBUrj0gfgfx7KlA+/IqJ25QTcYu2B8CyoOvvaozapLEU1Dd+1+6f xBYafdWNxT2sjb5Xj5u5Ld8zEaCzHAj1GqrBBp1srASmV5htP5Xv9OeqX8tvcFSgBlPf FtIvEmcqQOIYz4x7wWsIhrT5aruZPX6o0G/jniKwEeAwm2mhKMoAffPKvyOPvq5Az4Fi 37Jg== X-Gm-Message-State: AOAM532ifWHpzCFwAJbfxjwXB9o5v7RvBFbOOawcjL6GM8xdN+Sm8F7h DRnXaWaNkJHbxCKW0Q5e9ugNHTQaRuO5wkDPBi7CUtn4WkGfeQ== X-Google-Smtp-Source: ABdhPJwStZlXxRCyNhFqJSVDndbzFWsPhPl3HEr6QVaCVzn0x2Cz65acRWZ4RoG7e1waU3wtYflsdi2jUNSYtjDru2U= X-Received: by 2002:a67:441:: with SMTP id 62mr13260162vse.54.1632023390536; Sat, 18 Sep 2021 20:49:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:612c:2009:b0:22c:74d3:8fcc with HTTP; Sat, 18 Sep 2021 20:49:49 -0700 (PDT) In-Reply-To: References: <20210903074113.39461-1-hongtao.liu@intel.com> <20210903090036.GX920497@tucnak> <20210906070855.GL920497@tucnak> <92E99F52-C804-4F37-870F-C559A46A8C38@googlemail.com> <20210906085853.GP920497@tucnak> <20210907122829.GJ920497@tucnak> <20210908090936.GQ920497@tucnak> From: Hongtao Liu Date: Sun, 19 Sep 2021 11:49:49 +0800 Message-ID: Subject: Re: [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1 To: Iain Sandoe Cc: Jakub Jelinek , GCC Patches X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Sep 2021 03:49:53 -0000 On Sunday, September 19, 2021, Iain Sandoe wrote: > Hi Hongtao, > > > On 8 Sep 2021, at 10:31, Hongtao Liu wrote: > > > > On Wed, Sep 8, 2021 at 5:09 PM Jakub Jelinek wrote: > >> > >> On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote: > >>> Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. > >>> Ok for trunk? > >>> > >>> libgcc/ChangeLog: > >>> > >>> * config/i386/t-softfp: Compile __{mul,div}hc3 into > >>> libgcc_s.so.1. > > this was applied as > https://gcc.gnu.org/pipermail/gcc-cvs/2021-September/353114.html > > but it seems that (at least on Linux and Darwin) we now see a lot of: > > /src-local/gcc-master-patched/libgcc/shared-object.mk:14: warning: > overriding commands for target `_divhc3.o' > Makefile:501: warning: ignoring old commands for target `_divhc3.o' > /src-local/gcc-master-patched/libgcc/shared-object.mk:17: warning: > overriding commands for target `_divhc3_s.o=E2=80=99 > > and I think this is because we need to exclude the libgcc2 version of th= e > functions before adding teh replacements, like the patch below. > > tested on x86_64-linux, darwin observing that the __divhc3 and __mulh3 > symbols are present and that the metadata for the source files indicates > that they are the replacement sources. > > OK for master? Yes, thanks. > Iain > > =E2=80=94=E2=80=94 > > [PATCH] libgcc, X86: Exclude rules for libgcc2 __{div,mul}hc3. > > We want to override the libgcc2 generic version of these functions > for X86. First exclude the original and the add in the replacements. > > Signed-off-by: Iain Sandoe > > libgcc/ChangeLog: > > * config/i386/t-softfp: Exclude libgcc2 versions of __divhc3 > and __mulhc3. > --- > libgcc/config/i386/t-softfp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libgcc/config/i386/t-softfp b/libgcc/config/i386/t-softfp > index 7620cc0cec5..fe2ad8a3c08 100644 > --- a/libgcc/config/i386/t-softfp > +++ b/libgcc/config/i386/t-softfp > @@ -2,6 +2,7 @@ LIB2ADD +=3D $(srcdir)/config/i386/sfp-exceptions.c > > # Replace _divhc3 and _mulhc3. > libgcc2-hf-functions =3D _divhc3 _mulhc3 > +LIB2FUNCS_EXCLUDE +=3D $(libgcc2-hf-functions) > libgcc2-hf-extras =3D $(addsuffix .c, $(libgcc2-hf-functions)) > LIB2ADD +=3D $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras)) > > -- > > > --=20 BR, Hongtao