From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id 216813857376; Thu, 20 Oct 2022 01:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 216813857376 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2e.google.com with SMTP id i127so12168318ybc.11; Wed, 19 Oct 2022 18:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ep0ubRyf5zpMQuk+wZ0CopnfWNKW9QooULTvu7Y4Bt0=; b=Pa0R5WSS5DQ+3BshWsUWWDuO13WQFtkjHAz66xXJYAGK9RzE9VBPGPT9uMbtgeYtVh WDFV3GmulGBw8egqnmkG53Fz6O2v8p1iW//6R7eT9G0ycVcf/aOIwfpEZyGZvJ23XuC/ wnWU/cI+bDypVnUKNLplsgdV94odkKuDrdam0pszi6ZYuSMJj2C0DagPEoLW25ysyp2t Z87Va4rzYgDZ+1vqVOpEQHQ5FHlvI13HswhEAbu+KbmMq9iMkmDGybz1VGpCN4T+uDqe cWWKmVYOwfnhprvoY/xIlahq2zbvV95/2M6rol8xDTQPhZMj2OBDW61g1xUJ7UOU7Fzk 2nKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ep0ubRyf5zpMQuk+wZ0CopnfWNKW9QooULTvu7Y4Bt0=; b=1n6UjaZYdJucjF3iJW+oUYVUCPPqv3lx6q/Abv5BPOl9msZ4BTrpl6MdW5stLbVj9x XeWukBIFNsb0OigXfW1UVx6huCa6+XdEskpOtLYTuXFmcH22w9NffYDGuUIZxdFc+l5P KcLwlzqst0Bd90+ivbrLU/q0UepnMzREjgr7VcdWxAlIq8P7PGAdJ65MQyhdMQLBg3QR WeEWzLaVik4hFK2xs1WGWfLc8JYbuek9SvzLYLr0U6YNqvL2xTmvPfPSSDzL7WO+OXc1 NL1kRm4e1gAyj4eRxzNfBq4HUDCVmNChNOYtLs4sQDq0aQCuCu2P9PxyzQGUXU5LOum3 lEiw== X-Gm-Message-State: ACrzQf0UI/vyJLwvFi1wCSnjcpBvS7W5rs1DtKHcrEGcbRTy81ot3fXg E3GMekGKNdWfHKMtpdWaMNorOj5VvOsKmkS6tK0= X-Google-Smtp-Source: AMsMyM4Fq40hNQLRL8tIpwTEETqVqR3Memz/gaYOVUYjvvXfwEgignLC2qW/3Hs+7GfKTP5bOiCcGav+VrC+P7HSS38= X-Received: by 2002:a25:c102:0:b0:6c4:c94:2842 with SMTP id r2-20020a25c102000000b006c40c942842mr9536582ybf.611.1666229241551; Wed, 19 Oct 2022 18:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20221014083406.8406-1-haochen.jiang@intel.com> <20221014083406.8406-2-haochen.jiang@intel.com> <20221019211421.GQ25951@gate.crashing.org> In-Reply-To: <20221019211421.GQ25951@gate.crashing.org> From: Hongtao Liu Date: Thu, 20 Oct 2022 09:27:10 +0800 Message-ID: Subject: Re: [PATCH 1/2] Add a parameter for the builtin function of prefetch to align with LLVM To: Segher Boessenkool Cc: Andrew Pinski , mfortune@gmail.com, dave.anglin@bell.net, rguenther@suse.de, aoliva@gcc.gnu.org, richard.sandiford@arm.com, uweigand@de.ibm.com, hubicka@ucw.cz, marcus.shawcroft@arm.com, olegendo@gcc.gnu.org, gcc-patches@gcc.gnu.org, linkw@gcc.gnu.org, richard.earnshaw@arm.com, ramana.radhakrishnan@arm.com, davem@redhat.com, gnu@amylaar.uk, hongtao.liu@intel.com, claziss@synopsys.com, dje.gcc@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 20, 2022 at 5:15 AM Segher Boessenkool wrote: > > On Wed, Oct 19, 2022 at 10:14:28AM -0700, Andrew Pinski wrote: > > Do the testcases really need to be changed rather than adding new testcases? > > Usually it is better if the testcases not change unless really needed > > to be. That is do these testcases pass without being changed? If not > > this seems not backwards compatible change and is not something which > > we should do. Otherwise you should just add new testcases instead. > > Yes, that is another reason why adding parameters to random builtins is > not a good idea :-) s/random/only vaguely related/, if you want. > > This also makes all existing code using these builtins invalid. If you > need such testcase changes, that is a red flag. The default behavior is the same as before(default data prefetch, we'll unchange those testcases.) > > > Segher -- BR, Hongtao