From: Hongtao Liu <crazylht@gmail.com>
To: Vladimir Makarov via Gcc-patches <gcc-patches@gcc.gnu.org>,
Hongtao Liu <crazylht@gmail.com>,
Vladimir Makarov <vmakarov@redhat.com>,
dcb314@hotmail.com,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH][PR target/97540] Don't extract memory from operand for normal memory constraint.
Date: Wed, 4 Nov 2020 13:14:59 +0800 [thread overview]
Message-ID: <CAMZc-bzRor16iv0m_RXMhE8ZAOgKT1VWCgsiuuZpxwn0Lq1JLw@mail.gmail.com> (raw)
In-Reply-To: <mptwnz2o8eg.fsf@arm.com>
On Tue, Nov 3, 2020 at 9:51 PM Richard Sandiford
<richard.sandiford@arm.com> wrote:
>
> Vladimir Makarov via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> > On 2020-10-27 2:53 a.m., Hongtao Liu wrote:
> >> Hi:
> >> For inline asm, there could be an operand like (not (mem:)), it's
> >> not a valid operand for normal memory constraint.
> >> Bootstrap is ok, regression test is ok for make check
> >> RUNTESTFLAGS="--target_board='unix{-m32,}'"
> >>
> >> gcc/ChangeLog
> >> PR target/97540
> >> * ira.c: (ira_setup_alts): Extract memory from operand only
> >> for special memory constraint.
> >> * recog.c (asm_operand_ok): Ditto.
> >> * lra-constraints.c (process_alt_operands): MEM_P is
> >> required for normal memory constraint.
> >>
> >> gcc/testsuite/ChangeLog
> >> * gcc.target/i386/pr97540.c: New test.
> >>
> > I understand Richard's concerns and actually these concerns were my
> > motivations to constraint possible cases for extract_mem_from_operand in
> > the original patch introducing the function.
> >
> > If Richard proposes a better solution we will reconsider the current
> > approach and revert the changes if it is necessary.
> >
> > Meanwhile I am approving this patch. I hope it will not demotivate
> > Richard's attempt to find a better solution.
>
> OK, that's fine with me. I might come back to this next stage 1,
> depending on how things turn out.
>
> Richard
Thanks for all your comments, patch committed.
And I'm not going to add "Br" to more patterns until the final
solution is in place.
--
BR,
Hongtao
next prev parent reply other threads:[~2020-11-04 5:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 6:53 Hongtao Liu
2020-10-27 11:13 ` Richard Sandiford
2020-10-28 1:32 ` Hongtao Liu
2020-10-28 18:46 ` Richard Sandiford
2020-10-29 1:20 ` Hongtao Liu
2020-10-29 17:00 ` Richard Sandiford
2020-11-02 7:12 ` Hongtao Liu
2020-11-02 19:03 ` Richard Sandiford
2020-10-29 5:33 ` Hongtao Liu
2020-10-29 17:03 ` Richard Sandiford
2020-10-31 17:16 ` Hans-Peter Nilsson
2020-10-29 11:01 ` Jakub Jelinek
2020-10-29 17:16 ` Richard Sandiford
2020-11-02 19:40 ` Vladimir Makarov
2020-11-03 13:51 ` Richard Sandiford
2020-11-04 5:14 ` Hongtao Liu [this message]
2020-11-04 10:19 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZc-bzRor16iv0m_RXMhE8ZAOgKT1VWCgsiuuZpxwn0Lq1JLw@mail.gmail.com \
--to=crazylht@gmail.com \
--cc=dcb314@hotmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).