From: Hongtao Liu <crazylht@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]
Date: Tue, 18 Feb 2020 11:01:00 -0000 [thread overview]
Message-ID: <CAMZc-bzUh6xbVtT_Ahi+59072=U2ct9J7cT6ZZc+1Ymn4RT1tw@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4aHK-0mZ=2STkAKhMN6p0TDPtWj_324_hW5KfbY1rPSHA@mail.gmail.com>
On Tue, Feb 18, 2020 at 4:24 PM Uros Bizjak <ubizjak@gmail.com> wrote:
>
>
>
> On Thu, Feb 13, 2020 at 9:39 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>> > Changelog
>> > gcc/
>> > * config/i386/avx512vbmi2intrin.h
>> > (_mm512_[,mask_,maskz_]shrdi_epi16,
>> > _mm512_[,mask_,maskz_]shrdi_epi32,
>> > _m512_[,mask_,maskz_]shrdi_epi64,
>> > _mm512_[,mask_,maskz_]shldi_epi16,
>> > _mm512_[,mask_,maskz_]shldi_epi32,
>> > _m512_[,mask_,maskz_]shldi_epi64): Fix typo of lacking a
>> > closing parenthesis.
>> > * config/i386/avx512vbmi2vlintrin.h
>> > (_mm256_[,mask_,maskz_]shrdi_epi16,
>> > _mm256_[,mask_,maskz_]shrdi_epi32,
>> > _m256_[,mask_,maskz_]shrdi_epi64,
>> > _mm_[,mask_,maskz_]shrdi_epi16,
>> > _mm_[,mask_,maskz_]shrdi_epi32,
>> > _mm_[,mask_,maskz_]shrdi_epi64,
>> > _mm256_[,mask_,maskz_]shldi_epi16,
>> > _mm256_[,mask_,maskz_]shldi_epi32,
>> > _m256_[,mask_,maskz_]shldi_epi64,
>> > _mm_[,mask_,maskz_]shldi_epi16,
>> > _mm_[,mask_,maskz_]shldi_epi32,
>> > _mm_[,mask_,maskz_]shldi_epi64): Ditto.
>> >
>> > gcc/testsuite/
>> > * gcc.target/i386/avx512vbmi2-vpshld-1.c: New test.
>> > * gcc.target/i386/avx512vbmi2-vpshld-O0-1.c: Ditto.
>> > * gcc.target/i386/avx512vbmi2-vpshrd-1.c: Ditto.
>> > * gcc.target/i386/avx512vbmi2-vpshrd-O0-1.c: Ditto.
>> > * gcc.target/i386/avx512vl-vpshld-O0-1.c: Ditto.
>> > * gcc.target/i386/avx512vl-vpshrd-O0-1.c: Ditto.
>>
>> This is obvious patch, so OK for mainline and backports.
>>
>
> Can you please also add missing -mavx512vbmi2 to c++ testcases g++.dg/other/i386-2.C and i386-3.C? Patch is pre-approved if tested appropriately.
>
> Thanks,
> Uros.
>
Will do.
--
BR,
Hongtao
next prev parent reply other threads:[~2020-02-18 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 8:39 Uros Bizjak
2020-02-13 8:53 ` Jakub Jelinek
2020-02-13 9:12 ` Uros Bizjak
2020-02-13 9:31 ` Hongtao Liu
2020-02-14 6:03 ` Hongtao Liu
2020-02-14 7:06 ` Uros Bizjak
2020-02-14 11:16 ` Uros Bizjak
2020-02-14 13:19 ` Hongtao Liu
2020-02-18 8:25 ` Uros Bizjak
2020-02-18 11:01 ` Hongtao Liu [this message]
2020-02-19 2:31 ` Hongtao Liu
-- strict thread matches above, loose matches on Subject: below --
2020-02-13 3:54 Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZc-bzUh6xbVtT_Ahi+59072=U2ct9J7cT6ZZc+1Ymn4RT1tw@mail.gmail.com' \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).