From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id E19E43858D35 for ; Tue, 30 Apr 2024 08:09:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E19E43858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E19E43858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::734 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714464560; cv=none; b=cXzCNXOqMNdFfGm0wtW9wwlq5veuR7L0YIkJp8Dwj6Lz3NuS3jxVuVJc1zy5lG7fEN7DnfqbcvG9gnbJIcxy29z6FihBSzH9DvNSZbdyfPYTApD+iO+2HnXJB9gcyCuKINe6aigrctays4bEySZzXJEo2+ahdS3ccMgfF/hpw3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714464560; c=relaxed/simple; bh=ccqVgocqGRoPElsJtSvAaUWFzClQ90J9bJTkY483hAs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=bzHUndIRu46hSmrkUytvaLzriWWv16haGt1DrvsHVQ2NmG+ZRCK1cdZ1P+s6CBlrjAfS6soFBrN8x1H3fUuNVqYTP46fpb90Wpm9XfJBt28LoHzTYv6laO0g65NRrRYb3bo/1XAdbsudwoT9/9epU0S8liE2J7BY3DsgYqm8ZDQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-790eedf44faso180725785a.3 for ; Tue, 30 Apr 2024 01:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714464556; x=1715069356; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K+HRHn/dX5vNAZWGA9I82b69Reap/zLhvyJuTf3AERY=; b=WeOYrC3fEiHE+NNkMzIKq1/pZYj2WDmyKFAlgsarbp2WbnOYUTBFA+1RsRVUnvSaDK NvjJots4YwiX5untl3QoSgQvGFsu6YF5ble/ntm8dgJLSiPBfHpo5qfEbaJv0JNzHPEY cJ5uA3NGh1Ci6k0FpLgp9hS8ksAChQRnu+fFx7bhE9DUgrfxkM6Bkt3Upkb1iTkT0SXY OutF7k+wd7b6Zt5VQoj0tZM3BZGg92exPs3xdHKTKCk89R3MjJ4AmVRGqw9KnlxIwrDA QSa7KKyLtDDFfIHbxqB098JYa6NvKBJo0aXL2eHbXChKJ6Ve5gYBYWTWznL4ybzE/7OO foeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714464556; x=1715069356; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K+HRHn/dX5vNAZWGA9I82b69Reap/zLhvyJuTf3AERY=; b=kktSlzI64v9Byb1DTEzt/U0aWo/UqGXSmB6zAslVLAlu2E4vDl9nG7gjVjpytgjalB SNs1VRsE673s2l+3ynRYQ7l+FVLAOp+Idq+qk6AyXW0BQkdjhtRirkJmEjofClmUB3/7 uiFBTKhFH4cgmjUHYMCOyzGuIUmua1ezZ4rCgqcDh3reqYjgcTzBa48bqdqD/GSoPNB5 OKTKpvzaAwJi20eGjVMOaVhKtqQ49Vl6zGwzVRn6dsq/YHfnm3fbkuQJMhKaWD3pgiJK Gpkpb7GHZsQWABLDaxenIoIFetsxGOIuzcWmSD4EMDYhM63TgnelLJFofcT745znYvx3 cA8A== X-Forwarded-Encrypted: i=1; AJvYcCUgy4CkmxzvnKs7QQ+H43h4iDmU55yXVaVe/nbv+RvmPUbWVKWfhUJfjNdbwrUbN0WKDGlBKzbzd8V3TQanAMBfDfI6fraleg== X-Gm-Message-State: AOJu0YyLhqc1OOkoDUSy2CyMZGDmdEL5RTP6K8EOG8gy1B0NN8Shi+dQ 4/7fXjIQS7Rtjj99E2/ulKcitofRr2okZrfpZPgcWqupreY6RQv41qEadIPhPAO+5cAkeZMYufL m7tx9mUtbZoqbPujwe48pe5jLTcQ= X-Google-Smtp-Source: AGHT+IGOYw9cMyX3kYTske9XainZrg7J5KPVJ2LsM9n8M22ATg10CTgV7YzdkoXnSk+sGpgsGT0+zpH3bdzzjSYM9h4= X-Received: by 2002:a05:6214:27c5:b0:6a0:b705:2800 with SMTP id ge5-20020a05621427c500b006a0b7052800mr10416860qvb.23.1714464556094; Tue, 30 Apr 2024 01:09:16 -0700 (PDT) MIME-Version: 1.0 References: <20240429134515.4140169-1-hongtao.liu@intel.com> In-Reply-To: From: Hongtao Liu Date: Tue, 30 Apr 2024 16:09:05 +0800 Message-ID: Subject: Re: [PATCH] Don't assert for IFN_COND_{MIN, MAX} in vect_transform_reduction To: Jakub Jelinek Cc: Richard Biener , "H.J. Lu" , liuhongt , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 30, 2024 at 3:38=E2=80=AFPM Jakub Jelinek wr= ote: > > On Tue, Apr 30, 2024 at 09:30:00AM +0200, Richard Biener wrote: > > On Mon, Apr 29, 2024 at 5:30=E2=80=AFPM H.J. Lu w= rote: > > > > > > On Mon, Apr 29, 2024 at 6:47=E2=80=AFAM liuhongt wrote: > > > > > > > > The Fortran standard does not specify what the result of the MAX > > > > and MIN intrinsics are if one of the arguments is a NaN. So it > > > > should be ok to tranform reduction for IFN_COND_MIN with vectorized > > > > COND_MIN and REDUC_MIN. > > > > > > The commit subject isn't very clear. This patch isn't about "Don't = assert > > > for IFN_COND_{MIN,MAX}". It allows IFN_COND_{MIN,MAX} in > > > vect_transform_reduction. > > > > Well, we allow it elsewhere, we just fail to enumerate all COND_* we al= low > > here correctly. > > > > > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > > > > Ok for trunk and backport to GCC14? > > > > OK for trunk and branch. > > Oops, I've just sent the same patch, just with a different testcase > (reduced and which tests both the min and max). > I think the reduced testcase is better. Yes, please commit your patch :) > > > > > gcc/ChangeLog: > > > > > > > > PR 114883 > > Missing tree-optimization/ > > > > > * tree-vect-loop.cc (vect_transform_reduction): Don't asser= t > > > > for IFN_COND_{MIN, MAX}. > > > > > > > > gcc/testsuite/ChangeLog: > > > > > > > > * gfortran.dg/pr114883.f90: New test. > > Jakub > --=20 BR, Hongtao