public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hongtao Liu <crazylht@gmail.com>
To: Hongyu Wang <wwwhhhyyy333@gmail.com>
Cc: liuhongt <hongtao.liu@intel.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix typo in standard pattern name of trunc<mode><pmov_dst_4>2.
Date: Mon, 5 Jul 2021 13:09:01 +0800	[thread overview]
Message-ID: <CAMZc-bzoqL45vjXjwkkRwAUQDD4Cp+Q3LCgZ9G2+r=NWdKzo-A@mail.gmail.com> (raw)
In-Reply-To: <CA+OydWk9WC27_taY9PSURobtb6DHwMU5tgZqA03E63GT_yJTvA@mail.gmail.com>

Hi:
  pushed to master.


    Remove xfail for pr92658-avx512vl.c

    Typo of standard pattern name has been fixed by r12-1970, remove those
    xfails.

    gcc/testsuite/ChangeLog

            * gcc.target/i386/pr92658-avx512vl.c: Refine testcase.

diff --git a/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
b/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
index a9f7d7e6499..7ff9c19ee36 100644
--- a/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
+++ b/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
@@ -122,8 +122,7 @@ truncdb_128 (v16qi * dst, v4si * __restrict src)
 }

 /* { dg-final { scan-assembler-times "vpmovqd" 2 } } */
-/* { dg-final { scan-assembler-times "vpmovqw" 2 { xfail *-*-* } } } */
+/* { dg-final { scan-assembler-times "vpmovqw" 2 } } */
 /* { dg-final { scan-assembler-times "vpmovqb" 2 { xfail *-*-* } } } */
-/* { dg-final { scan-assembler-times "vpmovdw" 1 } } */
-/* { dg-final { scan-assembler-times "vpmovdw" 2 { xfail *-*-* } } } */
+/* { dg-final { scan-assembler-times "vpmovdw" 2 } } */
 /* { dg-final { scan-assembler-times "vpmovdb" 2 } } */

On Fri, Jul 2, 2021 at 4:14 PM Hongyu Wang via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> This caused
>
> XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2
> FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 1
> XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2
>
> liuhongt via Gcc-patches <gcc-patches@gcc.gnu.org> 于2021年7月1日周四 下午3:45写道:
> >
> >   Bootstrapped and regtested on x86_64-linux-gnu{-m32,}.
> >   Pushed to trunk as abvious fix.
> >
> > gcc/ChangeLog
> >
> >         * config/i386/sse.md (trunc<mode><pmov_dst_4>2): Refined to ..
> >         (trunc<mode><pmov_dst_4_lower>2): this.
> > ---
> >  gcc/config/i386/sse.md | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> > index ffcc0c81964..c6be2aa144b 100644
> > --- a/gcc/config/i386/sse.md
> > +++ b/gcc/config/i386/sse.md
> > @@ -11199,12 +11199,14 @@ (define_insn_and_split "avx512vl_<code><mode>v8qi2_mask_store_2"
> >  (define_mode_iterator PMOV_SRC_MODE_4 [V4DI V2DI V4SI])
> >  (define_mode_attr pmov_dst_4
> >    [(V4DI "V4HI") (V2DI "V2HI") (V4SI "V4HI")])
> > +(define_mode_attr pmov_dst_4_lower
> > +  [(V4DI "v4hi") (V2DI "v2hi") (V4SI "v4hi")])
> >  (define_mode_attr pmov_dst_zeroed_4
> >    [(V4DI "V4HI") (V2DI "V6HI") (V4SI "V4HI")])
> >  (define_mode_attr pmov_suff_4
> >    [(V4DI "qw") (V2DI "qw") (V4SI "dw")])
> >
> > -(define_expand "trunc<mode><pmov_dst_4>2"
> > +(define_expand "trunc<mode><pmov_dst_4_lower>2"
> >    [(set (match_operand:<pmov_dst_4> 0 "register_operand")
> >         (truncate:<pmov_dst_4>
> >           (match_operand:PMOV_SRC_MODE_4 1 "register_operand")))]
> > --
> > 2.18.1
> >



-- 
BR,
Hongtao

      reply	other threads:[~2021-07-05  5:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  7:45 liuhongt
2021-07-02  8:10 ` Hongyu Wang
2021-07-05  5:09   ` Hongtao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZc-bzoqL45vjXjwkkRwAUQDD4Cp+Q3LCgZ9G2+r=NWdKzo-A@mail.gmail.com' \
    --to=crazylht@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hongtao.liu@intel.com \
    --cc=wwwhhhyyy333@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).