[PATCH] Fix typo in standard pattern name of trunc<mode><pmov_dst_4>2.

[PATCH] Fix typo in standard pattern name of trunc<mode><pmov_dst_4>2.

[liuhongt]

  Bootstrapped and regtested on x86_64-linux-gnu{-m32,}.
  Pushed to trunk as abvious fix.

gcc/ChangeLog

	* config/i386/sse.md (trunc<mode><pmov_dst_4>2): Refined to ..
	(trunc<mode><pmov_dst_4_lower>2): this.
---
 gcc/config/i386/sse.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index ffcc0c81964..c6be2aa144b 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -11199,12 +11199,14 @@ (define_insn_and_split "avx512vl_<code><mode>v8qi2_mask_store_2"
 (define_mode_iterator PMOV_SRC_MODE_4 [V4DI V2DI V4SI])
 (define_mode_attr pmov_dst_4
   [(V4DI "V4HI") (V2DI "V2HI") (V4SI "V4HI")])
+(define_mode_attr pmov_dst_4_lower
+  [(V4DI "v4hi") (V2DI "v2hi") (V4SI "v4hi")])
 (define_mode_attr pmov_dst_zeroed_4
   [(V4DI "V4HI") (V2DI "V6HI") (V4SI "V4HI")])
 (define_mode_attr pmov_suff_4
   [(V4DI "qw") (V2DI "qw") (V4SI "dw")])
 
-(define_expand "trunc<mode><pmov_dst_4>2"
+(define_expand "trunc<mode><pmov_dst_4_lower>2"
   [(set (match_operand:<pmov_dst_4> 0 "register_operand")
 	(truncate:<pmov_dst_4>
 	  (match_operand:PMOV_SRC_MODE_4 1 "register_operand")))]
-- 
2.18.1

Re: [PATCH] Fix typo in standard pattern name of trunc<mode><pmov_dst_4>2.

[Hongyu Wang]

This caused

XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2
FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 1
XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2

liuhongt via Gcc-patches <gcc-patches@gcc.gnu.org> 于2021年7月1日周四 下午3:45写道：
>
>   Bootstrapped and regtested on x86_64-linux-gnu{-m32,}.
>   Pushed to trunk as abvious fix.
>
> gcc/ChangeLog
>
>         * config/i386/sse.md (trunc<mode><pmov_dst_4>2): Refined to ..
>         (trunc<mode><pmov_dst_4_lower>2): this.
> ---
>  gcc/config/i386/sse.md | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> index ffcc0c81964..c6be2aa144b 100644
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -11199,12 +11199,14 @@ (define_insn_and_split "avx512vl_<code><mode>v8qi2_mask_store_2"
>  (define_mode_iterator PMOV_SRC_MODE_4 [V4DI V2DI V4SI])
>  (define_mode_attr pmov_dst_4
>    [(V4DI "V4HI") (V2DI "V2HI") (V4SI "V4HI")])
> +(define_mode_attr pmov_dst_4_lower
> +  [(V4DI "v4hi") (V2DI "v2hi") (V4SI "v4hi")])
>  (define_mode_attr pmov_dst_zeroed_4
>    [(V4DI "V4HI") (V2DI "V6HI") (V4SI "V4HI")])
>  (define_mode_attr pmov_suff_4
>    [(V4DI "qw") (V2DI "qw") (V4SI "dw")])
>
> -(define_expand "trunc<mode><pmov_dst_4>2"
> +(define_expand "trunc<mode><pmov_dst_4_lower>2"
>    [(set (match_operand:<pmov_dst_4> 0 "register_operand")
>         (truncate:<pmov_dst_4>
>           (match_operand:PMOV_SRC_MODE_4 1 "register_operand")))]
> --
> 2.18.1
>

Re: [PATCH] Fix typo in standard pattern name of trunc<mode><pmov_dst_4>2.

[Hongtao Liu]

Hi:
  pushed to master.


    Remove xfail for pr92658-avx512vl.c

    Typo of standard pattern name has been fixed by r12-1970, remove those
    xfails.

    gcc/testsuite/ChangeLog

            * gcc.target/i386/pr92658-avx512vl.c: Refine testcase.

diff --git a/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
b/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
index a9f7d7e6499..7ff9c19ee36 100644
--- a/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
+++ b/gcc/testsuite/gcc.target/i386/pr92658-avx512vl.c
@@ -122,8 +122,7 @@ truncdb_128 (v16qi * dst, v4si * __restrict src)
 }

 /* { dg-final { scan-assembler-times "vpmovqd" 2 } } */
-/* { dg-final { scan-assembler-times "vpmovqw" 2 { xfail *-*-* } } } */
+/* { dg-final { scan-assembler-times "vpmovqw" 2 } } */
 /* { dg-final { scan-assembler-times "vpmovqb" 2 { xfail *-*-* } } } */
-/* { dg-final { scan-assembler-times "vpmovdw" 1 } } */
-/* { dg-final { scan-assembler-times "vpmovdw" 2 { xfail *-*-* } } } */
+/* { dg-final { scan-assembler-times "vpmovdw" 2 } } */
 /* { dg-final { scan-assembler-times "vpmovdb" 2 } } */

On Fri, Jul 2, 2021 at 4:14 PM Hongyu Wang via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> This caused
>
> XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2
> FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 1
> XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2
>
> liuhongt via Gcc-patches <gcc-patches@gcc.gnu.org> 于2021年7月1日周四 下午3:45写道：
> >
> >   Bootstrapped and regtested on x86_64-linux-gnu{-m32,}.
> >   Pushed to trunk as abvious fix.
> >
> > gcc/ChangeLog
> >
> >         * config/i386/sse.md (trunc<mode><pmov_dst_4>2): Refined to ..
> >         (trunc<mode><pmov_dst_4_lower>2): this.
> > ---
> >  gcc/config/i386/sse.md | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> > index ffcc0c81964..c6be2aa144b 100644
> > --- a/gcc/config/i386/sse.md
> > +++ b/gcc/config/i386/sse.md
> > @@ -11199,12 +11199,14 @@ (define_insn_and_split "avx512vl_<code><mode>v8qi2_mask_store_2"
> >  (define_mode_iterator PMOV_SRC_MODE_4 [V4DI V2DI V4SI])
> >  (define_mode_attr pmov_dst_4
> >    [(V4DI "V4HI") (V2DI "V2HI") (V4SI "V4HI")])
> > +(define_mode_attr pmov_dst_4_lower
> > +  [(V4DI "v4hi") (V2DI "v2hi") (V4SI "v4hi")])
> >  (define_mode_attr pmov_dst_zeroed_4
> >    [(V4DI "V4HI") (V2DI "V6HI") (V4SI "V4HI")])
> >  (define_mode_attr pmov_suff_4
> >    [(V4DI "qw") (V2DI "qw") (V4SI "dw")])
> >
> > -(define_expand "trunc<mode><pmov_dst_4>2"
> > +(define_expand "trunc<mode><pmov_dst_4_lower>2"
> >    [(set (match_operand:<pmov_dst_4> 0 "register_operand")
> >         (truncate:<pmov_dst_4>
> >           (match_operand:PMOV_SRC_MODE_4 1 "register_operand")))]
> > --
> > 2.18.1
> >



-- 
BR,
Hongtao