From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by sourceware.org (Postfix) with ESMTPS id D9E803858001 for ; Mon, 4 Jan 2021 05:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D9E803858001 Received: by mail-ua1-x92f.google.com with SMTP id j59so8731727uad.5 for ; Sun, 03 Jan 2021 21:54:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VNF9GSM/CLE/9reOS7GtbDAr08Aolv/bbl3ys102KJQ=; b=Ag35EhtR2IxogO3F7eYuiEku6LrmuBihluDV5WBJm6pybtjxw5qw0071S8nlheUwt9 p0oAgqrgYLxY4vX8TRF1VSYpHmIrjdWswnjnItCqCK08lhEraY8gS2M1h3ee6N0SW4wc q4t+yZ21o+PCDJqi2J1CrvsMQtoH9Tmnnhrn0NNXLGAaL4oQV94W4Besmi7OqGwj9Qq8 4jcrOjSdUnI7BpnAtT/j9/gdGFi7QFJ56qLgjh9/LEr28mtyCGvyg8QZvYGlWs7bL/Xg Q/LmcIwD3tm8+XGcQFrvdPPULZitiNWRsGMgk4m8pEfFj4vtlmgKUFRoQ2JRYRgwTvOG 7bUw== X-Gm-Message-State: AOAM533bY75FQJCF8fYJoZMZ6AcOk3oriP/CD3YbxpxRfBRZ5VU2th3z BccSDydXIuuu5z8n63zamhCG9IAUKRaLB4Y3fKpAsskpCNfbfw== X-Google-Smtp-Source: ABdhPJzwdZ3n6/z6XU29mkqlDr45WmNbgLYCf6dB+SRX6JZIY2cEAWjcwW9O/KCR7sThYCDJfMEGr3TNTgNVwWVQetc= X-Received: by 2002:ab0:127:: with SMTP id 36mr43055397uak.118.1609739649282; Sun, 03 Jan 2021 21:54:09 -0800 (PST) MIME-Version: 1.0 From: Hongtao Liu Date: Mon, 4 Jan 2021 13:56:44 +0800 Message-ID: Subject: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461] To: GCC Patches , Kirill Yukhin , Uros Bizjak Cc: "H. J. Lu" , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 05:54:11 -0000 Hi: The following patch adds define_insn_and_split to optimize vpmovmskb %xmm0, %eax - movzwl %ax, %eax notl %eax Bootstrapped/regtested on x86_64-linux-gnu {,-m32}. Ok for trunk? gcc/ChangeLog PR target/98461 * config/i386/sse.md (*sse2_pmovskb_zexthisi): New define_insn_and_split for zero_extend of subreg HI of pmovskb result. gcc/testsuite/ChangeLog * gcc.target/i386/sse-pr98461-2.c: New test. --- gcc/config/i386/sse.md | 11 +++++++++++ gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c | 13 +++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index d84103807ff..4ed6b9ae476 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -16099,6 +16099,17 @@ (define_insn "*sse2_pmovmskb_ext" (set_attr "prefix" "maybe_vex") (set_attr "mode" "SI")]) +(define_insn_and_split "*sse2_pmovskb_zexthisi" + [(set (match_operand:SI 0 "register_operand") + (zero_extend:SI (subreg:HI (unspec:SI + [(match_operand:V16QI 1 "register_operand")] + UNSPEC_MOVMSK) 0)))] + "TARGET_SSE2" + "#" + "&& 1" + [(set (match_dup 0) + (unspec:SI [(match_dup 1)] UNSPEC_MOVMSK))]) + (define_split [(set (match_operand:SI 0 "register_operand") (unspec:SI diff --git a/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c b/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c new file mode 100644 index 00000000000..60fc1f3e9c1 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c @@ -0,0 +1,13 @@ +/* PR target/98461 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -msse2 -mno-sse3 -masm=att" } */ +/* { dg-final { scan-assembler-times "\tpmovmskb\t" 1 } } */ +/* { dg-final { scan-assembler-not "\tmovzwl" } } */ +/* { dg-final { scan-assembler-times "\tnotl" 1 } } */ + +#include + +unsigned int movemask_not1(__m128i logical) { + unsigned short res = (unsigned short)(_mm_movemask_epi8(logical)); + return ~res; +} -- 2.18.1 -- BR, Hongtao