From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by sourceware.org (Postfix) with ESMTPS id 2F78A3853543 for ; Wed, 12 Oct 2022 01:55:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F78A3853543 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-35711e5a5ceso143121137b3.13 for ; Tue, 11 Oct 2022 18:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JbaGQu6PW7S6dMs6DRCvZYN2qGdvxhlzkbfgX5KlmWU=; b=UMo4sURQm1tMpKlFoUHQebQK6YOdHwubPrKk3/Gpel3Mf+WAGr0AlONk10o39Yf9sF cSLKjLIcnEp8m2HYZcWoceWcwN88OFk1f+oT0CMqSaHrgbb0cHpkK0kOAOmK5UbzXWX5 3Y0LqCyeT5V0gfJexq/ZWciSl1i4Gsij7rhSoVviSWVF5Np5sY/EsU/CXi/46mk5/m4m 0Tc8MF9+rxiWigYSYMIylHW6z9gcWAN2udDfAA+FPHQDHIAHo6tQrHOF05u8yaPqxILK 0HpZ+6kPbuQxDqlkzXmpau1phdrgWA/P1M/fTc51swconGNtfsxgy6XLTli4vTuNffu8 HA1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JbaGQu6PW7S6dMs6DRCvZYN2qGdvxhlzkbfgX5KlmWU=; b=jxxUlpeyTpWwVb8yeVVnDO9BSSCzm4u8HjW0jGyom/uNQvnJGAU534cX10yD5ncru6 ArovKukflTiz3JNCoNjbyJ2J1mHaiO9oLw6CAofR2xRxFzrVWMV13ruFFNDGGkxl/cj+ MuJp6i5L3YEvlfclmL2VTFf4N4e4Cc2rFsrcIaOmbU3VJChBLD44C3m1ccajfUgg4t5h eoi3iSH89Xy2n2lZFF4AMnJ3kxubDFcdmZeMp8rBe8RBOWtV34YvhsZfDgZ1lqh6qjvn GpXNt3SPOOg8S0m+11lMkOUQ21ApV5PCkkhAg9nydmcjhjmfq7qR/N50OKvxWTfU9o+D vCAQ== X-Gm-Message-State: ACrzQf1I8t7vJLaEXGx7+5ILUF53nR2V4zX9K5ORp/1Z6X+LzZHmHe2M 6P4LAJlasw1/j6ksRjd253rvHkV/oZJ9Sx+4iYLvk2JX8HaJcA== X-Google-Smtp-Source: AMsMyM7Bk14cEVEqyAj9eWXLHQ2NtCqlg9DLZky6AD3kUL0tC/VcCOC3hDTfWuPu1ZjqwZ2l2bKcJTtEMwB7HDp1l9k= X-Received: by 2002:a81:5344:0:b0:360:9535:bde3 with SMTP id h65-20020a815344000000b003609535bde3mr16507289ywb.344.1665539747418; Tue, 11 Oct 2022 18:55:47 -0700 (PDT) MIME-Version: 1.0 References: <4a6f2350-f070-1473-63a5-3232968d3a89@arm.com> <4ea91767-de43-9d30-5bd2-a9a0759760c7@arm.com> <69abe824-94f5-95b5-fb7f-6fa076973e05@arm.com> <8f805fb1-d4ae-b0e3-ff26-57fd2c1fc1f7@arm.com> <5c3e3af5-c502-fd5a-2792-4e0d1db405ef@arm.com> <42e266bd-7224-76b7-c782-c00063531917@arm.com> <29d958e5-364f-5784-5764-e9b5d364448a@arm.com> <737c6298-8611-7026-9850-6494f93e2922@arm.com> In-Reply-To: <737c6298-8611-7026-9850-6494f93e2922@arm.com> From: Hongtao Liu Date: Wed, 12 Oct 2022 09:55:35 +0800 Message-ID: Subject: Re: [PATCH] Teach vectorizer to deal with bitfield accesses (was: [RFC] Teach vectorizer to deal with bitfield reads) To: "Andre Vieira (lists)" Cc: Richard Biener , Jakub Jelinek , Richard Sandiford , Richard Biener , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This commit failed tests FAIL: gcc.target/i386/pr101668.c scan-assembler vpmovsxdq FAIL: gcc.target/i386/pr101668.c scan-assembler vpmovsxdq FAIL: gcc.target/i386/pr101668.c scan-assembler vpmovsxdq FAIL: gcc.target/i386/pr92645.c scan-tree-dump-times optimized "vec_unpack_" 4 FAIL: gcc.target/i386/pr92645.c scan-tree-dump-times optimized "vec_unpack_" 4 FAIL: gcc.target/i386/pr92645.c scan-tree-dump-times optimized "vec_unpack_" 4 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx2-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx2.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-avx512bw-trunc.c scan-assembler-times vpmovwb 3 FAIL: gcc.target/i386/pr92658-avx512bw-trunc.c scan-assembler-times vpmovwb 3 FAIL: gcc.target/i386/pr92658-avx512bw-trunc.c scan-assembler-times vpmovwb 3 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdw 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdw 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovdw 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqb 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqd 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqd 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqd 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqw 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqw 1 FAIL: gcc.target/i386/pr92658-avx512f.c scan-assembler-times vpmovqw 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdb 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdb 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdb 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%xmm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%xmm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%xmm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%ymm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%ymm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqb[ \t]*%ymm 1 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqd 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqd 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqd 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxbw 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxdq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwd 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-sse4-2.c scan-assembler-times pmovsxwq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxbw 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxdq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwd 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwq 2 FAIL: gcc.target/i386/pr92658-sse4.c scan-assembler-times pmovzxwq 2 On Fri, Oct 7, 2022 at 10:21 PM Andre Vieira (lists) via Gcc-patches wrote: > > Hi, > > Whilst running a bootstrap with extra options to force bitfield > vectorization '-O2 -ftree-vectorize -ftree-loop-if-convert > -fno-vect-cost-model' I ran into an ICE in vect-patterns where a > bit_field_ref had a container that wasn't INTEGRAL_TYPE and had a > E_BLKmode, which meant we failed to build an integer type with the same > size. For that reason I added a check to bail out earlier if the > TYPE_MODE of the container is indeed E_BLKmode. The pattern for the > bitfield inserts required no change as we currently don't support > containers that aren't integer typed. > > Also changed a testcase because in BIG-ENDIAN it was not vectorizing due > to a different size of container that wasn't supported. > > This passes the same bootstrap and regressions on aarch64-none-linux and > no regressions on aarch64_be-none-elf either. > > I assume you are OK with these changes Richard, but I don't like to > commit on Friday in case something breaks over the weekend, so I'll > leave it until Monday. > > Thanks, > Andre > > On 29/09/2022 08:54, Richard Biener wrote: > > On Wed, Sep 28, 2022 at 7:32 PM Andre Vieira (lists) via Gcc-patches > > wrote: > >> Made the change and also created the ChangeLogs. > > OK if bootstrap / testing succeeds. > > > > Thanks, > > Richard. > > > >> gcc/ChangeLog: > >> > >> * tree-if-conv.cc (if_convertible_loop_p_1): Move ordering of > >> loop bb's from here... > >> (tree_if_conversion): ... to here. Also call bitfield lowering > >> when appropriate. > >> (version_loop_for_if_conversion): Adapt to enable loop > >> versioning when we only need > >> to lower bitfields. > >> (ifcvt_split_critical_edges): Relax condition of expected loop > >> form as this is checked earlier. > >> (get_bitfield_rep): New function. > >> (lower_bitfield): Likewise. > >> (bitfields_to_lower_p): Likewise. > >> (need_to_lower_bitfields): New global boolean. > >> (need_to_ifcvt): Likewise. > >> * tree-vect-data-refs.cc (vect_find_stmt_data_reference): > >> Improve diagnostic message. > >> * tree-vect-patterns.cc (vect_recog_temp_ssa_var): Add default > >> value for last parameter. > >> (vect_recog_bitfield_ref_pattern): New. > >> (vect_recog_bit_insert_pattern): New. > >> > >> gcc/testsuite/ChangeLog: > >> > >> * gcc.dg/vect/vect-bitfield-read-1.c: New test. > >> * gcc.dg/vect/vect-bitfield-read-2.c: New test. > >> * gcc.dg/vect/vect-bitfield-read-3.c: New test. > >> * gcc.dg/vect/vect-bitfield-read-4.c: New test. > >> * gcc.dg/vect/vect-bitfield-read-5.c: New test. > >> * gcc.dg/vect/vect-bitfield-read-6.c: New test. > >> * gcc.dg/vect/vect-bitfield-write-1.c: New test. > >> * gcc.dg/vect/vect-bitfield-write-2.c: New test. > >> * gcc.dg/vect/vect-bitfield-write-3.c: New test. > >> * gcc.dg/vect/vect-bitfield-write-4.c: New test. > >> * gcc.dg/vect/vect-bitfield-write-5.c: New test. > >> > >> On 28/09/2022 10:43, Andre Vieira (lists) via Gcc-patches wrote: > >>> On 27/09/2022 13:34, Richard Biener wrote: > >>>> On Mon, 26 Sep 2022, Andre Vieira (lists) wrote: > >>>> > >>>>> On 08/09/2022 12:51, Richard Biener wrote: > >>>>>> I'm curious, why the push to redundant_ssa_names? That could use > >>>>>> a comment ... > >>>>> So I purposefully left a #if 0 #else #endif in there so you can see > >>>>> the two > >>>>> options. But the reason I used redundant_ssa_names is because ifcvt > >>>>> seems to > >>>>> use that as a container for all pairs of (old, new) ssa names to > >>>>> replace > >>>>> later. So I just piggy backed on that. I don't know if there's a > >>>>> specific > >>>>> reason they do the replacement at the end? Maybe some ordering > >>>>> issue? Either > >>>>> way both adding it to redundant_ssa_names or doing the replacement > >>>>> inline work > >>>>> for the bitfield lowering (or work in my testing at least). > >>>> Possibly because we (in the past?) inserted/copied stuff based on > >>>> predicates generated at analysis time after we decide to elide something > >>>> so we need to watch for later appearing uses. But who knows ... my mind > >>>> fails me here. > >>>> > >>>> If it works to replace uses immediately please do so. But now > >>>> I wonder why we need this - the value shouldn't change so you > >>>> should get away with re-using the existing SSA name for the final value? > >>> Yeah... good point. A quick change and minor testing seems to agree. > >>> I'm sure I had a good reason to do it initially ;) > >>> > >>> I'll run a full-regression on this change to make sure I didn't miss > >>> anything. > >>> -- BR, Hongtao