From: Ilya Enkovich <enkovich.gnu@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Avoid false vector mask conversion
Date: Wed, 02 Dec 2015 10:39:00 -0000 [thread overview]
Message-ID: <CAMbmDYYoLReMx8Nbu8Cn7-q8kq1vbHRGDj1ZfVyAfq0mtgktzg@mail.gmail.com> (raw)
In-Reply-To: <CAMbmDYbyJdpKfvaCy-iWHTXp0_u7z5hA=6bCCGVpCjV3M9QHSA@mail.gmail.com>
Ping
2015-11-23 16:05 GMT+03:00 Ilya Enkovich <enkovich.gnu@gmail.com>:
> Ping
>
> 2015-11-13 16:17 GMT+03:00 Ilya Enkovich <enkovich.gnu@gmail.com>:
>> 2015-11-13 13:03 GMT+03:00 Richard Biener <richard.guenther@gmail.com>:
>>> On Thu, Nov 12, 2015 at 5:08 PM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> When we use LTO for fortran we may have a mix 32bit and 1bit scalar booleans. It means we may have conversion of one scalar type to another which confuses vectorizer because values with different scalar boolean type may get the same vectype.
>>>
>>> Confuses aka fails to vectorize?
>>
>> Right.
>>
>>>
>>>> This patch transforms such conversions into comparison.
>>>>
>>>> I managed to make a small fortran test which gets vectorized with this patch but I didn't find how I can run fortran test with LTO and then scan tree dump to check it is vectorized. BTW here is a loop from the test:
>>>>
>>>> real*8 a(18)
>>>> logical b(18)
>>>> integer i
>>>>
>>>> do i=1,18
>>>> if(a(i).gt.0.d0) then
>>>> b(i)=.true.
>>>> else
>>>> b(i)=.false.
>>>> endif
>>>> enddo
>>>
>>> This looks the the "error" comes from if-conversion - can't we do
>>> better there then?
>>
>> No, this loop is transformed into a single BB before if-conversion by
>> cselim + phiopt.
>>
>> Ilya
>>
>>>
>>> Richard.
>>>
>>>> Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk?
>>>>
>>>> Thanks,
>>>> Ilya
next prev parent reply other threads:[~2015-12-02 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 16:09 Ilya Enkovich
2015-11-13 10:04 ` Richard Biener
2015-11-13 13:17 ` Ilya Enkovich
2015-11-23 13:15 ` Ilya Enkovich
2015-12-02 10:39 ` Ilya Enkovich [this message]
2015-12-02 14:52 ` Richard Biener
2015-12-02 15:25 ` Ilya Enkovich
2015-12-02 15:27 ` Richard Biener
2015-12-04 15:01 ` Ilya Enkovich
2015-12-10 11:18 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMbmDYYoLReMx8Nbu8Cn7-q8kq1vbHRGDj1ZfVyAfq0mtgktzg@mail.gmail.com \
--to=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).