public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ilya Enkovich <enkovich.gnu@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix ice on comdat groups with -check-pointer-bounds
Date: Mon, 30 Mar 2015 09:59:00 -0000	[thread overview]
Message-ID: <CAMbmDYZUJ+Zebs=FBeEZaN3E8AO1RQFjAq=je4JEYfz7hDQVtA@mail.gmail.com> (raw)
In-Reply-To: <20150327152309.GD63825@kam.mff.cuni.cz>

2015-03-27 18:23 GMT+03:00 Jan Hubicka <hubicka@ucw.cz>:
> Hi,
> this patch fixes bug in symtab_node::verify_symtab_nodes pointed out by Ilya.
> The loop checking that there all comdats are linked by same_comdat_group was
> completely bogus.  In addition it checked also external symbols that are
> currently not kept in groups.  This bug was in mainline for months but
> apparently bounds checking is first code producing interesting comdat groups to
> trigger it.
>
> Ilya, can you please mind comitting the testcase? I am not quite sure where
> bounds checking should go offhand.
>
> Also concerning linking the comdat groups, currently all non-DECL_EXTERNAL symbols
> are linked and all !DECL_EXTERNAL symbols are non-linked.  Bounds checking should
> follow this scheme.  It may be cleaner to keep links for DECL_EXTERNAL, but lets
> deffer that for next stage1.

I'll send a corresponding fix in a checker with a testcase.  Please
let me know when you introduce comdat links for external symbols to
keep the checker in sync.

Thanks,
Ilya

>
> Bootstrapped/regtested x86_64-linux. Committed.
>
> Honza
>

  reply	other threads:[~2015-03-30  9:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 15:23 Jan Hubicka
2015-03-30  9:59 ` Ilya Enkovich [this message]
2015-03-30 11:05 ` Ilya Enkovich
2015-03-30 11:31   ` Ilya Enkovich
2015-03-30 17:20     ` Jan Hubicka
2015-03-31 11:43       ` Ilya Enkovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMbmDYZUJ+Zebs=FBeEZaN3E8AO1RQFjAq=je4JEYfz7hDQVtA@mail.gmail.com' \
    --to=enkovich.gnu@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).