From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26038 invoked by alias); 3 Apr 2012 21:13:27 -0000 Received: (qmail 26028 invoked by uid 22791); 3 Apr 2012 21:13:25 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Apr 2012 21:13:11 +0000 Received: by pbcum15 with SMTP id um15so285995pbc.20 for ; Tue, 03 Apr 2012 14:13:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.131.67 with SMTP id ok3mr1654094pbb.89.1333487591274; Tue, 03 Apr 2012 14:13:11 -0700 (PDT) Received: by 10.68.220.97 with HTTP; Tue, 3 Apr 2012 14:13:10 -0700 (PDT) In-Reply-To: <19814787-A27D-4AA3-B4AC-9A95F6CDDABB@codesourcery.com> References: <455FBC37-ADBD-48E2-8D8E-6EB3C7198A29@codesourcery.com> <2BF7C200-54B2-4F21-AE1C-6CBC8FDA1772@codesourcery.com> <19814787-A27D-4AA3-B4AC-9A95F6CDDABB@codesourcery.com> Date: Tue, 03 Apr 2012 21:13:00 -0000 Message-ID: Subject: Re: [PATCH, i386, Android] -mandroid support for i386 target From: Ilya Enkovich To: Maxim Kuvyrkov Cc: "H.J. Lu" , gcc-patches Patches , pavel.v.chupin@gmail.com, Jing Yu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg00128.txt.bz2 > On 4/04/2012, at 2:56 AM, H.J. Lu wrote: > >> On Tue, Apr 3, 2012 at 3:49 AM, Ilya Enkovich w= rote: >>>> >>>> It's simpler that you think. =A0The target headers ($tm_file in config= .gcc -- gnu-user.h, linux*.h, etc. in this case) are all included into tm.h= , which serves as proxy to all those headers. =A0All definitions made in pr= eceding headers are available in subsequent headers. =A0So, given that i386= /gnu-user*.h precedes i386/linux*.h in config.gcc's $tm_file, you only need= to touch linux*.h. >>>> >>>> Thanks, >>>> >>>> -- >>>> Maxim Kuvyrkov >>>> CodeSourcery / Mentor Graphics >>>> >>> >>> >>> Hi, >>> >>> I prepared version with common linux.h and gnu-user.h. Does it look OK? >>> >>> Bootstrapped and checked on linux-x86_64. >>> >> >> There are so many duplicates in gnu-user64.h and gnu-user32.h. >> Please move all of them to gnu-user.h. > > Ilya, > > Why i386/gnu-user.h had to change at all? =A0It seems like you trying to = clean up/simplify stuff in i386/gnu-user.h, but in this case it seems (a) n= ot required for the main purpose of this submission, and (b) excessive. Hi, Initially my patch introduced few macroses in i386/gnu-user.h to use them in i386/linux.h. After I created new i386/linux.h and included it into i386/linux64.h I got a build failure because new i386/linux.h used these new definition from i386/gnu-user.h and only i386/gnu-user64.h was included into tm.h. So, I renamed i386/gnu-user.h into i386/gnu-user32.h and created new i386/gnu-user.h with these missing definitions. Otherwise I would have to copy all changes made in i386/gnu-user.h to i386/gnu-user64.h. Thanks, Ilya > > As a side note, if it were up to me, I would merge current i386/linux.h a= nd i386/linux64.h into one file -- i386/linux.h -- instead of having simila= r definitions spread around. =A0But that would be a clean up in itself, and= would require a separate submission. > > Thank you, > > -- > Maxim Kuvyrkov > CodeSourcery / Mentor Graphics >