From: Ilya Enkovich <enkovich.gnu@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library
Date: Tue, 11 Nov 2014 20:26:00 -0000 [thread overview]
Message-ID: <CAMbmDYbPWRL-RNS=h38FSAEN0JDsY6Ndg84rJvMy9iUY9QmyuQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1411111807040.26374@digraph.polyomino.org.uk>
2014-11-11 21:09 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> On Tue, 11 Nov 2014, Joseph Myers wrote:
>
>> You have lots of static writable variables. Are you sure all those
>> variables are handled in a thread-safe way (e.g. only modified before any
>> threads start)?
>
> Another general multi-thread issue for libraries: files should be opened
> with O_CLOEXEC (that's the "e" flag to fopen when using glibc) unless you
> have a clear reason not to do so.
Hello Joseph,
Thanks a lot for your comments! I'll fix these problems and be back
with more safe version.
Ilya
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2014-11-11 20:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 15:37 Ilya Enkovich
2014-11-11 18:09 ` Joseph Myers
2014-11-11 18:15 ` Joseph Myers
2014-11-11 20:26 ` Ilya Enkovich [this message]
2014-11-11 18:49 ` Andi Kleen
2014-11-11 20:22 ` H.J. Lu
2014-11-11 21:04 ` Andi Kleen
2014-11-11 21:11 ` H.J. Lu
2014-11-11 21:24 ` Andi Kleen
2014-11-11 21:37 ` Joseph Myers
2014-11-11 22:07 ` H.J. Lu
2014-11-11 22:10 ` Joseph Myers
2014-11-11 20:36 ` Joseph Myers
2014-11-12 16:20 ` Ilya Enkovich
2014-11-12 21:41 ` Joseph Myers
2014-11-12 22:56 ` Ilya Enkovich
2014-11-12 23:11 ` Joseph Myers
2014-11-13 8:39 ` Ilya Enkovich
2014-11-13 20:56 ` Joseph Myers
2014-11-19 14:18 ` Ilya Enkovich
2014-11-19 18:05 ` Jeff Law
2014-11-19 18:16 ` Ilya Enkovich
2014-11-21 16:04 ` Ilya Enkovich
2014-11-21 23:49 ` Joseph Myers
2014-11-24 14:28 ` Ilya Enkovich
2014-12-09 8:25 ` Ilya Enkovich
2014-12-09 20:48 ` Jeff Law
2014-12-09 20:56 ` Ilya Enkovich
2015-03-02 16:19 ` Ilya Enkovich
2015-03-04 17:36 ` Jeff Law
2014-11-22 0:26 ` Joseph Myers
2014-11-11 20:06 ` Jeff Law
2014-11-11 20:24 ` Ilya Enkovich
2014-11-12 20:53 ` Jeff Law
2014-11-12 8:36 ` Richard Biener
2014-11-12 8:38 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMbmDYbPWRL-RNS=h38FSAEN0JDsY6Ndg84rJvMy9iUY9QmyuQ@mail.gmail.com' \
--to=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).