From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114277 invoked by alias); 8 Oct 2015 11:10:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114267 invoked by uid 89); 8 Oct 2015 11:10:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f170.google.com Received: from mail-ob0-f170.google.com (HELO mail-ob0-f170.google.com) (209.85.214.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 08 Oct 2015 11:10:44 +0000 Received: by obbzf10 with SMTP id zf10so35271085obb.2 for ; Thu, 08 Oct 2015 04:10:42 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.33.67 with SMTP id p3mr3797580obi.11.1444302642055; Thu, 08 Oct 2015 04:10:42 -0700 (PDT) Received: by 10.76.175.132 with HTTP; Thu, 8 Oct 2015 04:10:42 -0700 (PDT) Date: Thu, 08 Oct 2015 11:10:00 -0000 Message-ID: Subject: PING: [PATCH] PR target/35514: Gcc shoud generate symbol type for undefined symbol From: "H.J. Lu" To: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00821.txt.bz2 On Wed, Jul 8, 2015 at 1:35 PM, H.J. Lu wrote: > On Sun, Jul 5, 2015 at 2:54 PM, H.J. Lu wrote: >> On Sun, Jul 5, 2015 at 11:14 AM, H.J. Lu wrote: >>> Update default_elf_asm_output_external to also output symbol type to >>> help ELF linker to properly issue diagnostic message. We don't output >>> symbol type for reference to external TLS symbol since assembler will >>> generate TLS symbol type based on TLS relocation and Solaris assembler >>> only supports the @tls_obj type directive, not the @tls_object type >>> directive used by GNU assmbler, which doesn't understand the @tls_obj >>> type directive. >>> >>> Tested on Linux/x86-64. OK for trunk? >>> >>> Thanks. >>> >>> >>> H.J. >>> --- >>> gcc/ >>> >>> PR target/35514 >>> * varasm.c (default_elf_asm_output_external): Also output symbol >>> type. >>> >>> gcc/testsuite/ >>> >>> PR target/35514 >>> * lib/target-supports.exp (check_effective_target_elf): New. >>> * gcc.dg/pr35514-1.c: New file. >>> * gcc.dg/pr35514-2.c: Likewise. > > Here is the updated patch to adjust those tests by counting in > the .type directive for ELF targets. There is no regression on > Linux/x86-64. OK for trunk? > PING: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00652.html -- H.J.