public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Julian Brown <julian@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ARM fixed-point support [5.5/6]: argument & return padding for libcalls
Date: Mon, 01 Aug 2011 13:39:00 -0000	[thread overview]
Message-ID: <CAMe9rOoD81nY2tFx536i=Q6z+g=S7PnvvS1SOOkvqpQsKwuFaQ@mail.gmail.com> (raw)
In-Reply-To: <20110526175634.4bcab9b5@rex.config>

On Thu, May 26, 2011 at 9:56 AM, Julian Brown <julian@codesourcery.com> wrote:
> This patch allows padding to be specified per-target for libcalls. This
> hasn't been traditionally important, because libcalls haven't accepted
> quantities which might need padding, but that's no longer true with the
> new(-ish) fixed-point support helper functions.
>
> Tested (alongside other fixed-point support patches) with cross to ARM
> EABI in both big & little-endian mode (the target-specific part is to
> avoid a behaviour change for half-float types on ARM). OK to apply?
>
> Thanks,
>
> Julian
>
> ChangeLog
>
>    gcc/
>    * calls.c (emit_library_call_value_1): Support padding for libcall
>    arguments and return values.
>    * config/arm/arm.c (arm_pad_arg_upward): Pad half-float values
>    downwards in big-endian mode.

This breaks bootstrap on Linux/x86:

http://gcc.gnu.org/ml/gcc-regression/2011-08/msg00007.html

../../src-trunk/gcc/calls.c: In function 'rtx_def*
emit_library_call_value_1(int, rtx, rtx, libcall_type, machine_mode,
int, __va_list_tag*)':
../../src-trunk/gcc/calls.c:3832:11: error: unused variable 'size'
[-Werror=unused-variable]
cc1plus: all warnings being treated as errors

make[6]: *** [calls.o] Error 1

-- 
H.J.

  parent reply	other threads:[~2011-08-01 13:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 17:51 Julian Brown
2011-06-30 13:51 ` Richard Earnshaw
2011-08-01 13:39 ` H.J. Lu [this message]
2011-08-01 13:52   ` H.J. Lu
2011-08-01 13:55     ` H.J. Lu
2011-08-01 14:24       ` Julian Brown
2011-08-07 18:50 ` Richard Sandiford
2011-08-18 21:37   ` Andrew Pinski
2011-08-24 18:09   ` Julian Brown
2011-08-25  7:35     ` Julian Brown
2011-08-25 18:46       ` RFA: PR 50061/50113: BLOCK_REG_PADDING " Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOoD81nY2tFx536i=Q6z+g=S7PnvvS1SOOkvqpQsKwuFaQ@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=julian@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).