From: "H.J. Lu" <hjl.tools@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant
Date: Tue, 05 Jul 2011 14:30:00 -0000 [thread overview]
Message-ID: <CAMe9rOoEako44t7Z27JQAjG_eWS0hCWbrhOMyy1fLqmjLZqhbw@mail.gmail.com> (raw)
Ping.
On Sat, Jun 11, 2011 at 8:58 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> convert_memory_address_addr_space has a special PLUS/MULT case for
> POINTERS_EXTEND_UNSIGNED < 0. It turns out that it is also needed
> for all Pmode != ptr_mode cases. OK for trunk?
>
> Thanks.
>
>
> H.J.
> ---
> 2011-06-11 H.J. Lu <hongjiu.lu@intel.com>
>
> PR middle-end/47727
> * explow.c (convert_memory_address_addr_space): Permute the
> conversion and addition if one operand is a constant.
>
> diff --git a/gcc/explow.c b/gcc/explow.c
> index 7387dad..b343bf8 100644
> --- a/gcc/explow.c
> +++ b/gcc/explow.c
> @@ -383,18 +383,13 @@ convert_memory_address_addr_space (enum machine_mode to_mode ATTRIBUTE_UNUSED,
>
> case PLUS:
> case MULT:
> - /* For addition we can safely permute the conversion and addition
> - operation if one operand is a constant and converting the constant
> - does not change it or if one operand is a constant and we are
> - using a ptr_extend instruction (POINTERS_EXTEND_UNSIGNED < 0).
> - We can always safely permute them if we are making the address
> - narrower. */
> + /* For addition we safely permute the conversion and addition
> + operation if one operand is a constant since we can't generate
> + new instructions. We can always safely permute them if we are
> + making the address narrower. */
> if (GET_MODE_SIZE (to_mode) < GET_MODE_SIZE (from_mode)
> || (GET_CODE (x) == PLUS
> - && CONST_INT_P (XEXP (x, 1))
> - && (XEXP (x, 1) == convert_memory_address_addr_space
> - (to_mode, XEXP (x, 1), as)
> - || POINTERS_EXTEND_UNSIGNED < 0)))
> + && CONST_INT_P (XEXP (x, 1))))
> return gen_rtx_fmt_ee (GET_CODE (x), to_mode,
> convert_memory_address_addr_space
> (to_mode, XEXP (x, 0), as),
>
--
H.J.
next reply other threads:[~2011-07-05 14:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 14:30 H.J. Lu [this message]
2011-07-09 21:22 ` H.J. Lu
2011-07-09 21:23 ` Paolo Bonzini
2011-07-09 21:41 ` H.J. Lu
2011-07-10 17:04 ` Paolo Bonzini
2011-07-10 21:16 ` H.J. Lu
2011-07-11 0:48 ` H.J. Lu
2011-07-11 1:14 ` H.J. Lu
2011-07-11 6:49 ` H.J. Lu
2011-07-11 11:09 ` Paolo Bonzini
2011-07-11 15:58 ` H.J. Lu
2011-07-11 16:57 ` H.J. Lu
2011-07-11 17:26 ` H.J. Lu
2011-07-13 16:24 ` Paolo Bonzini
2011-07-13 16:52 ` H.J. Lu
2011-07-13 16:55 ` Paolo Bonzini
2011-07-13 16:58 ` Paolo Bonzini
2011-07-13 18:42 ` H.J. Lu
2011-07-25 10:34 ` Paolo Bonzini
2011-07-27 18:18 ` H.J. Lu
2011-07-27 22:41 ` Paolo Bonzini
2011-07-28 3:11 ` H.J. Lu
2011-07-28 7:59 ` Paolo Bonzini
2014-05-29 4:52 ` Andrew Pinski
2014-05-29 16:13 ` H.J. Lu
2014-05-29 16:23 ` pinskia
2014-05-29 17:09 ` H.J. Lu
2014-05-29 17:20 ` pinskia
2014-05-30 7:18 ` Paolo Bonzini
2011-07-28 10:24 Uros Bizjak
2011-07-28 10:27 ` Paolo Bonzini
2011-07-29 13:29 ` H.J. Lu
2011-07-28 18:23 ` Uros Bizjak
2011-07-29 9:32 ` Paolo Bonzini
2011-07-29 9:37 ` Paolo Bonzini
2011-07-30 0:47 ` H.J. Lu
2011-07-30 16:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoEako44t7Z27JQAjG_eWS0hCWbrhOMyy1fLqmjLZqhbw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).