public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]
Date: Fri, 13 Aug 2021 06:41:25 -0700	[thread overview]
Message-ID: <CAMe9rOoFcOh1xTbo_8+dnFo-rsx-Je5YCk1i_==4wd6zfuMMhQ@mail.gmail.com> (raw)
In-Reply-To: <ab0d9a09-a7bd-e6db-db4d-67dbfc425318@suse.cz>

On Fri, Aug 13, 2021 at 1:10 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 8/12/21 7:35 PM, H.J. Lu wrote:
> > What happens for arch=x86-64-v5?
>
> pr101696.c:5:55: error: bad value (‘x86-64-v5’) for ‘target("arch=")’ attribute
>
>      5 | __attribute__ ((target ("arch=x86-64-v5"))) void foo () {  __builtin_printf ("arch=x86-64-v4\n"); }
>
>        |                                                       ^
>
> pr101696.c:5:55: note: valid arguments to ‘target("arch=")’ attribute are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids alderlake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 btver1 btver2 native; did you mean ‘x86-64-v2’?
>
>
> Which seems to me a reasonable error message.
>

The patch looks good to me.

Thanks.

-- 
H.J.

  reply	other threads:[~2021-08-13 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 14:12 [PATCH] i386: support micro-levels in target{,_clone} " Martin Liška
2021-08-12 14:25 ` [PATCH] i386: support micro-levels in target{, _clone} " H.J. Lu
2021-08-12 14:39   ` [PATCH] i386: support micro-levels in target{,_clone} " Martin Liška
2021-08-12 14:51     ` [PATCH] i386: support micro-levels in target{, _clone} " H.J. Lu
2021-08-12 15:22       ` [PATCH] i386: support micro-levels in target{,_clone} " Martin Liška
2021-08-12 15:26         ` [PATCH] i386: support micro-levels in target{, _clone} " H.J. Lu
2021-08-12 15:31           ` [PATCH] i386: support micro-levels in target{,_clone} " Martin Liška
2021-08-12 17:35             ` [PATCH] i386: support micro-levels in target{, _clone} " H.J. Lu
2021-08-13  8:10               ` [PATCH] i386: support micro-levels in target{,_clone} " Martin Liška
2021-08-13 13:41                 ` H.J. Lu [this message]
2021-09-13 13:28                   ` Martin Liška
2021-09-13 14:36             ` [PATCH] i386: support micro-levels in target{, _clone} " Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOoFcOh1xTbo_8+dnFo-rsx-Je5YCk1i_==4wd6zfuMMhQ@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).