From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by sourceware.org (Postfix) with ESMTPS id 4451B3857C67 for ; Sat, 31 Oct 2020 12:02:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4451B3857C67 Received: by mail-oi1-x241.google.com with SMTP id m143so180397oig.7 for ; Sat, 31 Oct 2020 05:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=oORQ+iCdwwdpF97fvJmfpys/xJmvzsEP2wRwb/ECgSY=; b=QMuta6Bqi3YOZZd5wQMNhGc5wybOnr3LKZS4b8V1JQ/xt2R1RBnPwZ19sz2u/Memh+ F3lYVffpB04hooiAaPJ92xhFPJgvp7p5GXbXes95DQf1Dp4ImHU8gOA+wZcTKh+5CB8N iYKOx14T2pAtzs6tQSdYi8JoUu2PufJeT90pjwCIQ3zWZ2Ssp43/TDD5BTrnE4GuoQCp tQWOECLv8Ku2dl3jF4ZIV1AmUT3wLPoFJVsguSKm/s7m+Hb03x7e4obQpZiViOqS080S 8OhI5AHTW5fBhZd+syW0qNmHB048JBpBW9ZKKsMKJxiPZzIJINLqKAAPF4owaKGJXp6Q r+Cg== X-Gm-Message-State: AOAM5334zi7eDlLdbjsWWYrMdUtY1ivIqKmqnJ2J8mrxjMhNn2HXpU23 i6AcKJO7otAyg6lKpLYh6z9fu+NddevarovVsT4PS1RI X-Google-Smtp-Source: ABdhPJy8WOg9Y5eZXUCG3H2rWMIcueZt9uN/ISEsv+vMOpjhXIbjXcXWow9oRlD2TzkcM1wJluQOsBCjOpSVwqgxDww= X-Received: by 2002:aca:e186:: with SMTP id y128mr4309907oig.25.1604145745393; Sat, 31 Oct 2020 05:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20200207025710.474289-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Sat, 31 Oct 2020 05:01:49 -0700 Message-ID: Subject: PING^3 [PATCH] Use the section flag 'o' for __patchable_function_entries To: GCC Patches , Jeffrey Law , Jakub Jelinek , Richard Biener , Richard Sandiford Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 12:02:32 -0000 On Fri, Oct 23, 2020 at 5:41 AM H.J. Lu wrote: > > On Fri, Oct 2, 2020 at 6:00 AM H.J. Lu wrote: > > > > On Thu, Feb 6, 2020 at 6:57 PM H.J. Lu wrote: > > > > > > This commit in GNU binutils 2.35: > > > > > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=b7d072167715829eed0622616f6ae0182900de3e > > > > > > added the section flag 'o' to .section directive: > > > > > > .section __patchable_function_entries,"awo",@progbits,foo > > > > > > which specifies the symbol name which the section references. Assembler > > > creates a unique __patchable_function_entries section with the section, > > > where foo is defined, as its linked-to section. Linker keeps a section > > > if its linked-to section is kept during garbage collection. > > > > > > This patch checks assembler support for the section flag 'o' and uses > > > it to implement __patchable_function_entries section. Since Solaris may > > > use GNU assembler with Solairs ld. Even if GNU assembler supports the > > > section flag 'o', it doesn't mean that Solairs ld supports it. This > > > feature is disabled for Solairs targets. > > > > > > gcc/ > > > > > > PR middle-end/93195 > > > PR middle-end/93197 > > > * configure.ac (HAVE_GAS_SECTION_LINK_ORDER): New. Define if > > > the assembler supports the section flag 'o' for specifying > > > section with link-order. > > > * dwarf2out.c (output_comdat_type_unit): Pass 0 as flags2 > > > to targetm.asm_out.named_section. > > > * config/sol2.c (solaris_elf_asm_comdat_section): Likewise. > > > * output.h (SECTION2_LINK_ORDER): New. > > > (switch_to_section): Add an unsigned int argument. > > > (default_no_named_section): Likewise. > > > (default_elf_asm_named_section): Likewise. > > > * target.def (asm_out.named_section): Likewise. > > > * targhooks.c (default_print_patchable_function_entry): Pass > > > current_function_decl to get_section and SECTION2_LINK_ORDER > > > to switch_to_section. > > > * varasm.c (default_no_named_section): Add an unsigned int > > > argument. > > > (default_elf_asm_named_section): Add an unsigned int argument, > > > flags2. Use 'o' flag for SECTION2_LINK_ORDER if assembler > > > supports it. > > > (switch_to_section): Add an unsigned int argument and pass it > > > to targetm.asm_out.named_section. > > > (handle_vtv_comdat_section): Pass 0 to > > > targetm.asm_out.named_section. > > > * config.in: Regenerated. > > > * configure: Likewise. > > > * doc/tm.texi: Likewise. > > > > > > gcc/testsuite/ > > > > > > PR middle-end/93195 > > > * g++.dg/pr93195a.C: New test. > > > * g++.dg/pr93195b.C: Likewise. > > > * lib/target-supports.exp > > > (check_effective_target_o_flag_in_section): New proc. > > > > PING > > > > https://gcc.gnu.org/pipermail/gcc-patches/2020-February/539963.html > > PING. > PING. -- H.J.