From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
Cc: "Dr. David Alan Gilbert" <david.gilbert@linaro.org>,
gcc-patches@gcc.gnu.org, rth@redhat.com,
joseph@codesourcery.com, patches@linaro.org
Subject: Re: [Patch 2/4] ARM 64 bit sync atomic operations [V2]
Date: Fri, 30 Sep 2011 18:29:00 -0000 [thread overview]
Message-ID: <CAMe9rOoLm2B3O1UvJbN5X4mHt5kV1a_P0BDoU0fxakXNdbrf0w@mail.gmail.com> (raw)
In-Reply-To: <CACUk7=VDwc8aQvA1dT22BFFGaMy=is4CEOYWq1R_-YYxO=vnTg@mail.gmail.com>
On Fri, Sep 30, 2011 at 9:45 AM, Ramana Radhakrishnan
<ramana.radhakrishnan@linaro.org> wrote:
> On 26 July 2011 10:01, Dr. David Alan Gilbert <david.gilbert@linaro.org> wrote:
>>
>> +
>> +extern unsigned int __write(int fd, const void *buf, unsigned int count);
>
> Why are we using __write instead of write?
>
> A comment elaborating that this file should only be in the static
> libgcc and never in the dynamic libgcc would be useful, given that the
> constructor is only pulled in only if a 64 bit sync primitive is
> referred to.
>
You may want to look a look at:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50583
ARM may have the same problem.
--
H.J.
next prev parent reply other threads:[~2011-09-30 17:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 15:53 [Patch 0/3] ARM 64 bit atomic operations Dr. David Alan Gilbert
2011-07-01 15:55 ` [Patch 1/3] " Dr. David Alan Gilbert
2011-07-12 21:24 ` Ramana Radhakrishnan
2011-07-13 9:18 ` David Gilbert
2011-07-01 15:56 ` [Patch 2/3] " Dr. David Alan Gilbert
2011-07-01 16:03 ` Richard Henderson
2011-07-01 17:08 ` David Gilbert
2011-07-01 19:38 ` Joseph S. Myers
2011-07-04 22:27 ` David Gilbert
2011-07-01 15:57 ` [Patch 3/3] " Dr. David Alan Gilbert
2011-07-12 15:31 ` Ramana Radhakrishnan
2011-07-12 12:55 ` [Patch 0/3] " Ramana Radhakrishnan
2011-07-26 9:14 ` [Patch 0/4] ARM 64 bit sync atomic operations [V2] Dr. David Alan Gilbert
2011-07-26 9:16 ` [Patch 1/4] " Dr. David Alan Gilbert
2011-07-26 9:18 ` [Patch 2/4] " Dr. David Alan Gilbert
2011-07-26 9:23 ` [Patch 3/4] " Dr. David Alan Gilbert
2011-07-26 9:24 ` [Patch 4/4] " Dr. David Alan Gilbert
2011-08-01 15:43 ` Ramana Radhakrishnan
2011-08-17 13:07 ` [Patch 3/4] " Ramana Radhakrishnan
2011-09-30 18:04 ` [Patch 2/4] " Ramana Radhakrishnan
2011-09-30 18:29 ` H.J. Lu [this message]
2011-10-03 13:22 ` David Gilbert
2011-09-30 20:51 ` Joseph S. Myers
2011-10-03 8:35 ` Andrew Haley
2011-10-03 14:04 ` David Gilbert
2011-10-03 15:56 ` Joseph S. Myers
2011-10-03 16:07 ` Jakub Jelinek
2011-09-30 14:25 ` [Patch 1/4] " Ramana Radhakrishnan
2011-10-03 12:53 ` David Gilbert
2011-10-03 15:18 ` David Gilbert
2011-10-06 17:52 ` [Patch 0/5] ARM 64 bit sync atomic operations [V3] Dr. David Alan Gilbert
2011-10-06 17:53 ` [Patch 1/5] " Dr. David Alan Gilbert
2011-10-06 17:54 ` [Patch 2/5] " Dr. David Alan Gilbert
2011-10-06 17:55 ` [Patch 3/5] " Dr. David Alan Gilbert
2011-10-06 18:03 ` [Patch 4/5] " Dr. David Alan Gilbert
2011-10-06 18:03 ` [Patch 5/5] " Dr. David Alan Gilbert
2011-10-12 4:51 ` Ramana Radhakrishnan
2011-10-12 5:06 ` Mike Stump
2011-10-12 0:53 ` [Patch 4/5] " Ramana Radhakrishnan
2011-10-12 2:35 ` [Patch 3/5] " Ramana Radhakrishnan
2011-10-12 0:52 ` [Patch 2/5] " Ramana Radhakrishnan
2011-10-12 1:45 ` Ramana Radhakrishnan
2011-10-12 0:51 ` [Patch 1/5] " Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoLm2B3O1UvJbN5X4mHt5kV1a_P0BDoU0fxakXNdbrf0w@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=david.gilbert@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=patches@linaro.org \
--cc=ramana.radhakrishnan@linaro.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).