From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com
 [IPv6:2607:f8b0:4864:20::430])
 by sourceware.org (Postfix) with ESMTPS id 16C833858D35
 for <gcc-patches@gcc.gnu.org>; Tue,  2 Nov 2021 12:26:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16C833858D35
Received: by mail-pf1-x430.google.com with SMTP id y20so8618549pfi.4
 for <gcc-patches@gcc.gnu.org>; Tue, 02 Nov 2021 05:26:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=itlvspQG4t0e5zCP44VZqT/06DhranCxFO5pSEljVu8=;
 b=NKuaVFba69MNC7AkV+AUC2eOl2ahwZZO0n2vJC7LzNKtD+9kqXt9zq65DvfeynPwfO
 Bca4jySet9ThWNtUunNNd+z+RzfTPAIfuMv016dPrI4TcP0Q5lUbxA4qVBRqRxbT6z1u
 AIfcnCwAfphZzuV035AvH6YqLRVLiflPd7Pub5KK9NNpI9E6hXExnGD3VmSvJDNF+hjf
 xd0yGm4V4u4AJXwnDr6pYmLR62nlYchtk/TS5KDOORPKBxPgoJGMYSe6hCMlVAlPiEWQ
 ngyt+hBXGCNYTzzO3p8E36CwLGYxCkhKYe2y+eNqyGIiqBBRg+N4Pz9Od+iZTscK8A/d
 LsJA==
X-Gm-Message-State: AOAM531M9xC9TtHtY9HO/6djMLovEyRKaP0TBGETLOiHcJ+kUmynIu1a
 I97dtg4aZ41h7Mf6e1ASmu1yOWEGokjfoftEs8U=
X-Google-Smtp-Source: ABdhPJyBCleFV7PXk1ZlCivGqJAVerP7r3NgBVQqqIp2F01RlSRGMQfzvedvpcA6lWZrobKVre6FRPDzXr5NpjQIePc=
X-Received: by 2002:a63:87c1:: with SMTP id i184mr10142940pge.75.1635855997181; 
 Tue, 02 Nov 2021 05:26:37 -0700 (PDT)
MIME-Version: 1.0
References: <20211030205350.35085-1-hjl.tools@gmail.com>
 <CAFiYyc22ciw0+oyOkY5vi8Ki9_QNWQ_Dkg3FhZeBYYcwqJNSzg@mail.gmail.com>
 <CAMe9rOpkNPcf8JbwrOXMdqyCS_Jgn7iD0b8PyyvAOpa9s_jyYg@mail.gmail.com>
 <20211102121138.GE304296@tucnak>
In-Reply-To: <20211102121138.GE304296@tucnak>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 2 Nov 2021 05:26:01 -0700
Message-ID: <CAMe9rOoQXBoo5-J_Q7QP-Q_y852JNn7c9MJj-qHHLoB8xjCjgw@mail.gmail.com>
Subject: Re: [PATCH] libsanitizer: Disable libbacktrace on
 sanitizer_platform_limits_freebsd.cpp
To: Jakub Jelinek <jakub@redhat.com>, Gerald Pfeifer <gerald@pfeifer.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
 GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3023.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2021 12:26:41 -0000

On Tue, Nov 2, 2021 at 5:11 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Tue, Nov 02, 2021 at 05:02:12AM -0700, H.J. Lu wrote:
> > > On Sat, Oct 30, 2021 at 10:54 PM H.J. Lu via Gcc-patches
> > > <gcc-patches@gcc.gnu.org> wrote:
> > > >
> > > > sanitizer_platform_limits_freebsd.cpp must include <md5.h> from the OS,
> > > > not include/md5.h in GCC source tree which is included by libbacktrace
> > > > support.  Disable libbacktrace on sanitizer_platform_limits_freebsd.cpp
> > > > to avoid include/md5.h to restore bootstrap on FreeBSD.
> > >
> > > Err, but that will just get complaints about disabled libbacktrace backtracking
> > > (from within the sanitizer?)?
> >
> > It disables libbacktrace backtracking only on one file,
> > sanitizer_platform_limits_freebsd.cpp,
> > which contains only data on FreeBSD.  I highly doubt that libbacktrace
> > backtracking is
> > used in it.
>
> include/md5.h is a header we have control over, can't we just add to it
> something like:
> #ifdef USE_SYSTEM_MD5
> #include_next <md5.h>
> #else
> Current header content
> #endif
> and arrange for that macro to be -DUSE_SYSTEM_MD5 when building that
> libsanitizer source file?
>

Gerald, can you try this suggestion?  You can add "#define USE_SYSTEM_MD5"
in sanitizer_platform_limits_freebsd.cpp for testing.


-- 
H.J.