From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124065 invoked by alias); 22 Mar 2018 11:16:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124056 invoked by uid 89); 22 Mar 2018 11:16:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ot0-f172.google.com Received: from mail-ot0-f172.google.com (HELO mail-ot0-f172.google.com) (74.125.82.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 11:16:00 +0000 Received: by mail-ot0-f172.google.com with SMTP id v23-v6so9011882oth.9 for ; Thu, 22 Mar 2018 04:16:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DvVStWEcXmhubxKdTianAmmi9Q/rhoGxNMJJghmvan8=; b=uATpgp3EGMJyUjwgmGFjGiN/WhS9I7z/5yL+ErO5HfrLyXkLdqLLr1MwV3tWJT6j6I HjMOT+RJ/R+RJla5n/9w81dldWLecZTpvoPJA8zPt3+2KmTxxRb/BOri75b/JfTFgUt5 SpRmIueDiK6vGnJvhiaNb7roEFeQnDakV7SR7TLN3J1eeo5b6kIpJ3VQr7o7lIe4zBtl 8bUT0g4mpH9j6pqUlN+KKADt/Dlukw+ZX7Ktx/lL558REq3UYYc9gpVbrHJgMfufI21I +jopJb9BLSGGXue7J0cj89iRbWeW/SywToQHR4LrSXBEMlsrwEorz4b5qu6a/P4SokQg 80+Q== X-Gm-Message-State: AElRT7Hctovivyz8WZz6Ug0RIyanQGYb09Pj6xaK0gd4BCXvgEnfdSR6 vwbq7Ds1Fi0SEgmUjjCg1/WXgzAEtY801XrT1fg= X-Google-Smtp-Source: AIpwx48f4SqCuB2Be7rW7KTBxkxjqNlqXKKyA+KoL6l5r05OmTE4tEL0ybyfDZlFQmlEAtPXsQDfG1QlZUxIpHDvQS4= X-Received: by 2002:a9d:2c09:: with SMTP id f9-v6mr7712987otb.123.1521717359057; Thu, 22 Mar 2018 04:15:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.10.20 with HTTP; Thu, 22 Mar 2018 04:15:58 -0700 (PDT) In-Reply-To: References: From: "H.J. Lu" Date: Thu, 22 Mar 2018 11:56:00 -0000 Message-ID: Subject: Re: [PATCH] PR 85025: libgcc/config/i386/shadow-stack-unwind.h is wrong To: "Tsimbalist, Igor V" Cc: "gcc-patches@gcc.gnu.org" , Uros Bizjak Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg01169.txt.bz2 On Thu, Mar 22, 2018 at 4:11 AM, Tsimbalist, Igor V wrote: > The incspp instruction from CET accepts only the value in the range of 0-255. > The patch fixes the typo in the loop to handle this. > > I'm checking in the fix as obvious. > > Thanks, > Igor > > PR target/85025 > * config/i386/shadow-stack-unwind.h: Fix a typo, tmp => 255. Please add "(_Unwind_Frames_Extra)". Thanks. > Index: libgcc/config/i386/shadow-stack-unwind.h > =================================================================== > --- libgcc/config/i386/shadow-stack-unwind.h (revision 258760) > +++ libgcc/config/i386/shadow-stack-unwind.h (working copy) > @@ -42,7 +42,7 @@ > _Unwind_Word tmp = (x); \ > while (tmp > 255) \ > { \ > - _inc_ssp (tmp); \ > + _inc_ssp (255); \ > tmp -= 255; \ > } \ > _inc_ssp (tmp); \ > > Igor > > -- H.J.