From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id B82AF3858D1E for ; Tue, 29 Nov 2022 19:12:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B82AF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32e.google.com with SMTP id w26-20020a056830061a00b0066c320f5b49so9760637oti.5 for ; Tue, 29 Nov 2022 11:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EHklWE0bEt6pgcvWzrxC/1nhdiF6m32JDoNLXTFygf4=; b=LskudA+eH7SonP224SzBt22RGOVb4nSsiHTJGFgO7GjMwRLSOZ2YFW0r4CKs+yV5iz xnMBsAzhDlsgN8U9XwQlhF0DbzgsKGfgMrVGGylfGA1hx4gqX4VUaCud24Bwln3Vfzr0 OCYotennB99EgxYXG1GAQ2ozQR6KTQTMrCIf/7kxIHTsjJkrRzrci6w1kk4Y88pdFHSx mokmBVDDMQiEd0+BAehJ3t9LAeLKhXujvQ35zifAHWEpO6GvycskwMSlMTaehHZY/cVS SOuNe/wlsKP9jMGhyekHpgqatl5HsiO73UtvUX4wOI2UxpmDHiUopdPnp3TJYO2H64As KRow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EHklWE0bEt6pgcvWzrxC/1nhdiF6m32JDoNLXTFygf4=; b=IwsPjswoSUw/nci1DZ/IaN/wowX7uZVEzxhwhK52kkYdIGlDQbh+fXh7ylZu7DUXHF pyf6hvI/okabU6PYDWBYh1xvnLMlO4lXsKM9GjTZ0L3HifXDcOA8b2L8yjUnWoYTUI4m X1YW6TXVRchLrNh/Cuiy3UoLgjHPieIKCM/DZsy8pXJATkI1bk2hBb6hRPPdVe85tsVY 4HB9iBjqouRDYgZAjizEb0jtk9csDxXboklXQCdn1xuMn1J/ZrkFro2JSebY+ALvuXsR MdyKr5eZVEYLTlA9BV6EflNI8Gn0yzgVC7RWhWweRiLnPbhpUjc58DHdSfPZWXKM9mss IGKg== X-Gm-Message-State: ANoB5pn7MTa0L4ChJ933MADQ3Nwy1TXN3gPh3c5h9KbSeVMfSkd9cpMq 3GCO1R4Fq9MrUXCvKdXqk1pN12taJJlCcXv8Mf8= X-Google-Smtp-Source: AA0mqf7CpL6mz1UX95ECZ8sA1yMk8eXvMISOMtPHegQtlidhbf0OOjW2kkWZwBMJs1AwEWcg9+GkglCKI39rsaOx76Y= X-Received: by 2002:a05:6830:1e24:b0:66d:3169:9092 with SMTP id t4-20020a0568301e2400b0066d31699092mr28603114otr.52.1669749128973; Tue, 29 Nov 2022 11:12:08 -0800 (PST) MIME-Version: 1.0 References: <20221128130539.2124727-1-hongtao.liu@intel.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 29 Nov 2022 11:11:32 -0800 Message-ID: Subject: Re: [PATCH] [x86] Fix unrecognizable insn due to illegal immediate_operand (const_int 255) of QImode. To: Hongtao Liu Cc: liuhongt , gcc-patches@gcc.gnu.org, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 28, 2022 at 11:04 PM Hongtao Liu wrote: > > On Mon, Nov 28, 2022 at 9:06 PM liuhongt wrote: > > > > For __builtin_ia32_vec_set_v16qi (a, -1, 2) with > > !flag_signed_char. it's transformed to > > __builtin_ia32_vec_set_v16qi (_4, 255, 2) in the gimple, > > and expanded to (const_int 255) in the rtl. But for immediate_operand, > > it expects (const_int 255) to be signed extended to > > (const_int -1). The mismatch caused an unrecognizable insn error. > > > > expand_expr_real_1 generates (const_int 255) without considering the target mode. > > I guess it's on purpose, so I'll leave that alone and only change the expander > > in the backend. After applying convert_modes to (const_int 255), > > it's transformed to (const_int -1) which fix the issue. > > > > Bootstrapped and regtested x86_64-pc-linux-gnu{-m32,}. > > Ok for trunk(and backport to GCC-10/11/12 release branches)? > Drop this patch since it's not a complete solution, there're also > other QI builtins which is not handled. I checked the x86 backend. __builtin_ia32_vec_set_v16qi is the only intrinsic with this issue. > > > > gcc/ChangeLog: > > > > PR target/107863 > > * config/i386/i386-expand.cc (ix86_expand_vec_set_builtin): > > Convert op1 to target mode whenever mode mismatch. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/i386/pr107863.c: New test. > > --- > > gcc/config/i386/i386-expand.cc | 2 +- > > gcc/testsuite/gcc.target/i386/pr107863.c | 8 ++++++++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > create mode 100644 gcc/testsuite/gcc.target/i386/pr107863.c > > > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc > > index 0373c3614a4..c639ee3a9f7 100644 > > --- a/gcc/config/i386/i386-expand.cc > > +++ b/gcc/config/i386/i386-expand.cc > > @@ -12475,7 +12475,7 @@ ix86_expand_vec_set_builtin (tree exp) > > op1 = expand_expr (arg1, NULL_RTX, mode1, EXPAND_NORMAL); > > elt = get_element_number (TREE_TYPE (arg0), arg2); > > > > - if (GET_MODE (op1) != mode1 && GET_MODE (op1) != VOIDmode) > > + if (GET_MODE (op1) != mode1) > > op1 = convert_modes (mode1, GET_MODE (op1), op1, true); > > > > op0 = force_reg (tmode, op0); > > diff --git a/gcc/testsuite/gcc.target/i386/pr107863.c b/gcc/testsuite/gcc.target/i386/pr107863.c > > new file mode 100644 > > index 00000000000..99fd85d9765 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/i386/pr107863.c > > @@ -0,0 +1,8 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-mavx2 -O" } */ > > + > > +typedef char v16qi __attribute__((vector_size(16))); > > + > > +v16qi foo(v16qi a){ > > + return __builtin_ia32_vec_set_v16qi (a, -1, 2); > > +} > > -- > > 2.27.0 > > > > > -- > BR, > Hongtao -- H.J.