On Mon, Aug 17, 2015 at 10:08 AM, Alexander Monakov <amonakov@ispras.ru> wrote:
>> >> Perhaps add a comment that GOT slots are 64-bit on x32?
>> >>
>> >
>> > Good idea.  I will update my patch.
>> >
>>
>> How about this?
>>
>>
>> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>> index bf8a21d..216dee6 100644
>> --- a/gcc/config/i386/i386.c
>> +++ b/gcc/config/i386/i386.c
>> @@ -25690,6 +25690,10 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx callarg1,
>>   fnaddr);
>>   }
>>        fnaddr = gen_const_mem (Pmode, fnaddr);
>> +      /* Pmode may not be the same as word_mode for x32, which
>
> I think 'Pmode is not the same as word_mode on x32' is more appropriate here.

"-maddress-mode=long -mx32" makes Pmode == word_mode.

>> + doesn't support indirect branch va 32-bit memory slot.
>
> Typo: s/va/via.
>

Fixed.

Here is the updated patch.

Thanks.

-- 
H.J.