From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB
Date: Tue, 14 Dec 2021 16:29:25 -0800 [thread overview]
Message-ID: <CAMe9rOoc-qz8oW35C0SUjKXRxeFr3BuGF1nPyqzCNN7vQ6oCog@mail.gmail.com> (raw)
In-Reply-To: <e7ae8e4c-cd2e-d837-c15c-def8089e8691@gmail.com>
On Tue, Dec 14, 2021 at 3:30 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 11/22/2021 7:29 PM, H.J. Lu wrote:
> > On Mon, Nov 22, 2021 at 4:29 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> >>
> >>
> >> On 11/13/2021 9:33 AM, H.J. Lu via Gcc-patches wrote:
> >>> Sync with binutils for building binutils with LTO:
> >>>
> >>> From 50ad1254d5030d0804cbf89c758359ae202e8d55 Mon Sep 17 00:00:00 2001
> >>> From: "H.J. Lu" <hjl.tools@gmail.com>
> >>> Date: Sat, 9 Jan 2021 06:43:11 -0800
> >>> Subject: [PATCH] GCC: Pass --plugin to AR and RANLIB
> >>>
> >>> Detect GCC LTO plugin. Pass --plugin to AR and RANLIB to support LTO
> >>> build.
> >>>
> >>> * Makefile.tpl (AR): Add @AR_PLUGIN_OPTION@
> >>> (RANLIB): Add @RANLIB_PLUGIN_OPTION@.
> >>> * configure.ac: Include config/gcc-plugin.m4.
> >>> AC_SUBST AR_PLUGIN_OPTION and RANLIB_PLUGIN_OPTION.
> >>> * libtool.m4 (_LT_CMD_OLD_ARCHIVE): Pass --plugin to AR and
> >>> RANLIB if possible.
> >>> * Makefile.in: Regenerated.
> >>> * configure: Likewise.
> >>>
> >>> config/
> >>>
> >>> * gcc-plugin.m4 (GCC_PLUGIN_OPTION): New.
> >>>
> >>> libiberty/
> >>>
> >>> * Makefile.in (AR): Add @AR_PLUGIN_OPTION@
> >>> (RANLIB): Add @RANLIB_PLUGIN_OPTION@.
> >>> (configure_deps): Depend on ../config/gcc-plugin.m4.
> >>> * configure.ac: AC_SUBST AR_PLUGIN_OPTION and
> >>> RANLIB_PLUGIN_OPTION.
> >>> * aclocal.m4: Regenerated.
> >>> * configure: Likewise.
> >>>
> >>> zlib/
> >>>
> >>> * configure: Regenerated.
> >> I thought the plugins were automatically loaded if they're in the right
> >> place in the filesystem. Wouldn't that make this patch unnecessary? Am
> >> I missing something?
> >>
> > It only works for system GCC and binutils. It doesn't work for non-system
> > GCC nor binutils since either GCC plugin isn't installed in the binutils plugin
> > search patch.
> Ah. So this is primarily useful if GCC was installed into a path
> different than the system binutils expects to find the plugin? Does it
Yes.
> work properly in cross environments or at least do no harm in those
> kinds of builds?
>
I believe so.
--
H.J.
next prev parent reply other threads:[~2021-12-15 0:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 16:33 [PATCH 0/2] Sync with binutils for building binutils with LTO: H.J. Lu
2021-11-13 16:33 ` [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB H.J. Lu
2021-11-23 0:29 ` Jeff Law
2021-11-23 2:29 ` H.J. Lu
2021-12-14 23:30 ` Jeff Law
2021-12-15 0:29 ` H.J. Lu [this message]
2021-12-15 17:33 ` Jeff Law
2021-12-16 3:37 ` Sandra Loosemore
2021-12-16 4:28 ` H.J. Lu
2021-12-16 4:38 ` H.J. Lu
2021-12-16 5:34 ` Sandra Loosemore
2021-11-13 16:33 ` [PATCH 2/2] Sync with binutils: Support the PGO build for binutils+gdb H.J. Lu
2021-12-15 20:25 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoc-qz8oW35C0SUjKXRxeFr3BuGF1nPyqzCNN7vQ6oCog@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).