From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 30FF438618E2 for ; Fri, 8 Jan 2021 16:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 30FF438618E2 Received: by mail-oi1-x236.google.com with SMTP id d189so11926342oig.11 for ; Fri, 08 Jan 2021 08:46:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7iz3bSKTGldUubK5t8M2jzGKS6PEp+z/GD8GTe2B+Uo=; b=khQAxdRe+3W3YvFf6t/7+p8s8KV1V8Hh7nC5KkG1poQ+S5O+0IIQ+t7RQTByL92+7z td3r1NbdDKa73PlMHegVCL1r+lpMU64vpZycb8VeF+FWNFJzRbSy6S5Uauz99WWosmNb nTwNtwrX0MldbSN5a9gI0Xtht6+chDUCvFoJBTE91Laoev5lN9s66yQvKV33GwU6tttS qyTQDmuhbkiLlc/GydmMe9LJnmo0741VzjdvfKGQjip34HTLwg3DJPfA3KHNj1k/fpot 9KfDFRpa0vG/7nVnOD18KE5nOh/NUCDB1oW+l9saacwMfXsp9agCvMQesKlSMyppXlZR 3c7w== X-Gm-Message-State: AOAM531iZMI7Aat/h6aUCR02j0k5B2U48w96ce0VPhhNRoRhk7aMctp8 ujTDM+Fxfh029LED3lGldojUB6C+1RRUu2yIOg4= X-Google-Smtp-Source: ABdhPJz0bnaRryKKJm3O5EULiamxTgLwmIeVX53IS3QwLShNbJO4KrQ6MiLpGdldhTWgDoAYBy9MPmT2UuPxREZ60wA= X-Received: by 2002:aca:f5d3:: with SMTP id t202mr2896274oih.25.1610124364569; Fri, 08 Jan 2021 08:46:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Fri, 8 Jan 2021 08:45:28 -0800 Message-ID: Subject: [PATCH] x86-64: Require lp64 for PR target/98482 tests To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000cb7e4705b8664a14" X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 16:46:06 -0000 --000000000000cb7e4705b8664a14 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 8, 2021 at 6:43 AM H.J. Lu wrote: > > On Fri, Jan 8, 2021 at 6:31 AM Uros Bizjak wrote: > > > > On Fri, Jan 8, 2021 at 2:28 PM H.J. Lu wrote: > > > > > > On Fri, Jan 8, 2021 at 4:50 AM H.J. Lu wrote: > > > > > > > > On Fri, Jan 8, 2021 at 1:24 AM Uros Bizjak wrote: > > > > > > > > > > > Since R10 is preserved when calling mcount, R10 can be used a scratch > > > > > > register to call mcount in large model. > > > > > > > > > > Please mention that R10 can be used as a static chain registers and is > > > > > preserved when calling mcount for nested functions. > > > > > > > > > > > gcc/ > > > > > > > > > > > > PR target/98482 > > > > > > * config/i386/i386.c (x86_function_profiler): Use R10 to call > > > > > > mcount in large model. Sorry for large model with PIC. > > > > > > > > > > > > gcc/testsuite/ > > > > > > > > > > > > PR target/98482 > > > > > > * gcc.target/i386/pr98482-1.c: New test. > > > > > > * gcc.target/i386/pr98482-1.c: Likewise. > > > > > > > > > > OK with comment fixes. > > > > > > > > > > Thanks, > > > > > Uros. > > > > > > > > > > + case CM_LARGE: > > > > > + /* NB: R10 can be used as a scratch register here since > > > > > + R10 is preserved when calling mcount. */ > > > > > > > > > > Also mention that R10 can be used as a static chain register and is > > > > > preserved when calling mcount for nested functions. > > > > > > > > > > + fprintf (file, "1:\tmovabsq\t$%s, %%r10\n\tcall\t*%%r10\n", > > > > > + mcount_name); > > > > > + break; > > > > > > > > This is the patch I am checking in. > > > > > > > > > > For NO_PROFILE_COUNTERS targets, R11 is a scratch register. We can use > > > R10 and R11 to call mcount in large model with PIC. > > > > > > OK for master? > > > > + fprintf (file, "\tmovabsq\t$%s@PLTOFF, %%r11\n", > > + mcount_name); > > > > Please put mcount_name in the same line (and please do the same for > > case CM_MEDIUM_PIC). > > Fixed. > > > OK with the above fixes. > > > > Thanks, > > Uros. > > Here is the updated patch I am checking in. > I am checking in this patch since -mcmodel=large is isn't supported for x32. -- H.J. --000000000000cb7e4705b8664a14 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-x86-64-Require-lp64-for-PR-target-98482-tests.patch" Content-Disposition: attachment; filename="0001-x86-64-Require-lp64-for-PR-target-98482-tests.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjoieufn0 RnJvbSBlNzc5NzI2NGIyYjhiZWU2YjlhNDI5Mzg1ZDkxYWYwODU4ZWUwYzhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgOCBKYW4gMjAyMSAwODo0MTozOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHg4Ni02NDog UmVxdWlyZSBscDY0IGZvciBQUiB0YXJnZXQvOTg0ODIgdGVzdHMKClJlcXVpcmUgbHA2NCBmb3Ig UFIgdGFyZ2V0Lzk4NDgyIHRlc3RzIHNpbmNlIC1tY21vZGVsPWxhcmdlIGlzIGlzbid0CnN1cHBv cnRlZCBmb3IgeDMyLgoKCVBSIHRhcmdldC85ODQ4MgoJKiBnY2MudGFyZ2V0L2kzODYvcHI5ODQ4 Mi0xLmM6IFJlcXVpcmUgbHA2NC4KCSogZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODItMS5jOiBMaWtl d2lzZS4KLS0tCiBnY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk4NDgyLTEuYyB8IDIg Ky0KIGdjYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODItMi5jIHwgMiArLQogMiBm aWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHI5ODQ4Mi0xLmMgYi9nY2MvdGVzdHN1 aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk4NDgyLTEuYwppbmRleCA3MmQ1Y2NiMjY5Yy4uOTEyY2Jl MDkxOTEgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODIt MS5jCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODItMS5jCkBAIC0x LDQgKzEsNCBAQAotLyogeyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IHsgKi0qLWxpbnV4KiAmJiB7 ICEgaWEzMiB9IH0gfSB9ICovCisvKiB7IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgeyAqLSotbGlu dXgqICYmIGxwNjQgfSB9IH0gKi8KIC8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IG1m ZW50cnkgfSAqLwogLyogeyBkZy1vcHRpb25zICItZnByb2ZpbGUgLW1mZW50cnkgLU8yIC1tY21v ZGVsPWxhcmdlIiB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXIgIm1vdmFic3Fc dFxcXCRfX2ZlbnRyeV9fLCAlcjEwXG5cdGNhbGxcdFxcKiVyMTAiIH0gfSAqLwpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHI5ODQ4Mi0yLmMgYi9nY2MvdGVzdHN1 aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk4NDgyLTIuYwppbmRleCAwZWUxNDJkYjEyYy4uMDNjNjJh NGI2N2IgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODIt Mi5jCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTg0ODItMi5jCkBAIC0x LDQgKzEsNCBAQAotLyogeyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IHsgKi0qLWxpbnV4KiAmJiB7 ICEgaWEzMiB9IH0gfSB9ICovCisvKiB7IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgeyAqLSotbGlu dXgqICYmIGxwNjQgfSB9IH0gKi8KIC8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IG1m ZW50cnkgfSAqLwogLyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQgZnBpYyB9ICovCiAv KiB7IGRnLW9wdGlvbnMgIi1mcGljIC1mcHJvZmlsZSAtbWZlbnRyeSAtTzIgLW1jbW9kZWw9bGFy Z2UiIH0gKi8KLS0gCjIuMjkuMgoK --000000000000cb7e4705b8664a14--