From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by sourceware.org (Postfix) with ESMTPS id D65533858D34 for ; Sun, 19 Jul 2020 11:10:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D65533858D34 Received: by mail-io1-xd43.google.com with SMTP id v8so14753786iox.2 for ; Sun, 19 Jul 2020 04:10:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qy1YulO1O94E0kt5RMlYPVDJVaSoeip5B4DNqb7wwfM=; b=BCwfpiZnyXQWCZbAT7mA+ev0vxy/jdPdJLwZfziXkliXS7bWv8Ddv/urAVDuU+b28j G7Hh2hAS8snKQ4lXo8+4WYOIr1CU86YjdTdWslUxI4asvIVw8MrTQwZyoF/8NIApzn37 qffoWfUU5REbMEwH8MBDeiNMOXsz5rJH2oG9IV+Npy8qPwRMn4bNAlmrVQoLJWN6qAI7 6OgwLa8uf5r76lChmlRuY9WAxxMqXcfcNJREwahuX1sh7q68wccr0bS0D2aWF6TdIfLT W50XKhg+uglrcubwSO43Uso9ENsI9/oTDY3ky9IrBUXZQNTFH3GK116aDG9SCjfpgvrG nKcg== X-Gm-Message-State: AOAM5304WCG9oPXk6HW7CceUfreiUH+FbJvO0Hf67TEA8KObQ3DGogGI tAjkwcMhVC4OcTQRiytZswZKptxzPRqZ0D3VV88= X-Google-Smtp-Source: ABdhPJwN2CpVZLoiZmgLiSL/vB7CfNdrp3XmmcbEhs2DfZjigYRIG60Hys/VBuySAZn8XPm70MvEdWkAczM6Z9oF1Z4= X-Received: by 2002:a6b:e007:: with SMTP id z7mr17430742iog.91.1595157017354; Sun, 19 Jul 2020 04:10:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Sun, 19 Jul 2020 04:09:41 -0700 Message-ID: Subject: Re: [PATCH] x86: Add __cpuidex and include guard to To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000618b4605aac96fdd" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2020 11:10:19 -0000 --000000000000618b4605aac96fdd Content-Type: text/plain; charset="UTF-8" On Sun, Jul 19, 2020 at 12:19 AM Uros Bizjak wrote: > > > Add > > > > void __cpuidex (int __cpuid_info[4], int __leaf, int __subleaf); > > > > as well as include guard to . > > > > gcc/ > > > > PR target/95973 > > PR target/96238 > > * config/i386/cpuid.h: Add include guard. > > (__cpuidex): New. > > > > gcc/testsuite/ > > > > PR target/95973 > > PR target/96238 > > * gcc.target/i386/pr95973.c: New test. > > OK. > > + if (cpuid_info[0] != eax > + || cpuid_info[1] != ebx > + || cpuid_info[2] != ecx > + || cpuid_info[3] != edx) > + abort (); > > You can use __builtin_abort here to avoid inclusion of stdlib.h. Fixed. This is the patch I am checking in. Thanks. -- H.J. --000000000000618b4605aac96fdd Content-Type: text/x-patch; charset="US-ASCII"; name="0001-x86-Add-__cpuidex-and-include-guard-to-cpuid.h.patch" Content-Disposition: attachment; filename="0001-x86-Add-__cpuidex-and-include-guard-to-cpuid.h.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcsz9gir0 RnJvbSA1NjYzMzM1MGM2NDM4YTNhNjRiZDg0YWY4MDliNDY2M2VhNjI3MjA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFNhdCwgMTggSnVsIDIwMjAgMDQ6NDM6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSB4ODY6IEFk ZCBfX2NwdWlkZXggYW5kIGluY2x1ZGUgZ3VhcmQgdG8gPGNwdWlkLmg+CgpBZGQKCnZvaWQgX19j cHVpZGV4IChpbnQgX19jcHVpZF9pbmZvWzRdLCBpbnQgX19sZWFmLCBpbnQgX19zdWJsZWFmKTsK CmFzIHdlbGwgYXMgaW5jbHVkZSBndWFyZCB0byA8Y3B1aWQuaD4uCgpnY2MvCgoJUFIgdGFyZ2V0 Lzk1OTczCglQUiB0YXJnZXQvOTYyMzgKCSogY29uZmlnL2kzODYvY3B1aWQuaDogQWRkIGluY2x1 ZGUgZ3VhcmQuCgkoX19jcHVpZGV4KTogTmV3LgoKZ2NjL3Rlc3RzdWl0ZS8KCglQUiB0YXJnZXQv OTU5NzMKCVBSIHRhcmdldC85NjIzOAoJKiBnY2MudGFyZ2V0L2kzODYvcHI5NTk3My5jOiBOZXcg dGVzdC4KLS0tCiBnY2MvY29uZmlnL2kzODYvY3B1aWQuaCAgICAgICAgICAgICAgICAgfCAxMiAr KysrKysrKysrKysKIGdjYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3ByOTU5NzMuYyB8IDI1 ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9u cygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9pMzg2L3By OTU5NzMuYwoKZGlmZiAtLWdpdCBhL2djYy9jb25maWcvaTM4Ni9jcHVpZC5oIGIvZ2NjL2NvbmZp Zy9pMzg2L2NwdWlkLmgKaW5kZXggOTRhZjQ5MTBkM2MuLmJjYTYxZDYyMGRiIDEwMDY0NAotLS0g YS9nY2MvY29uZmlnL2kzODYvY3B1aWQuaAorKysgYi9nY2MvY29uZmlnL2kzODYvY3B1aWQuaApA QCAtMjEsNiArMjEsOSBAQAogICogPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgogICov CiAKKyNpZm5kZWYgX0NQVUlEX0hfSU5DTFVERUQKKyNkZWZpbmUgX0NQVUlEX0hfSU5DTFVERUQK KwogLyogJWVheCAqLwogI2RlZmluZSBiaXRfQVZYNTEyQkYxNgkoMSA8PCA1KQogCkBAIC0zMTMs MyArMzE2LDEyIEBAIF9fZ2V0X2NwdWlkX2NvdW50ICh1bnNpZ25lZCBpbnQgX19sZWFmLCB1bnNp Z25lZCBpbnQgX19zdWJsZWFmLAogICBfX2NwdWlkX2NvdW50IChfX2xlYWYsIF9fc3VibGVhZiwg Kl9fZWF4LCAqX19lYngsICpfX2VjeCwgKl9fZWR4KTsKICAgcmV0dXJuIDE7CiB9CisKK3N0YXRp YyBfX2lubGluZSB2b2lkCitfX2NwdWlkZXggKGludCBfX2NwdWlkX2luZm9bNF0sIGludCBfX2xl YWYsIGludCBfX3N1YmxlYWYpCit7CisgIF9fY3B1aWRfY291bnQgKF9fbGVhZiwgX19zdWJsZWFm LCBfX2NwdWlkX2luZm9bMF0sIF9fY3B1aWRfaW5mb1sxXSwKKwkJIF9fY3B1aWRfaW5mb1syXSwg X19jcHVpZF9pbmZvWzNdKTsKK30KKworI2VuZGlmIC8qIF9DUFVJRF9IX0lOQ0xVREVEICovCmRp ZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk1OTczLmMgYi9nY2Mv dGVzdHN1aXRlL2djYy50YXJnZXQvaTM4Ni9wcjk1OTczLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAuLjA4YzdkYmE4ZjQ2Ci0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rl c3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHI5NTk3My5jCkBAIC0wLDAgKzEsMjUgQEAKKy8qIHsg ZGctZG8gcnVuIH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLU8yIC1XYWxsIiB9ICovCisKKyNpbmNs dWRlIDxjcHVpZC5oPgorI2luY2x1ZGUgPGNwdWlkLmg+CisKK2ludAorbWFpbiAoKQoreworICB1 bnNpZ25lZCBpbnQgZWF4LCBlYngsIGVjeCwgZWR4OworICBpbnQgY3B1aWRfaW5mb1s0XTsKKwor ICBpZiAoIV9fZ2V0X2NwdWlkX2NvdW50ICg3LCAwLCAmZWF4LCAmZWJ4LCAmZWN4LCAmZWR4KSkK KyAgICByZXR1cm4gMDsKKworICBfX2NwdWlkZXggKGNwdWlkX2luZm8sIDcsIDApOworCisgIGlm IChjcHVpZF9pbmZvWzBdICE9IGVheAorICAgICAgfHwgY3B1aWRfaW5mb1sxXSAhPSBlYngKKyAg ICAgIHx8IGNwdWlkX2luZm9bMl0gIT0gZWN4CisgICAgICB8fCBjcHVpZF9pbmZvWzNdICE9IGVk eCkKKyAgICBfX2J1aWx0aW5fYWJvcnQgKCk7CisKKyAgcmV0dXJuIDA7Cit9Ci0tIAoyLjI2LjIK Cg== --000000000000618b4605aac96fdd--