From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id E3B773858C55 for ; Sat, 1 Oct 2022 00:08:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3B773858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x730.google.com with SMTP id i3so3799007qkl.3 for ; Fri, 30 Sep 2022 17:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=jKo+rLDqDyMdIwqiwkOzVRqd7FolnYYj4/gXH9WrTOo=; b=dBk6lZ6JqKigGNh9Pf6Nem/rzHKW7tsh45ISSoZXMB371jgHlw+V1ywpIhp4lCvh6w VBXXa7lbt6OBsoUHcBGSXUecvMIUBf7XlzT4PuJ16U/0Fn96lnhntaSeWTFEWKu0tiff 25Ipl9QZXE46ZmM58uplY/Am+EGRMWwU7ypozoHjWGx9LZx9dlXbIiV4Hq5WzdK7K24L T1TjjPGmaHYJfNxczlYDiLWIaagVqSmLzSjd1Hqgrpk0ulU+DDXz0fqlxNOp+R8LNWWp WW1Q2jg4G/Sn8c8e2EVehXXp0JXpG7b47qb9CcjUdBHoeVlmRE2rnmSD1MKgT6ySZ9+H I7Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=jKo+rLDqDyMdIwqiwkOzVRqd7FolnYYj4/gXH9WrTOo=; b=zhBntQNOEeuiMTxvPbphYqmYVPEka2QNimFJropd7SIJJR7cbjl25NbV+bFcro+Ubm jZJF5p987SXudIKrFs9EN+PbTl0iJeY7FHkfBUi4ajgk3GF49qNT0UcHQZCuQzM2KnGx WVqjUp3IP8fTH4b+5NX9FZS6YQeCMLSz+5zTOH0rTt6NnBWIFd8oBc+ffltPwUe7epi6 4euXTP0wCETjx3smDPojztWNzfC6sLwl3/7/BJtpw1hBmFAzY3GgpY2hestTUFNXE8WY kce1sRPFNB+WgwKXdzjpO2TEf/qWy4gzXHJcxfxDmiYtbeoVqfJ6xEM5nfHcSx5m3HkC 8hYg== X-Gm-Message-State: ACrzQf1N0e2HvqlUvvAx8QTQsDXPSlm958BagH+lI241rWyj64qTstL1 tnK8Emv6Bw4IzrQCTLWo6Amx5YICwNpWqDxuUqIoiJq38NQ= X-Google-Smtp-Source: AMsMyM5Wx+DS63xu3lJMTjYGYhm+BppwI+kPLOoDqkDsEKMePMnA87fkSNLtEtFsAplk22x01PoEMbjVfT6t1Y2K6Rg= X-Received: by 2002:a05:620a:16aa:b0:6ce:70b2:598b with SMTP id s10-20020a05620a16aa00b006ce70b2598bmr7877619qkj.670.1664582900234; Fri, 30 Sep 2022 17:08:20 -0700 (PDT) MIME-Version: 1.0 References: <44815a60-2cd4-9408-64a9-d718163bca71@ventanamicro.com> In-Reply-To: <44815a60-2cd4-9408-64a9-d718163bca71@ventanamicro.com> From: "H.J. Lu" Date: Fri, 30 Sep 2022 17:07:44 -0700 Message-ID: Subject: Re: [committed] Minor cleanup/prep in DOM To: Jeff Law Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3018.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 30, 2022 at 4:06 PM Jeff Law wrote: > > > It's a bit weird that free_dom_edge_info leaves a dangling pointer in > e->aux. Not sure what I was thinking. > > > There's two callers. One wipes e->aux immediately after the call, the > other attaches a newly created object immediately after the call. So we > can wipe e->aux within the call and simplify one of the two call sites. > > This is preparatory work for a minor optimization where we want to > detect another class of edge equivalences in DOM (until something better > is available) and either attach them an existing edge_info structure or > create a new one if one doesn't currently exist for a given edge. > > Bootstrapped and regression tested on x86_64. Installing on the trunk. > I got /export/gnu/import/git/sources/gcc/gcc/tree-ssa-dom.cc: In function =E2=80=98void record_edge_info(basic_block)=E2=80=99: /export/gnu/import/git/sources/gcc/gcc/tree-ssa-dom.cc:689:27: error: =E2=80=98dst=E2=80=99 was not declared in this scope; did you mean =E2=80= =98dse=E2=80=99? 689 | if (dst =3D=3D PHI_ARG_DEF (phi, !alternative= )) | ^~~ | dse In file included from /export/gnu/import/git/sources/gcc/gcc/gimple-ssa.h:2= 4, from /export/gnu/import/git/sources/gcc/gcc/ssa.h:27, from /export/gnu/import/git/sources/gcc/gcc/tree-ssa-dom.c= c:28: /export/gnu/import/git/sources/gcc/gcc/tree-ssa-dom.cc:689:47: error: =E2=80=98phi=E2=80=99 was not declared in this scope; did you mean =E2=80= =98gphi=E2=80=99? 689 | if (dst =3D=3D PHI_ARG_DEF (phi, !alternative= )) | ^~~ /export/gnu/import/git/sources/gcc/gcc/tree-ssa-operands.h:82:54: note: in definition of macro =E2=80=98PHI_ARG_DEF=E2=80=99 82 | #define PHI_ARG_DEF(PHI, I) gimple_phi_arg_def ((PHI), (I)) | ^~~ make: *** [Makefile:1146: tree-ssa-dom.o] Error 1 --=20 H.J.