From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>, Paolo Bonzini <bonzini@gnu.org>
Cc: David Edelsohn <dje.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PING: PATCH: PR target/46770: Use .init_array/.fini_array sections
Date: Mon, 22 Aug 2011 15:27:00 -0000 [thread overview]
Message-ID: <CAMe9rOoq52MYN-+y6q3zKRLhwVH1fCibW42RQeOsphjcf3P+ng@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOpJMGLX6AVV1s_35--JnGzpTdEWbSxQVd4_43UfVB80Gg@mail.gmail.com>
On Mon, Aug 22, 2011 at 7:06 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Aug 21, 2011 at 10:37 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Sun, Aug 21, 2011 at 05:09:59PM -0700, H.J. Lu wrote:
>>> I didn't know .init_array section was enabled for AIX. Does this patch
>>> work for you?
>>
>> Some ELF targets (e.g. arm*-linux*) don't use elfos.h. IMHO you should
>> instead add
>> #ifndef __ELF__
>> #error NonELF
>> #endif
>> to gcc_AC_INITFINI_ARRAY test. And/or add another test to it that tests
>> that you can actually use
>> .section .init_array
>> and it will use correct section flags for the section.
>>
>
> I will update the test.
Can I check in this patch to address AIX issue first?
I will submit a patch to test ".section .init_array" later?
Thanks.
--
H.J.
---
2011-08-22 H.J. Lu <hongjiu.lu@intel.com>
* acinclude.m4 (gcc_AC_INITFINI_ARRAY): Error if __ELF__ isn't
defined.
diff --git a/gcc/acinclude.m4 b/gcc/acinclude.m4
index 74c86db..a8ecd2d 100644
--- a/gcc/acinclude.m4
+++ b/gcc/acinclude.m4
@@ -377,6 +377,9 @@ AC_CACHE_CHECK(for .preinit_array/.init_array/.fini_array su
pport,
gcc_cv_initfini_array, [dnl
if test "x${build}" = "x${target}" && test "x${build}" = "x${host}"; then
AC_RUN_IFELSE([AC_LANG_SOURCE([
+#ifndef __ELF__
+#error Not an ELF OS
+#endif
#ifdef __ia64__
/* We turn on .preinit_array/.init_array/.fini_array support for ia64
if it can be used. */
next prev parent reply other threads:[~2011-08-22 14:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 7:39 David Edelsohn
2011-08-22 7:44 ` H.J. Lu
2011-08-22 7:46 ` Jakub Jelinek
2011-08-22 14:23 ` H.J. Lu
2011-08-22 15:27 ` H.J. Lu [this message]
2011-08-22 15:46 ` Paolo Bonzini
2011-08-22 17:37 ` H.J. Lu
2011-08-22 18:33 ` H.J. Lu
2011-08-22 19:12 ` Joseph S. Myers
2011-08-22 19:19 ` H.J. Lu
2011-08-22 19:38 ` Joseph S. Myers
2011-08-22 20:50 ` H.J. Lu
2011-08-22 7:46 ` David Edelsohn
2011-08-22 16:26 ` H.J. Lu
-- strict thread matches above, loose matches on Subject: below --
2011-03-21 18:40 H.J. Lu
2011-03-31 15:15 ` H.J. Lu
2011-04-14 19:11 ` H.J. Lu
2011-04-26 13:08 ` H.J. Lu
2011-05-18 17:30 ` H.J. Lu
2011-06-01 23:30 ` Carrot Wei
2011-06-03 4:31 ` H.J. Lu
2011-06-03 12:31 ` Richard Guenther
2011-06-03 12:52 ` H.J. Lu
2011-06-19 20:02 ` H.J. Lu
2011-06-19 21:31 ` Uros Bizjak
2011-07-22 12:31 ` H.J. Lu
2011-07-22 12:36 ` Rainer Orth
2011-07-22 12:36 ` H.J. Lu
2011-07-22 13:20 ` Rainer Orth
2011-07-22 12:37 ` Jakub Jelinek
2011-07-22 13:21 ` Joseph S. Myers
2011-07-22 13:29 ` H.J. Lu
2011-07-22 14:17 ` H.J. Lu
2011-07-22 14:55 ` H.J. Lu
2011-08-06 14:51 ` H.J. Lu
2011-08-09 14:32 ` H.J. Lu
2011-08-14 19:20 ` H.J. Lu
2011-08-19 10:05 ` Jakub Jelinek
2011-08-19 14:58 ` H.J. Lu
2011-08-19 15:54 ` Jakub Jelinek
2011-08-20 21:16 ` H.J. Lu
2012-03-19 20:35 ` DJ Delorie
2012-03-19 20:40 ` Andrew Pinski
2012-03-19 20:42 ` DJ Delorie
2011-07-01 14:12 ` H.J. Lu
2011-06-03 17:13 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoq52MYN-+y6q3zKRLhwVH1fCibW42RQeOsphjcf3P+ng@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=bonzini@gnu.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).