From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH, PR65915] Fix float conversion split.
Date: Thu, 30 Apr 2015 15:22:00 -0000 [thread overview]
Message-ID: <CAMe9rOoqMpxNVGHgBK8+8CB-psVxGKY=J3kY=3DsTKo+OqR-Ng@mail.gmail.com> (raw)
In-Reply-To: <20150430151512.GA106194@msticlxl7.ims.intel.com>
On Thu, Apr 30, 2015 at 8:15 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> Hi,
>>
>> Looks like I missed some splits, which caused PR65915.
>> Patch below fixes it.
>> Ok for trunk?
>>
>> 2015-04-28 Ilya Tocar <ilya.tocar@intel.com>
>>
>> * config/i386/i386.md (define_split): Check for xmm16+,
>> when splitting scalar float conversion.
>>
>>
>> ---
>> gcc/config/i386/i386.md | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
>> index 937871a..af1cd9b 100644
>> --- a/gcc/config/i386/i386.md
>> +++ b/gcc/config/i386/i386.md
>> @@ -4897,7 +4897,9 @@
>> "TARGET_SSE2 && TARGET_SSE_MATH
>> && TARGET_USE_VECTOR_CONVERTS && optimize_function_for_speed_p (cfun)
>> && reload_completed && SSE_REG_P (operands[0])
>> - && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)"
>> + && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)
>> + && (!EXT_REX_SSE_REG_P (operands[0])
>> + || TARGET_AVX512VL)"
>> [(const_int 0)]
>> {
>> operands[3] = simplify_gen_subreg (<ssevecmode>mode, operands[0],
>> @@ -4921,7 +4923,9 @@
>> "TARGET_SSE2 && TARGET_SSE_MATH
>> && TARGET_SSE_PARTIAL_REG_DEPENDENCY
>> && optimize_function_for_speed_p (cfun)
>> - && reload_completed && SSE_REG_P (operands[0])"
>> + && reload_completed && SSE_REG_P (operands[0])
>> + && (!EXT_REX_SSE_REG_P (operands[0])
>> + || TARGET_AVX512VL)"
>> [(const_int 0)]
>> {
>> const machine_mode vmode = <MODEF:ssevecmode>mode;
>> --
>> 1.8.3.1
>>
>
> Updated version below (now with test).
>
> ---
> gcc/config/i386/i386.md | 8 ++++++--
> gcc/config/i386/sse.md | 6 +++---
> gcc/testsuite/gcc.target/i386/pr65915.c | 6 ++++++
> 3 files changed, 15 insertions(+), 5 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/i386/pr65915.c
>
> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
> index 937871a..af1cd9b 100644
> --- a/gcc/config/i386/i386.md
> +++ b/gcc/config/i386/i386.md
> @@ -4897,7 +4897,9 @@
> "TARGET_SSE2 && TARGET_SSE_MATH
> && TARGET_USE_VECTOR_CONVERTS && optimize_function_for_speed_p (cfun)
> && reload_completed && SSE_REG_P (operands[0])
> - && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)"
> + && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)
> + && (!EXT_REX_SSE_REG_P (operands[0])
> + || TARGET_AVX512VL)"
> [(const_int 0)]
> {
> operands[3] = simplify_gen_subreg (<ssevecmode>mode, operands[0],
> @@ -4921,7 +4923,9 @@
> "TARGET_SSE2 && TARGET_SSE_MATH
> && TARGET_SSE_PARTIAL_REG_DEPENDENCY
> && optimize_function_for_speed_p (cfun)
> - && reload_completed && SSE_REG_P (operands[0])"
> + && reload_completed && SSE_REG_P (operands[0])
> + && (!EXT_REX_SSE_REG_P (operands[0])
> + || TARGET_AVX512VL)"
> [(const_int 0)]
> {
> const machine_mode vmode = <MODEF:ssevecmode>mode;
> diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> index 9b7009a..c61098d 100644
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -4258,11 +4258,11 @@
> (set_attr "mode" "TI")])
>
> (define_insn "sse2_cvtsi2sd"
> - [(set (match_operand:V2DF 0 "register_operand" "=x,x,x")
> + [(set (match_operand:V2DF 0 "register_operand" "=x,x,v")
> (vec_merge:V2DF
> (vec_duplicate:V2DF
> (float:DF (match_operand:SI 2 "nonimmediate_operand" "r,m,rm")))
> - (match_operand:V2DF 1 "register_operand" "0,0,x")
> + (match_operand:V2DF 1 "register_operand" "0,0,v")
> (const_int 1)))]
> "TARGET_SSE2"
> "@
> @@ -4275,7 +4275,7 @@
> (set_attr "amdfam10_decode" "vector,double,*")
> (set_attr "bdver1_decode" "double,direct,*")
> (set_attr "btver2_decode" "double,double,double")
> - (set_attr "prefix" "orig,orig,vex")
> + (set_attr "prefix" "orig,orig,maybe_evex")
> (set_attr "mode" "DF")])
>
> (define_insn "sse2_cvtsi2sdq<round_name>"
> diff --git a/gcc/testsuite/gcc.target/i386/pr65915.c b/gcc/testsuite/gcc.target/i386/pr65915.c
> new file mode 100644
> index 0000000..990c5aa
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr65915.c
> @@ -0,0 +1,6 @@
> +/* { dg-do run } */
> +/* { dg-options "-O2 -mavx512f -fpic -mcmodel=medium" } */
> +/* { dg-require-effective-target avx512f } */
> +/* { dg-require-effective-target lp64 } */
> +
> +#include "avx512f-vrndscalepd-2.c"
Missing testcases for
FAIL: gcc.target/i386/avx512f-vrndscaleps-2.c (test for excess errors)
FAIL: gcc.target/i386/avx512vl-vrndscaleps-2.c (internal compiler error)
as well as ChangeLog entries.
--
H.J.
next prev parent reply other threads:[~2015-04-30 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 9:24 [PATCH] Make wider use of "v" constraint in i386.md Ilya Tocar
[not found] ` <20150323160222.GB10265@msticlxl7.ims.intel.com>
2015-03-24 13:43 ` Kirill Yukhin
2015-04-28 16:22 ` [PATCH, PR65915] Fix float conversion split Ilya Tocar
2015-04-28 16:59 ` H.J. Lu
2015-04-30 15:18 ` Ilya Tocar
2015-04-30 15:22 ` H.J. Lu [this message]
2015-05-04 8:08 ` Uros Bizjak
2015-05-05 13:03 ` Ilya Tocar
2015-05-05 13:13 ` Uros Bizjak
2015-04-17 8:10 ` [PATCH] Make wider use of "v" constraint in i386.md Uros Bizjak
2015-04-27 15:28 ` Ilya Tocar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOoqMpxNVGHgBK8+8CB-psVxGKY=J3kY=3DsTKo+OqR-Ng@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kirill.yukhin@gmail.com \
--cc=tocarip.intel@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).