From: "H.J. Lu" <hjl.tools@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH: PR target/49600: Bad SSE2 int->float split in i386.md
Date: Mon, 04 Jul 2011 05:13:00 -0000 [thread overview]
Message-ID: <CAMe9rOovV+YsDqzW1b6krvKMMjXXNuvW7Za8cNkTFa-N_P=LTQ@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOo+4641S9pAscgPGPodb0z+M+XJiSuwaB==wVuOtZn4fg@mail.gmail.com>
On Sun, Jul 3, 2011 at 9:27 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Jul 3, 2011 at 4:27 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> On Fri, Jul 1, 2011 at 12:50 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>> In one SSE2 int->float split, when TARGET_USE_VECTOR_CONVERTS is true,
>>> TARGET_INTER_UNIT_MOVES is false and GENERAL_REG_P (op1) is true. we
>>> will get gcc_unreachable. This patch removes TARGET_INTER_UNIT_MOVES
>>> check. OK for trunk?
>>
>> This will result in register allocation failure. Operand 0 of
That particular sse2_loadld insn matches:
(insn 49 22 50 5 (set (reg:V4SI 21 xmm0 [83])
(vec_merge:V4SI (vec_duplicate:V4SI (reg/v:SI 1 dx [orig:64
test ] [64]))
(const_vector:V4SI [
(const_int 0 [0])
(const_int 0 [0])
(const_int 0 [0])
(const_int 0 [0])
])
(const_int 1 [0x1]))) x.i:11 1365 {vec_setv4si_0}
(nil))
>> sse2_loadld pattern has conditional constraint Yi that depends on
>> TARGET_INTER_UNIT_MOVES, so we can't blindly generate sse2_loadld
>> after reload. I'm testing attached patch.
>>
>> BTW: Do you perhaps have a testcase for this problem?
>
> I have a testcase. But it needs a new x86 optimization we are working on it.
>
>> 2011-07-03 Uros Bizjak <ubizjak@gmail.com>
>>
>> PR target/49600
>> * config/i386/i386.md (SSE2 int->float split): Push operand 1 in
>> general register to memory for !TARGET_INTER_UNIT_MOVES.
>>
>
> I will give it a try.
>
It doesn't work: I still got
x.i: In function \u2018ran\u2019:
x.i:12:2: internal compiler error: in gen_split_2030, at
config/i386/i386.md:5045
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make: *** [x.s] Error 1
--
H.J.
next prev parent reply other threads:[~2011-07-04 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110630225005.GA1839@intel.com>
2011-07-03 11:27 ` Uros Bizjak
2011-07-04 4:27 ` H.J. Lu
2011-07-04 5:13 ` H.J. Lu [this message]
2011-07-04 10:18 ` Uros Bizjak
2011-07-04 13:43 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOovV+YsDqzW1b6krvKMMjXXNuvW7Za8cNkTFa-N_P=LTQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).