From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71951 invoked by alias); 23 May 2018 22:42:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71911 invoked by uid 89); 23 May 2018 22:42:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ot0-f194.google.com Received: from mail-ot0-f194.google.com (HELO mail-ot0-f194.google.com) (74.125.82.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 22:42:27 +0000 Received: by mail-ot0-f194.google.com with SMTP id y10-v6so27148081otg.10 for ; Wed, 23 May 2018 15:42:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7P0y9OlM4UJqUYaGD55ERBTyT2mbcnFUs/ue5y1m32s=; b=ba0AbscmPaX7pabv82Dq2T2w3zINtS4h0MeaOkCPay6eKRTI9muahqbPYulS8Yh3Yw UNvDtPwL+vBDa/5/wJ36RzOkT8NGNKY5dpGfrQI2K/Hn1OFopb8uSVEQb86rYutP+CU4 mFNSK/lCh6ASK8MaJxvvci8ZClKHAaGWTKr8ODzx856L0cABd/6GH8dPibuEACGAUCHd 3VoCD9OjGRR9fSibjd8TFyhKidiOufGIyTCNDVTZAT+HuG33SV74BiQpC0S90a99deIF bXqT1FV2sYkE3r/eUtSgzk7AblZZi9lcdOoYtdJ+yIC6uCleBDn/glbSshF/gy0/g7v8 NjbA== X-Gm-Message-State: ALKqPwcJrwQwf/W6ax02SJqMF6WYzRNbnHcU7khlI7GzVL6LBdP6oemE OU4MbU0iwLBaIJSxvg0jicrv5uPJLH2XdxwrTF0= X-Google-Smtp-Source: AB8JxZrDA1MjKDNQ0v/BuhCy/rgtga+aajzYN/egADHdd06HAx2vcT7/bLn71MSdh71+SpDgjFypsU7UgsgZmldS7iw= X-Received: by 2002:a9d:2a0d:: with SMTP id t13-v6mr2825912ota.204.1527115343698; Wed, 23 May 2018 15:42:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:2e12:0:0:0:0:0 with HTTP; Wed, 23 May 2018 15:42:23 -0700 (PDT) In-Reply-To: References: <1516628770-25036-1-git-send-email-luis.machado@linaro.org> <1516628770-25036-2-git-send-email-luis.machado@linaro.org> <468c1099-3a87-6e95-53c4-3ba62fe3472f@linaro.org> <5AFAAA57.2080501@foss.arm.com> <3b4ec84e-5902-f7de-f047-282c3b3fff08@linaro.org> <5AFBF522.5040805@foss.arm.com> <41528915-fb50-7c59-f476-f5c085621bc8@linaro.org> <12caffd9-81c4-1a29-429a-6fd712db08d8@linaro.org> <7ea9a127-1ae6-9fa6-6cd4-06818a3d7b8b@linaro.org> From: "H.J. Lu" Date: Wed, 23 May 2018 22:45:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] Introduce prefetch-minimum stride option To: Luis Machado Cc: Kyrill Tkachov , GCC Patches , James Greenhalgh , Richard Earnshaw , Jeff Law Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg01309.txt.bz2 On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: > On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: > >>> >>> Sorry. Does the following fix it for i686? >>> >> >> Index: gcc/tree-ssa-loop-prefetch.c >> =================================================================== >> --- gcc/tree-ssa-loop-prefetch.c (revision 260625) >> +++ gcc/tree-ssa-loop-prefetch.c (working copy) >> @@ -1014,7 +1014,8 @@ >> fprintf (dump_file, >> "Step for reference %u:%u (%ld) is less than the mininum " >> ^^^ Please use >> HOST_WIDE_INT_PRINT_DEC >> "required stride of %d\n", >> - ref->group->uid, ref->uid, int_cst_value (ref->group->step), >> + ref->group->uid, ref->uid, >> + (HOST_WIDE_INT) int_cst_value (ref->group->step), >> PREFETCH_MINIMUM_STRIDE); >> >> > > Something like this. > > -- > H.J. > --- > diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c > index c3e7fd1e529..949a67f360e 100644 > --- a/gcc/tree-ssa-loop-prefetch.c > +++ b/gcc/tree-ssa-loop-prefetch.c > @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref) > { > if (dump_file && (dump_flags & TDF_DETAILS)) > fprintf (dump_file, > - "Step for reference %u:%u (%ld) is less than the mininum " > - "required stride of %d\n", > + "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_C > + ") is less than the mininum required stride of %d\n", > ref->group->uid, ref->uid, int_cst_value (ref->group->step), > PREFETCH_MINIMUM_STRIDE); > return false; I meant: diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c index c3e7fd1e529..e34b78dc186 100644 --- a/gcc/tree-ssa-loop-prefetch.c +++ b/gcc/tree-ssa-loop-prefetch.c @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref) { if (dump_file && (dump_flags & TDF_DETAILS)) fprintf (dump_file, - "Step for reference %u:%u (%ld) is less than the mininum " - "required stride of %d\n", + "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_DEC + ") is less than the mininum required stride of %d\n", ref->group->uid, ref->uid, int_cst_value (ref->group->step), PREFETCH_MINIMUM_STRIDE); return false; -- H.J.