From: "H.J. Lu" <hjl.tools@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] i386: Fix conversion of move to/from AX_REG into xchg [PR106707]
Date: Thu, 1 Sep 2022 15:21:47 -0700 [thread overview]
Message-ID: <CAMe9rOoxvH3j0T_4PjFnGzrLrepb1Q9qE=Fb0RKbBppnyzWbJw@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4ZzGQfAyxvNU7oUpT8N+24HBj_WaSFypuSh8h4F9Fg4aQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Thu, Sep 1, 2022 at 11:23 AM Uros Bizjak via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The conversion of a move pattern where both operands are AX_REG
> should be prevented.
>
> 2022-09-01 Uroš Bizjak <ubizjak@gmail.com>
>
> gcc/ChangeLog:
>
> PR target/106707
> * config/i386/i386.md (moves to/from AX_REG into xchg peephole2):
> Do not convert a move pattern where both operands are AX_REG.
>
> gcc/testsuite/ChangeLog:
>
> PR target/106707
> * gcc.target/i386/pr106707.c: New test.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> Pushed to master.
>
> Uros.
I am checking in this to replace long with long long for 64-bit integer.
--
H.J.
[-- Attachment #2: 0001-i386-Replace-long-with-long-long-for-64-bit-integer.patch --]
[-- Type: text/x-patch, Size: 1006 bytes --]
From 01ca233f7a8ab683968d1ae2eb6e9f1049e86ad2 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 1 Sep 2022 15:18:18 -0700
Subject: [PATCH] i386: Replace long with long long for 64-bit integer
Replace long with long long for 64-bit integer since long may be 32
bits.
PR target/106707
* gcc.target/i386/pr106707.c (foo): Replace long with long long.
---
gcc/testsuite/gcc.target/i386/pr106707.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr106707.c b/gcc/testsuite/gcc.target/i386/pr106707.c
index a127ccd4679..2e8ebaafb33 100644
--- a/gcc/testsuite/gcc.target/i386/pr106707.c
+++ b/gcc/testsuite/gcc.target/i386/pr106707.c
@@ -10,9 +10,9 @@ unsigned x, y;
V v;
void
-foo (long a)
+foo (long long a)
{
- long l = a != x;
+ long long l = a != x;
int i = __builtin_add_overflow_p (y * ii, 0, 0);
V u = ii < x | v, w = x <= u < i & y <= x / ii;
v = __builtin_shufflevector (v, w, 1, 2) + (V) l;
--
2.37.2
prev parent reply other threads:[~2022-09-01 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 18:22 Uros Bizjak
2022-09-01 22:21 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOoxvH3j0T_4PjFnGzrLrepb1Q9qE=Fb0RKbBppnyzWbJw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).