From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7523 invoked by alias); 9 Aug 2012 14:51:24 -0000 Received: (qmail 7494 invoked by uid 22791); 9 Aug 2012 14:51:21 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-vb0-f47.google.com (HELO mail-vb0-f47.google.com) (209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 14:50:56 +0000 Received: by vbbfr13 with SMTP id fr13so470059vbb.20 for ; Thu, 09 Aug 2012 07:50:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.225.194 with SMTP id it2mr17166133vcb.32.1344523855997; Thu, 09 Aug 2012 07:50:55 -0700 (PDT) Received: by 10.58.165.104 with HTTP; Thu, 9 Aug 2012 07:50:55 -0700 (PDT) In-Reply-To: References: <20120801184138.GA3787@intel.com> <87a9ye1lsh.fsf@talisman.home> <87r4rlkcf1.fsf@talisman.home> Date: Thu, 09 Aug 2012 14:51:00 -0000 Message-ID: Subject: Re: PATCH: PR rtl-optimization/54157: [x32] -maddress-mode=long failures From: "H.J. Lu" To: Uros Bizjak , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg00539.txt.bz2 On Wed, Aug 8, 2012 at 8:11 AM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Wed, Aug 8, 2012 at 6:43 AM, Uros Bizjak wrote: >>> Probably we need to backport this patch to 4.7, where x32 is >>> -maddress-mode=long by default. >>> >> >> It doesn't fail on 4.7 branch since checking mode on PLUS CONST >> is new on trunk. However, I think it is a correctness issue. Is this >> OK to backport to 4.7? > > Yeah, I agree we should backport it. > > Richard I am checking this into 4.7 branch. Tested on Linux/x32, Linux/ia32 and Linux/x86-64. Thanks. -- H.J. --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index bc7c36c..44b0d32 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,13 @@ +2012-08-09 H.J. Lu + + Backport from mainline + 2012-08-08 Richard Sandiford + H.J. Lu + + PR rtl-optimization/54157 + * combine.c (gen_lowpart_for_combine): Don't return identity + for CONST or symbolic reference. + 2012-08-06 Uros Bizjak Backport from mainline diff --git a/gcc/combine.c b/gcc/combine.c index 3d81da8a..67bd776 100644 --- a/gcc/combine.c +++ b/gcc/combine.c @@ -10802,13 +10802,6 @@ gen_lowpart_for_combine (enum machine_mode omode, rtx x) if (omode == imode) return x; - /* Return identity if this is a CONST or symbolic reference. */ - if (omode == Pmode - && (GET_CODE (x) == CONST - || GET_CODE (x) == SYMBOL_REF - || GET_CODE (x) == LABEL_REF)) - return x; - /* We can only support MODE being wider than a word if X is a constant integer or has a mode the same size. */ if (GET_MODE_SIZE (omode) > UNITS_PER_WORD diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 9fd8113..ef35a62 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2012-08-09 H.J. Lu + + Backport from mainline + 2012-08-08 H.J. Lu + + PR rtl-optimization/54157 + * gcc.target/i386/pr54157.c: New file. + 2012-08-01 Uros Bizjak Backport from mainline diff --git a/gcc/testsuite/gcc.target/i386/pr54157.c b/gcc/testsuite/gcc.target/i386/pr54157.c new file mode 100644 index 0000000..59fcd79 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr54157.c @@ -0,0 +1,21 @@ +/* { dg-do compile { target { ! { ia32 } } } } */ +/* { dg-options "-O2 -mx32 -ftree-vectorize" } */ + +struct s2{ + int n[24 -1][24 -1][24 -1]; +}; + +struct test2{ + struct s2 e; +}; + +struct test2 tmp2[4]; + +void main1 () +{ + int i,j; + + for (i = 0; i < 24 -4; i++) + for (j = 0; j < 24 -4; j++) + tmp2[2].e.n[1][i][j] = 8; +}