From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by sourceware.org (Postfix) with ESMTPS id 3A2263857C76 for ; Fri, 2 Feb 2024 12:22:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A2263857C76 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A2263857C76 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706876578; cv=none; b=rwxBYnVdKTIDsWgHusKDo80P/vxuFsUOWOHP3lGzNUd5KRSWtXJmeFkn40bLE0FiQhzcm37wFgzOyeUyfzIiQGiZbdh+YqNg574z778Duw4yuP1nSf6DRV/kZwvzvE0HDC622maWAgvOQRTqz9xzwrazAvTPkE+aYP7b7q1uVOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706876578; c=relaxed/simple; bh=x407IhTjz13t7Ovh1wm5Ior+K4fFz0A9n632gKxTkc4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=A8zWc9+R0N4p+gqOVMPeda/Ca6dWdFTZcQeL88Q4KWzYPxc09GZGs6bLZIl3Z5yu33ucPVhGVFJo7m4Y0LoGHBtTrGw2JvHrcO6UZpogLWBMoVBNO3y4loPwMXCCEUCWkIMxQ03sy1UhL+Fod4lTGFecPK50N6pMt/ureqds7dE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-dc6d8f19ab3so1842562276.3 for ; Fri, 02 Feb 2024 04:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706876576; x=1707481376; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f7dAFS65PjDu9uSz8n88QiHjEHRhRJoK2BHRP27ks1o=; b=koEIln0Q4IRQhMJ/be0u0a96wtPI4b8A2nrBZrqeTUbrkc6PCOfSbkP6G/au9O04SS +98mqNhGZvl49xLAyfpCFgyMEMyThSob4D9IbWQnRvncw+e991LRcbwAUss9Gzes7BzN /+Wxdmv31MIfmoUF6oMCtsJm2bC90CTFiMQa2TewWaYE5FollUMLwxoTtD6q+LqPTt+O 3hwEn66+FiqZaulT0c32lLts5SULPrdLuS37ErPJbMyfOclAM1hwvz5zR52qBck/LU+b 35N0fBols3izMsfDiTpnXGa7wKpptkvk7xhHcz29GyuYRX65XPGQAgUpuekKKj7Wn0rY yLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706876576; x=1707481376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7dAFS65PjDu9uSz8n88QiHjEHRhRJoK2BHRP27ks1o=; b=K1yHURWAXlq0albdMWCBoz5AHwtqXUuLeRXWr6cmiUzR9Y9tanEyIcJx8pWu8xNu+E 1QqlzB54TGMtOIbpV5dBIT1gy7FHEChydwu0oe9X5L8JbCOP9ZqFhkxAZ4005PrX9Iu2 kKhZQzuFT+lGAlXHBPL3uL2O5ZjrdwcL+LBxd2DdE0zjpriFih5T8EL3sEsJeUyAm+Ez ehLgsCU7Di6EkrCcuObBpQSIDZX9bIXdTHuN7D8AIiaOYO5efLCbWzuPL/0GXrjtyJQJ DLISMZsxZkYBxsS1IGwCpUSn06JAWmEneKimTrrpW6uC9sVvb0cZ+PcFtUu3dPr+LrKT 8Q9Q== X-Gm-Message-State: AOJu0Yx6TccDeB5xyE3MXsUQLmhWpmW7MyjftXQ+7Kl8xkVjOvMCJodH r6ccUMISI1PSQk/eErLtAXz8bfiYdh4BuJ2UmFAwfi6nzScxOw4qmjYv9HtG+TE3b/tMoaXIteh WgNlge7rV9uGUorI23nXV+PigE9g= X-Google-Smtp-Source: AGHT+IHQN0lhO3vtsuIzB5p3qR9l3Ao6EwFjEXCYwzEY1N+X5cUK+zLmP5QfGaj1OZbQQElnS2khwW2OY7Ci7W9KxUc= X-Received: by 2002:a25:ce88:0:b0:dc2:218c:6287 with SMTP id x130-20020a25ce88000000b00dc2218c6287mr1960692ybe.44.1706876576519; Fri, 02 Feb 2024 04:22:56 -0800 (PST) MIME-Version: 1.0 References: <20240201181530.99684-1-hjl.tools@gmail.com> <72D525E2-2F15-40FD-AA9A-4C334F8CB5FA@gmail.com> In-Reply-To: <72D525E2-2F15-40FD-AA9A-4C334F8CB5FA@gmail.com> From: "H.J. Lu" Date: Fri, 2 Feb 2024 04:22:20 -0800 Message-ID: Subject: Re: [PATCH] x86-64: Find a scratch register for large model profiling To: rep.dot.nop@gmail.com Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 2, 2024 at 4:07=E2=80=AFAM wrote: > > On 2 February 2024 00:02:54 CET, "H.J. Lu" wrote: > >On Thu, Feb 1, 2024 at 10:32=E2=80=AFAM Jakub Jelinek = wrote: > >> > >> On Thu, Feb 01, 2024 at 10:15:30AM -0800, H.J. Lu wrote: > >> > --- a/gcc/config/i386/i386.cc > >> > +++ b/gcc/config/i386/i386.cc > >> > @@ -22749,6 +22749,31 @@ current_fentry_section (const char **name) > >> > return true; > >> > } > >> > > >> > +/* Return an unused caller-saved register at entry for profile. */ > >> > + > >> > +static int > >> > +x86_64_select_profile_regnum (bool r11_ok ATTRIBUTE_UNUSED) > >> > +{ > >> > + int i; > >> > >> Why not just return R10_REG here if flag_entry !=3D 0 (i.e. keep exist= ing > >> behavior unless emitting profiler after prologue)? > > > >Fixed in v2. > > Nit: r10_ok is now superfluous, but lets wait for Jakub. > thanks Fixed in v3. Thanks. --=20 H.J.