* [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
@ 2020-06-28 14:19 H.J. Lu
2020-07-07 15:56 ` Kirill Yukhin
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2020-06-28 14:19 UTC (permalink / raw)
To: gcc-patches
Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
Although it doesn't show performance change in our workloads, FMA can
improve other workloads.
gcc/
PR target/88713
* config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
* config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
(rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
(rsqrtv16sf2): Removed.
gcc/testsuite/
PR target/88713
* gcc.target/i386/pr88713-1.c: New test.
* gcc.target/i386/pr88713-2.c: Likewise.
---
gcc/config/i386/i386-expand.c | 18 ++++++++++++-----
gcc/config/i386/sse.md | 24 ++++++++++-------------
gcc/testsuite/gcc.target/i386/pr88713-1.c | 13 ++++++++++++
gcc/testsuite/gcc.target/i386/pr88713-2.c | 6 ++++++
4 files changed, 42 insertions(+), 19 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/i386/pr88713-1.c
create mode 100644 gcc/testsuite/gcc.target/i386/pr88713-2.c
diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c
index d81dd73f034..49718b7a41c 100644
--- a/gcc/config/i386/i386-expand.c
+++ b/gcc/config/i386/i386-expand.c
@@ -15535,14 +15535,22 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
}
}
+ mthree = force_reg (mode, mthree);
+
/* e0 = x0 * a */
emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a)));
- /* e1 = e0 * x0 */
- emit_insn (gen_rtx_SET (e1, gen_rtx_MULT (mode, e0, x0)));
- /* e2 = e1 - 3. */
- mthree = force_reg (mode, mthree);
- emit_insn (gen_rtx_SET (e2, gen_rtx_PLUS (mode, e1, mthree)));
+ if (TARGET_FMA || TARGET_AVX512F)
+ emit_insn (gen_rtx_SET (e2,
+ gen_rtx_FMA (mode, e0, x0, mthree)));
+ else
+ {
+ /* e1 = e0 * x0 */
+ emit_insn (gen_rtx_SET (e1, gen_rtx_MULT (mode, e0, x0)));
+
+ /* e2 = e1 - 3. */
+ emit_insn (gen_rtx_SET (e2, gen_rtx_PLUS (mode, e1, mthree)));
+ }
mhalf = force_reg (mode, mhalf);
if (recip)
diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 431571a4bc1..d3ad5833e1f 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -326,6 +326,12 @@ (define_mode_iterator VF_AVX512VL
[V16SF (V8SF "TARGET_AVX512VL") (V4SF "TARGET_AVX512VL")
V8DF (V4DF "TARGET_AVX512VL") (V2DF "TARGET_AVX512VL")])
+;; AVX512VL SF/DF plus 128- and 256-bit SF vector modes
+(define_mode_iterator VF_AVX512VL_VF1_128_256
+ [(V16SF "TARGET_AVX512F") (V8SF "TARGET_AVX") V4SF
+ (V8DF "TARGET_AVX512F") (V4DF "TARGET_AVX512VL")
+ (V2DF "TARGET_AVX512VL")])
+
(define_mode_iterator VF2_AVX512VL
[V8DF (V4DF "TARGET_AVX512VL") (V2DF "TARGET_AVX512VL")])
@@ -2070,26 +2076,16 @@ (define_insn "*<sse>_vmsqrt<mode>2<mask_scalar_name><round_scalar_name>"
(set_attr "mode" "<ssescalarmode>")])
(define_expand "rsqrt<mode>2"
- [(set (match_operand:VF1_128_256 0 "register_operand")
- (unspec:VF1_128_256
- [(match_operand:VF1_128_256 1 "vector_operand")] UNSPEC_RSQRT))]
+ [(set (match_operand:VF_AVX512VL_VF1_128_256 0 "register_operand")
+ (unspec:VF_AVX512VL_VF1_128_256
+ [(match_operand:VF_AVX512VL_VF1_128_256 1 "vector_operand")]
+ UNSPEC_RSQRT))]
"TARGET_SSE && TARGET_SSE_MATH"
{
ix86_emit_swsqrtsf (operands[0], operands[1], <MODE>mode, true);
DONE;
})
-(define_expand "rsqrtv16sf2"
- [(set (match_operand:V16SF 0 "register_operand")
- (unspec:V16SF
- [(match_operand:V16SF 1 "vector_operand")]
- UNSPEC_RSQRT28))]
- "TARGET_AVX512ER && TARGET_SSE_MATH"
-{
- ix86_emit_swsqrtsf (operands[0], operands[1], V16SFmode, true);
- DONE;
-})
-
(define_insn "<sse>_rsqrt<mode>2"
[(set (match_operand:VF1_128_256 0 "register_operand" "=x")
(unspec:VF1_128_256
diff --git a/gcc/testsuite/gcc.target/i386/pr88713-1.c b/gcc/testsuite/gcc.target/i386/pr88713-1.c
new file mode 100644
index 00000000000..2f583b6d1a4
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
+
+extern float sqrtf (float);
+
+void
+rsqrt (float* restrict r, float* restrict a)
+{
+ for (int i = 0; i < 64; i++)
+ r[i] = sqrtf(a[i]);
+}
+
+/* { dg-final { scan-assembler "\tvfmadd\[123\]+ps" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr88713-2.c b/gcc/testsuite/gcc.target/i386/pr88713-2.c
new file mode 100644
index 00000000000..559026df485
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr88713-2.c
@@ -0,0 +1,6 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -Ofast -march=skylake-avx512 -mno-fma" } */
+
+#include "pr88713-1.c"
+
+/* { dg-final { scan-assembler "\tvfmadd\[123\]+ps" } } */
--
2.26.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
2020-06-28 14:19 [PATCH] x86: Enable FMA in rsqrt<mode>2 expander H.J. Lu
@ 2020-07-07 15:56 ` Kirill Yukhin
2020-07-07 16:06 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Kirill Yukhin @ 2020-07-07 15:56 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
Hello HJ,
On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> Although it doesn't show performance change in our workloads, FMA can
> improve other workloads.
>
> gcc/
>
> PR target/88713
> * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> (rsqrtv16sf2): Removed.
>
> gcc/testsuite/
>
> PR target/88713
> * gcc.target/i386/pr88713-1.c: New test.
> * gcc.target/i386/pr88713-2.c: Likewise.
So, you've introduced new rsqrt expanders for DF vectors and relaxed
condition for V16SF. What I didn't get is why did you change unspec
type from RSQRT to RSQRT28 for V16SF expander?
--
K
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
2020-07-07 15:56 ` Kirill Yukhin
@ 2020-07-07 16:06 ` H.J. Lu
2020-07-09 12:04 ` Kirill Yukhin
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2020-07-07 16:06 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: GCC Patches
On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>
> Hello HJ,
>
> On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > Although it doesn't show performance change in our workloads, FMA can
> > improve other workloads.
> >
> > gcc/
> >
> > PR target/88713
> > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > (rsqrtv16sf2): Removed.
> >
> > gcc/testsuite/
> >
> > PR target/88713
> > * gcc.target/i386/pr88713-1.c: New test.
> > * gcc.target/i386/pr88713-2.c: Likewise.
>
> So, you've introduced new rsqrt expanders for DF vectors and relaxed
> condition for V16SF. What I didn't get is why did you change unspec
> type from RSQRT to RSQRT28 for V16SF expander?
>
UNSPEC in define_expand is meaningless when the pattern is fully
expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
expander can be removed.
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
2020-07-07 16:06 ` H.J. Lu
@ 2020-07-09 12:04 ` Kirill Yukhin
2020-07-09 13:35 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Kirill Yukhin @ 2020-07-09 12:04 UTC (permalink / raw)
To: H.J. Lu; +Cc: GCC Patches
On 07 июл 09:06, H.J. Lu wrote:
> On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> >
> > Hello HJ,
> >
> > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > Although it doesn't show performance change in our workloads, FMA can
> > > improve other workloads.
> > >
> > > gcc/
> > >
> > > PR target/88713
> > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > (rsqrtv16sf2): Removed.
> > >
> > > gcc/testsuite/
> > >
> > > PR target/88713
> > > * gcc.target/i386/pr88713-1.c: New test.
> > > * gcc.target/i386/pr88713-2.c: Likewise.
> >
> > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > condition for V16SF. What I didn't get is why did you change unspec
> > type from RSQRT to RSQRT28 for V16SF expander?
> >
>
> UNSPEC in define_expand is meaningless when the pattern is fully
> expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> expander can be removed.
Agree.
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
I gues -O2 is useless here (and in -2.c test).
Othwerwise LGTM.
--
K
>
> --
> H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
2020-07-09 12:04 ` Kirill Yukhin
@ 2020-07-09 13:35 ` H.J. Lu
2020-07-09 22:02 ` [PATCH] x86: Check TARGET_AVX512VL when enabling FMA H.J. Lu
2020-07-13 16:12 ` [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 H.J. Lu
0 siblings, 2 replies; 12+ messages in thread
From: H.J. Lu @ 2020-07-09 13:35 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>
> On 07 июл 09:06, H.J. Lu wrote:
> > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > >
> > > Hello HJ,
> > >
> > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > Although it doesn't show performance change in our workloads, FMA can
> > > > improve other workloads.
> > > >
> > > > gcc/
> > > >
> > > > PR target/88713
> > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > (rsqrtv16sf2): Removed.
> > > >
> > > > gcc/testsuite/
> > > >
> > > > PR target/88713
> > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > >
> > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > condition for V16SF. What I didn't get is why did you change unspec
> > > type from RSQRT to RSQRT28 for V16SF expander?
> > >
> >
> > UNSPEC in define_expand is meaningless when the pattern is fully
> > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > expander can be removed.
>
> Agree.
I will leave UNSPEC alone here.
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> @@ -0,0 +1,13 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
>
> I gues -O2 is useless here (and in -2.c test).
Fixed.
> Othwerwise LGTM.
>
This is the patch I am checking in.
Thanks.
--
H.J.
[-- Attachment #2: 0001-x86-Enable-FMA-in-rsqrt-mode-2-expander.patch --]
[-- Type: text/x-patch, Size: 4895 bytes --]
From 54d4f6c740ed885e55b0092895ef0986714211b3 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 23 Jan 2019 06:33:58 -0800
Subject: [PATCH] x86: Enable FMA in rsqrt<mode>2 expander
Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
Although it doesn't show performance change in our workloads, FMA can
improve other workloads.
gcc/
PR target/88713
* config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
* config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
(rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
(rsqrtv16sf2): Removed.
gcc/testsuite/
PR target/88713
* gcc.target/i386/pr88713-1.c: New test.
* gcc.target/i386/pr88713-2.c: Likewise.
---
gcc/config/i386/i386-expand.c | 18 ++++++++++++-----
gcc/config/i386/sse.md | 24 ++++++++++-------------
gcc/testsuite/gcc.target/i386/pr88713-1.c | 13 ++++++++++++
gcc/testsuite/gcc.target/i386/pr88713-2.c | 6 ++++++
4 files changed, 42 insertions(+), 19 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/i386/pr88713-1.c
create mode 100644 gcc/testsuite/gcc.target/i386/pr88713-2.c
diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c
index d81dd73f034..49718b7a41c 100644
--- a/gcc/config/i386/i386-expand.c
+++ b/gcc/config/i386/i386-expand.c
@@ -15535,14 +15535,22 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
}
}
+ mthree = force_reg (mode, mthree);
+
/* e0 = x0 * a */
emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a)));
- /* e1 = e0 * x0 */
- emit_insn (gen_rtx_SET (e1, gen_rtx_MULT (mode, e0, x0)));
- /* e2 = e1 - 3. */
- mthree = force_reg (mode, mthree);
- emit_insn (gen_rtx_SET (e2, gen_rtx_PLUS (mode, e1, mthree)));
+ if (TARGET_FMA || TARGET_AVX512F)
+ emit_insn (gen_rtx_SET (e2,
+ gen_rtx_FMA (mode, e0, x0, mthree)));
+ else
+ {
+ /* e1 = e0 * x0 */
+ emit_insn (gen_rtx_SET (e1, gen_rtx_MULT (mode, e0, x0)));
+
+ /* e2 = e1 - 3. */
+ emit_insn (gen_rtx_SET (e2, gen_rtx_PLUS (mode, e1, mthree)));
+ }
mhalf = force_reg (mode, mhalf);
if (recip)
diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 431571a4bc1..d3ad5833e1f 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -326,6 +326,12 @@ (define_mode_iterator VF_AVX512VL
[V16SF (V8SF "TARGET_AVX512VL") (V4SF "TARGET_AVX512VL")
V8DF (V4DF "TARGET_AVX512VL") (V2DF "TARGET_AVX512VL")])
+;; AVX512VL SF/DF plus 128- and 256-bit SF vector modes
+(define_mode_iterator VF_AVX512VL_VF1_128_256
+ [(V16SF "TARGET_AVX512F") (V8SF "TARGET_AVX") V4SF
+ (V8DF "TARGET_AVX512F") (V4DF "TARGET_AVX512VL")
+ (V2DF "TARGET_AVX512VL")])
+
(define_mode_iterator VF2_AVX512VL
[V8DF (V4DF "TARGET_AVX512VL") (V2DF "TARGET_AVX512VL")])
@@ -2070,26 +2076,16 @@ (define_insn "*<sse>_vmsqrt<mode>2<mask_scalar_name><round_scalar_name>"
(set_attr "mode" "<ssescalarmode>")])
(define_expand "rsqrt<mode>2"
- [(set (match_operand:VF1_128_256 0 "register_operand")
- (unspec:VF1_128_256
- [(match_operand:VF1_128_256 1 "vector_operand")] UNSPEC_RSQRT))]
+ [(set (match_operand:VF_AVX512VL_VF1_128_256 0 "register_operand")
+ (unspec:VF_AVX512VL_VF1_128_256
+ [(match_operand:VF_AVX512VL_VF1_128_256 1 "vector_operand")]
+ UNSPEC_RSQRT))]
"TARGET_SSE && TARGET_SSE_MATH"
{
ix86_emit_swsqrtsf (operands[0], operands[1], <MODE>mode, true);
DONE;
})
-(define_expand "rsqrtv16sf2"
- [(set (match_operand:V16SF 0 "register_operand")
- (unspec:V16SF
- [(match_operand:V16SF 1 "vector_operand")]
- UNSPEC_RSQRT28))]
- "TARGET_AVX512ER && TARGET_SSE_MATH"
-{
- ix86_emit_swsqrtsf (operands[0], operands[1], V16SFmode, true);
- DONE;
-})
-
(define_insn "<sse>_rsqrt<mode>2"
[(set (match_operand:VF1_128_256 0 "register_operand" "=x")
(unspec:VF1_128_256
diff --git a/gcc/testsuite/gcc.target/i386/pr88713-1.c b/gcc/testsuite/gcc.target/i386/pr88713-1.c
new file mode 100644
index 00000000000..26a0da57a41
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-Ofast -mno-avx512f -mfma" } */
+
+extern float sqrtf (float);
+
+void
+rsqrt (float* restrict r, float* restrict a)
+{
+ for (int i = 0; i < 64; i++)
+ r[i] = sqrtf(a[i]);
+}
+
+/* { dg-final { scan-assembler "\tvfmadd\[123\]+ps" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr88713-2.c b/gcc/testsuite/gcc.target/i386/pr88713-2.c
new file mode 100644
index 00000000000..8b55dfcf924
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr88713-2.c
@@ -0,0 +1,6 @@
+/* { dg-do compile } */
+/* { dg-options "-Ofast -march=skylake-avx512 -mno-fma" } */
+
+#include "pr88713-1.c"
+
+/* { dg-final { scan-assembler "\tvfmadd\[123\]+ps" } } */
--
2.26.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] x86: Check TARGET_AVX512VL when enabling FMA
2020-07-09 13:35 ` H.J. Lu
@ 2020-07-09 22:02 ` H.J. Lu
2020-07-10 11:08 ` H.J. Lu
2020-07-10 11:18 ` Jakub Jelinek
2020-07-13 16:12 ` [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 H.J. Lu
1 sibling, 2 replies; 12+ messages in thread
From: H.J. Lu @ 2020-07-09 22:02 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 2633 bytes --]
On Thu, Jul 9, 2020 at 6:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> >
> > On 07 июл 09:06, H.J. Lu wrote:
> > > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > >
> > > > Hello HJ,
> > > >
> > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > > Although it doesn't show performance change in our workloads, FMA can
> > > > > improve other workloads.
> > > > >
> > > > > gcc/
> > > > >
> > > > > PR target/88713
> > > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > > (rsqrtv16sf2): Removed.
> > > > >
> > > > > gcc/testsuite/
> > > > >
> > > > > PR target/88713
> > > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > > >
> > > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > > condition for V16SF. What I didn't get is why did you change unspec
> > > > type from RSQRT to RSQRT28 for V16SF expander?
> > > >
> > >
> > > UNSPEC in define_expand is meaningless when the pattern is fully
> > > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > > expander can be removed.
> >
> > Agree.
>
> I will leave UNSPEC alone here.
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> > @@ -0,0 +1,13 @@
> > +/* { dg-do compile } */
> > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
> >
> > I gues -O2 is useless here (and in -2.c test).
>
> Fixed.
>
> > Othwerwise LGTM.
> >
>
> This is the patch I am checking in.
>
This patch is needed for
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-3.c (internal compiler error)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-3.c (test for excess errors)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-4.c (internal compiler error)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-4.c (test for excess errors)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-5.c (internal compiler error)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-5.c (test for excess errors)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-6.c (internal compiler error)
FAIL: gcc.target/i386/avx512er-vrsqrt28ps-6.c (test for excess errors)
--
H.J.
[-- Attachment #2: 0001-x86-Check-TARGET_AVX512VL-when-enabling-FMA.patch --]
[-- Type: application/x-patch, Size: 1376 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Check TARGET_AVX512VL when enabling FMA
2020-07-09 22:02 ` [PATCH] x86: Check TARGET_AVX512VL when enabling FMA H.J. Lu
@ 2020-07-10 11:08 ` H.J. Lu
2020-07-10 11:18 ` Jakub Jelinek
1 sibling, 0 replies; 12+ messages in thread
From: H.J. Lu @ 2020-07-10 11:08 UTC (permalink / raw)
To: Kirill Yukhin, Richard Biener, Martin Liška; +Cc: GCC Patches
On Thu, Jul 9, 2020 at 3:02 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 9, 2020 at 6:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > >
> > > On 07 июл 09:06, H.J. Lu wrote:
> > > > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > > >
> > > > > Hello HJ,
> > > > >
> > > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > > > Although it doesn't show performance change in our workloads, FMA can
> > > > > > improve other workloads.
> > > > > >
> > > > > > gcc/
> > > > > >
> > > > > > PR target/88713
> > > > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > > > (rsqrtv16sf2): Removed.
> > > > > >
> > > > > > gcc/testsuite/
> > > > > >
> > > > > > PR target/88713
> > > > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > > > >
> > > > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > > > condition for V16SF. What I didn't get is why did you change unspec
> > > > > type from RSQRT to RSQRT28 for V16SF expander?
> > > > >
> > > >
> > > > UNSPEC in define_expand is meaningless when the pattern is fully
> > > > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > > > expander can be removed.
> > >
> > > Agree.
> >
> > I will leave UNSPEC alone here.
> >
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> > > @@ -0,0 +1,13 @@
> > > +/* { dg-do compile } */
> > > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
> > >
> > > I gues -O2 is useless here (and in -2.c test).
> >
> > Fixed.
> >
> > > Othwerwise LGTM.
> > >
> >
> > This is the patch I am checking in.
> >
>
> This patch is needed for
>
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-3.c (internal compiler error)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-3.c (test for excess errors)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-4.c (internal compiler error)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-4.c (test for excess errors)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-5.c (internal compiler error)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-5.c (test for excess errors)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-6.c (internal compiler error)
> FAIL: gcc.target/i386/avx512er-vrsqrt28ps-6.c (test for excess errors)
>
This fixed:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96144
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Check TARGET_AVX512VL when enabling FMA
2020-07-09 22:02 ` [PATCH] x86: Check TARGET_AVX512VL when enabling FMA H.J. Lu
2020-07-10 11:08 ` H.J. Lu
@ 2020-07-10 11:18 ` Jakub Jelinek
2020-07-10 11:28 ` H.J. Lu
1 sibling, 1 reply; 12+ messages in thread
From: Jakub Jelinek @ 2020-07-10 11:18 UTC (permalink / raw)
To: H.J. Lu; +Cc: Kirill Yukhin, GCC Patches
On Thu, Jul 09, 2020 at 03:02:35PM -0700, H.J. Lu via Gcc-patches wrote:
--- a/gcc/config/i386/i386-expand.c
+++ b/gcc/config/i386/i386-expand.c
@@ -15540,7 +15540,11 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
/* e0 = x0 * a */
emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a)));
- if (TARGET_FMA || TARGET_AVX512F)
+ unsigned vector_size = GET_MODE_SIZE (mode);
+ if (TARGET_FMA
+ || (TARGET_AVX512F && vector_size == 64)
+ || (TARGET_AVX512VL && (vector_size == 32 || vector_size == 16)))
+
emit_insn (gen_rtx_SET (e2,
Why the empty line in there?
Ok for trunk with that fixed.
gen_rtx_FMA (mode, e0, x0, mthree)));
else
--
2.26.2
Jakub
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Check TARGET_AVX512VL when enabling FMA
2020-07-10 11:18 ` Jakub Jelinek
@ 2020-07-10 11:28 ` H.J. Lu
0 siblings, 0 replies; 12+ messages in thread
From: H.J. Lu @ 2020-07-10 11:28 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Kirill Yukhin, GCC Patches
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Fri, Jul 10, 2020 at 4:19 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Thu, Jul 09, 2020 at 03:02:35PM -0700, H.J. Lu via Gcc-patches wrote:
> --- a/gcc/config/i386/i386-expand.c
> +++ b/gcc/config/i386/i386-expand.c
> @@ -15540,7 +15540,11 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
> /* e0 = x0 * a */
> emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a)));
>
> - if (TARGET_FMA || TARGET_AVX512F)
> + unsigned vector_size = GET_MODE_SIZE (mode);
> + if (TARGET_FMA
> + || (TARGET_AVX512F && vector_size == 64)
> + || (TARGET_AVX512VL && (vector_size == 32 || vector_size == 16)))
> +
> emit_insn (gen_rtx_SET (e2,
>
> Why the empty line in there?
> Ok for trunk with that fixed.
>
> gen_rtx_FMA (mode, e0, x0, mthree)));
> else
This is the patch I am checking in.
Thanks.
--
H.J.
[-- Attachment #2: 0001-x86-Check-TARGET_AVX512VL-when-enabling-FMA.patch --]
[-- Type: text/x-patch, Size: 1390 bytes --]
From 2bcd21b9142cdf75fc166a73206518b8754f5b6a Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 9 Jul 2020 14:56:48 -0700
Subject: [PATCH] x86: Check TARGET_AVX512VL when enabling FMA
Check TARGET_AVX512VL when enabling FMA to avoid
gcc.target/i386/avx512er-vrsqrt28ps-3.c:25:1: error: unrecognizable insn:
(insn 29 28 30 6 (set (reg:V8SF 108)
(fma:V8SF (reg:V8SF 106)
(reg:V8SF 105)
(reg:V8SF 110)))
when TARGET_AVX512VL isn't enabled.
PR target/96144
* config/i386/i386-expand.c (ix86_emit_swsqrtsf): Check
TARGET_AVX512VL when enabling FMA.
---
gcc/config/i386/i386-expand.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c
index 49718b7a41c..e194214804b 100644
--- a/gcc/config/i386/i386-expand.c
+++ b/gcc/config/i386/i386-expand.c
@@ -15540,7 +15540,10 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
/* e0 = x0 * a */
emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a)));
- if (TARGET_FMA || TARGET_AVX512F)
+ unsigned vector_size = GET_MODE_SIZE (mode);
+ if (TARGET_FMA
+ || (TARGET_AVX512F && vector_size == 64)
+ || (TARGET_AVX512VL && (vector_size == 32 || vector_size == 16)))
emit_insn (gen_rtx_SET (e2,
gen_rtx_FMA (mode, e0, x0, mthree)));
else
--
2.26.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256
2020-07-09 13:35 ` H.J. Lu
2020-07-09 22:02 ` [PATCH] x86: Check TARGET_AVX512VL when enabling FMA H.J. Lu
@ 2020-07-13 16:12 ` H.J. Lu
2020-07-17 2:50 ` H.J. Lu
1 sibling, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2020-07-13 16:12 UTC (permalink / raw)
To: Kirill Yukhin, Hongtao Liu, Wang, Hongyu; +Cc: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]
On Thu, Jul 9, 2020 at 6:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> >
> > On 07 июл 09:06, H.J. Lu wrote:
> > > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > >
> > > > Hello HJ,
> > > >
> > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > > Although it doesn't show performance change in our workloads, FMA can
> > > > > improve other workloads.
> > > > >
> > > > > gcc/
> > > > >
> > > > > PR target/88713
> > > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > > (rsqrtv16sf2): Removed.
> > > > >
> > > > > gcc/testsuite/
> > > > >
> > > > > PR target/88713
> > > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > > >
> > > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > > condition for V16SF. What I didn't get is why did you change unspec
> > > > type from RSQRT to RSQRT28 for V16SF expander?
> > > >
> > >
> > > UNSPEC in define_expand is meaningless when the pattern is fully
> > > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > > expander can be removed.
> >
> > Agree.
>
> I will leave UNSPEC alone here.
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> > @@ -0,0 +1,13 @@
> > +/* { dg-do compile } */
> > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
> >
> > I gues -O2 is useless here (and in -2.c test).
>
> Fixed.
>
> > Othwerwise LGTM.
> >
>
> This is the patch I am checking in.
>
Since ix86_emit_swsqrtsf shouldn't be called with DF vector modes, rename
VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 and drop DF vector modes.
--
H.J.
[-- Attachment #2: 0001-x86-Rename-VF_AVX512VL_VF1_128_256-to-VF1_AVX512ER_1.patch --]
[-- Type: application/x-patch, Size: 2889 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256
2020-07-13 16:12 ` [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 H.J. Lu
@ 2020-07-17 2:50 ` H.J. Lu
2020-07-17 12:14 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2020-07-17 2:50 UTC (permalink / raw)
To: Kirill Yukhin, Hongtao Liu, Wang, Hongyu; +Cc: GCC Patches
On Mon, Jul 13, 2020 at 9:12 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 9, 2020 at 6:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > >
> > > On 07 июл 09:06, H.J. Lu wrote:
> > > > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > > >
> > > > > Hello HJ,
> > > > >
> > > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > > > Although it doesn't show performance change in our workloads, FMA can
> > > > > > improve other workloads.
> > > > > >
> > > > > > gcc/
> > > > > >
> > > > > > PR target/88713
> > > > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > > > (rsqrtv16sf2): Removed.
> > > > > >
> > > > > > gcc/testsuite/
> > > > > >
> > > > > > PR target/88713
> > > > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > > > >
> > > > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > > > condition for V16SF. What I didn't get is why did you change unspec
> > > > > type from RSQRT to RSQRT28 for V16SF expander?
> > > > >
> > > >
> > > > UNSPEC in define_expand is meaningless when the pattern is fully
> > > > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > > > expander can be removed.
> > >
> > > Agree.
> >
> > I will leave UNSPEC alone here.
> >
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> > > @@ -0,0 +1,13 @@
> > > +/* { dg-do compile } */
> > > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
> > >
> > > I gues -O2 is useless here (and in -2.c test).
> >
> > Fixed.
> >
> > > Othwerwise LGTM.
> > >
> >
> > This is the patch I am checking in.
> >
>
> Since ix86_emit_swsqrtsf shouldn't be called with DF vector modes, rename
> VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 and drop DF vector modes.
>
I will check in this patch to fix the regression next Monday if there
are objections.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256
2020-07-17 2:50 ` H.J. Lu
@ 2020-07-17 12:14 ` H.J. Lu
0 siblings, 0 replies; 12+ messages in thread
From: H.J. Lu @ 2020-07-17 12:14 UTC (permalink / raw)
To: Kirill Yukhin, Hongtao Liu, Wang, Hongyu; +Cc: GCC Patches, dcb314
On Thu, Jul 16, 2020 at 7:50 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jul 13, 2020 at 9:12 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 9, 2020 at 6:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Jul 9, 2020 at 5:04 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > >
> > > > On 07 июл 09:06, H.J. Lu wrote:
> > > > > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > > > >
> > > > > > Hello HJ,
> > > > > >
> > > > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote:
> > > > > > > Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
> > > > > > > rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
> > > > > > > Although it doesn't show performance change in our workloads, FMA can
> > > > > > > improve other workloads.
> > > > > > >
> > > > > > > gcc/
> > > > > > >
> > > > > > > PR target/88713
> > > > > > > * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
> > > > > > > * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
> > > > > > > (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
> > > > > > > (rsqrtv16sf2): Removed.
> > > > > > >
> > > > > > > gcc/testsuite/
> > > > > > >
> > > > > > > PR target/88713
> > > > > > > * gcc.target/i386/pr88713-1.c: New test.
> > > > > > > * gcc.target/i386/pr88713-2.c: Likewise.
> > > > > >
> > > > > > So, you've introduced new rsqrt expanders for DF vectors and relaxed
> > > > > > condition for V16SF. What I didn't get is why did you change unspec
> > > > > > type from RSQRT to RSQRT28 for V16SF expander?
> > > > > >
> > > > >
> > > > > UNSPEC in define_expand is meaningless when the pattern is fully
> > > > > expanded by ix86_emit_swsqrtsf. I believe that UNSPEC in rsqrt<mode>2
> > > > > expander can be removed.
> > > >
> > > > Agree.
> > >
> > > I will leave UNSPEC alone here.
> > >
> > > > --- /dev/null
> > > > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c
> > > > @@ -0,0 +1,13 @@
> > > > +/* { dg-do compile } */
> > > > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */
> > > >
> > > > I gues -O2 is useless here (and in -2.c test).
> > >
> > > Fixed.
> > >
> > > > Othwerwise LGTM.
> > > >
> > >
> > > This is the patch I am checking in.
> > >
> >
> > Since ix86_emit_swsqrtsf shouldn't be called with DF vector modes, rename
> > VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 and drop DF vector modes.
> >
>
> I will check in this patch to fix the regression next Monday if there
> are objections.
>
One more people reported the same issue. I am checking it in now.
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-07-17 12:15 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28 14:19 [PATCH] x86: Enable FMA in rsqrt<mode>2 expander H.J. Lu
2020-07-07 15:56 ` Kirill Yukhin
2020-07-07 16:06 ` H.J. Lu
2020-07-09 12:04 ` Kirill Yukhin
2020-07-09 13:35 ` H.J. Lu
2020-07-09 22:02 ` [PATCH] x86: Check TARGET_AVX512VL when enabling FMA H.J. Lu
2020-07-10 11:08 ` H.J. Lu
2020-07-10 11:18 ` Jakub Jelinek
2020-07-10 11:28 ` H.J. Lu
2020-07-13 16:12 ` [PATCH] x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 H.J. Lu
2020-07-17 2:50 ` H.J. Lu
2020-07-17 12:14 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).