From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Paolo Bonzini <bonzini@gnu.org>,
Alexandre Oliva <aoliva@redhat.com>,
Paolo Carlini <paolo.carlini@oracle.com>,
Tobias Burnus <burnus@net-b.de>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support
Date: Mon, 03 Dec 2012 18:02:00 -0000 [thread overview]
Message-ID: <CAMe9rOpNFbrqPBokMfznSTmV1ZuvmAenAr3UJiMN2oddG3mc1A@mail.gmail.com> (raw)
In-Reply-To: <20121203115242.GU2315@tucnak.redhat.com>
On Mon, Dec 3, 2012 at 3:52 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote:
>> On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote:
>> >> On 11/29/2012 06:36 PM, Tobias Burnus wrote:
>> >> >H.J. Lu wrote:
>> >> >>This patch adds --with-build-config=bootstrap-asan support. Tested on
>> >> >>Linux/x86-64. OK to install?
>> >> >
>> >> >I think that patch has broken bootstrap for me. If I do a normal
>> >> >bootstrap, Stage1 fails with:
>> >> >
>> >> >libtool: compile: unrecognized option `-D_GNU_SOURCE'
>> >> >libtool: compile: Try `libtool --help' for more information.
>> >> >make[4]: *** [interception_linux.lo] Error 1
>> >> >make[4]: Leaving directory `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception'
>> >> Likewise here. Would it be possible to revert the offending commit,
>> >> in the meanwhile?
>> >
>> > Yes, H.J., please revert the patch, I thought you have tested it alone
>> > without any further patches. For the -I patch, I really would prefer if
>> > libsanitizer just had a dependency on libstdc++ at toplevel
>> > (configure-target-sanitizer depending on all-target-libstdc++-v3),
>> > then you can (and similarly for host variants if we need host sanitizer at
>> > all). Then you should be able to use scripts/testsuite_flags
>> > --build-includes just fine.
>>
>> I opened:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55533
>>
>> to explain why scripts/testsuite_flags doesn't work when
>> bootstrapping libsanitizer.
>
> CCing Paolo and Alex as build maintainers on this, using the script
> is just my preference and not sure whether it is feasible or not, though
> IMHO if there is a dependency on libstdc++-v3 being built before
> libsanitizer is configured (or perhaps just configure when it has been
> configured and build when it has been built), I don't see why it couldn't
> be used in theory. I'll defer this to them.
>
Hi Alex, Paolo,
This is related to
http://gcc.gnu.org/ml/gcc-patches/2010-11/msg01430.html
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46026
The problem is CXX_FOR_TARGET used to configure libsanitizer
was expanded before libstdc++-v3 is configured when we are
bootstrapping libsanitizer. I opened:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55533
with a fix at
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02480.html
Can you take a look at it?
Thanks.
--
H.J.
prev parent reply other threads:[~2012-12-03 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 20:37 H.J. Lu
2012-11-29 16:12 ` Jakub Jelinek
2012-11-29 17:36 ` Tobias Burnus
2012-11-29 17:44 ` H.J. Lu
2012-11-29 18:03 ` Tobias Burnus
2012-11-29 18:24 ` Paolo Carlini
2012-11-29 18:33 ` H.J. Lu
2012-11-29 19:04 ` H.J. Lu
2012-11-29 19:26 ` Andrew Pinski
2012-11-29 19:06 ` Jakub Jelinek
2012-11-29 20:12 ` H.J. Lu
2012-12-06 12:06 ` Markus Trippelsdorf
2012-11-29 20:46 ` H.J. Lu
2012-12-03 11:52 ` Jakub Jelinek
2012-12-03 18:02 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpNFbrqPBokMfznSTmV1ZuvmAenAr3UJiMN2oddG3mc1A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=aoliva@redhat.com \
--cc=bonzini@gnu.org \
--cc=burnus@net-b.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).