From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: "Martin Liška" <mliska@suse.cz>,
"gcc-pat >> GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ICF: move readonly decision for variables to the right place
Date: Fri, 06 Mar 2015 14:38:00 -0000 [thread overview]
Message-ID: <CAMe9rOpOYpXoHiHZq1o1TvkZHwr1JjeJQvCCSSYkpLvyMyz49Q@mail.gmail.com> (raw)
In-Reply-To: <20150302075343.GA67273@kam.mff.cuni.cz>
On Sun, Mar 1, 2015 at 11:53 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> this is a variant of patch I commited.
> It takes care to load the constructor to memory in sem_variable::equals
> and donot touch it earlier. I also made sem_variable::parse to skip volatile
> and reigster variables.
>
> Bootstrapped/regtested x86_64-linux, lto-bootstrapped with -fmerge-all-constants
> comitted.
>
> Honza
>
> 2015-02-28 Martin Liska <mliska@suse.cz>
> Jan Hubicka <hubicka@ucw.cz>
>
> * ipa-icf.c (sem_variable::equals): Improve debug output;
> get variable constructor.
> (sem_variable::parse): Do not filter out too early; give up on
> volatile and register vars.
> (sem_item_optimizer::filter_removed_items): Filter out nonreadonly
> variables.
> * ipa-icf.h (sem_variable::init): Do not set ctor.
> (sem_variable::ctor): Remove.
>
This caused:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65334
--
H.J.
next prev parent reply other threads:[~2015-03-06 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 0:15 Martin Liška
2015-03-01 0:26 ` Jan Hubicka
2015-03-02 0:58 ` Jan Hubicka
2015-03-02 7:53 ` Jan Hubicka
2015-03-02 9:47 ` Martin Liška
2015-03-06 14:38 ` H.J. Lu [this message]
2015-03-06 19:08 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpOYpXoHiHZq1o1TvkZHwr1JjeJQvCCSSYkpLvyMyz49Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).