Re: [testsuite, i386] Fix for PR50185

Re: [testsuite, i386] Fix for PR50185

[Kirill Yukhin]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

According to Jakub's input, I've updated test to scan instruction, not
pattern name.

Is it ok?

Thanks, K

On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hi,
> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>
> testsuite/ChangeLog entry:
>
> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>
>        PR testsuite/50185
>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>
> Test passes.
> Ok for trunk?
>
> Thanks, K
>

[-- Attachment #2: pr50185-2.gcc.patch --]
[-- Type: application/octet-stream, Size: 1307 bytes --]

diff --git a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
index 6637d0c..e5a9c10 100644
--- a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
 /* { dg-options "-mavx2 -O2" } */
-/* { dg-final { scan-assembler "vmovmskb" } } */
+/* { dg-final { scan-assembler "vpmovmskb\[ \\t\]+\[^\n\]*%ymm\[0-9\]" } } */
 
 #include "avx2-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
new file mode 100644
index 0000000..838eadb
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "-mavx2 -O2 -dp" } */
+/* { dg-final { scan-assembler "avx2_pmovmskb" } } */
+
+#include "avx2-check.h"
+
+static void
+avx2_test (void)
+{
+  union256i_b s;
+  int res, res_ref;
+  int i, e = 0;
+
+  s.x = _mm256_set_epi8 (1, 2, 3, 4, 10, 20, 30, 90, -80, -40, -100,
+			 15, 98, 25, 98, 7, 1, 2, 3, 4, 10, 20, 30, 90,
+			 -80, -40, -100, -15, 98, 25, 98, 7);
+
+  res = _mm256_movemask_epi8 (s.x);
+
+  for (i = 0; i < 32; i++)
+    if (s.a[i] & (1 << 7))
+      res_ref = res_ref | (1 << i);
+
+  if (res != res_ref)
+    abort ();
+}

[testsuite, i386] Fix for PR50185

[Kirill Yukhin]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi,
Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182

testsuite/ChangeLog entry:

2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>

	PR testsuite/50185
	* gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
	* gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.

Test passes.
Ok for trunk?

Thanks, K

[-- Attachment #2: pr50185.gcc.patch --]
[-- Type: application/octet-stream, Size: 1640 bytes --]

diff --git a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
deleted file mode 100644
index 6637d0c..0000000
--- a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
+++ /dev/null
@@ -1,26 +0,0 @@
-/* { dg-do compile } */
-/* { dg-options "-mavx2 -O2" } */
-/* { dg-final { scan-assembler "vmovmskb" } } */
-
-#include "avx2-check.h"
-
-static void
-avx2_test (void)
-{
-  union256i_b s;
-  int res, res_ref;
-  int i, e = 0;
-
-  s.x = _mm256_set_epi8 (1, 2, 3, 4, 10, 20, 30, 90, -80, -40, -100,
-			 15, 98, 25, 98, 7, 1, 2, 3, 4, 10, 20, 30, 90,
-			 -80, -40, -100, -15, 98, 25, 98, 7);
-
-  res = _mm256_movemask_epi8 (s.x);
-
-  for (i = 0; i < 32; i++)
-    if (s.a[i] & (1 << 7))
-      res_ref = res_ref | (1 << i);
-
-  if (res != res_ref)
-    abort ();
-}
diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
new file mode 100644
index 0000000..838eadb
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "-mavx2 -O2 -dp" } */
+/* { dg-final { scan-assembler "avx2_pmovmskb" } } */
+
+#include "avx2-check.h"
+
+static void
+avx2_test (void)
+{
+  union256i_b s;
+  int res, res_ref;
+  int i, e = 0;
+
+  s.x = _mm256_set_epi8 (1, 2, 3, 4, 10, 20, 30, 90, -80, -40, -100,
+			 15, 98, 25, 98, 7, 1, 2, 3, 4, 10, 20, 30, 90,
+			 -80, -40, -100, -15, 98, 25, 98, 7);
+
+  res = _mm256_movemask_epi8 (s.x);
+
+  for (i = 0; i < 32; i++)
+    if (s.a[i] & (1 << 7))
+      res_ref = res_ref | (1 << i);
+
+  if (res != res_ref)
+    abort ();
+}

Re: [testsuite, i386] Fix for PR50185

[Uros Bizjak]

On Fri, Aug 26, 2011 at 2:04 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> According to Jakub's input, I've updated test to scan instruction, not
> pattern name.
>
> Is it ok?
>
> Thanks, K
>
> On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> Hi,
>> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>>
>> testsuite/ChangeLog entry:
>>
>> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>>
>>        PR testsuite/50185
>>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>>
>> Test passes.
>> Ok for trunk?

Is this correct ChangeLog? Looking into the patch, you are changing
one test to look for insn name, while adding avx2-vpmovmskb-2.c which
still looks for pattern name.

Please update ChangeLog and/or attached patch.

Uros.

Re: [testsuite, i386] Fix for PR50185

[H.J. Lu]

On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> According to Jakub's input, I've updated test to scan instruction, not
> pattern name.
>
> Is it ok?
>
> Thanks, K
>
> On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> Hi,
>> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>>
>> testsuite/ChangeLog entry:
>>
>> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>>
>>        PR testsuite/50185
>>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>>
>> Test passes.
>> Ok for trunk?
>>
>> Thanks, K
>>
>

Please check ALL AVX2 tests to see if they have similar problems.

-- 
H.J.

Re: [testsuite, i386] Fix for PR50185

[Kirill Yukhin]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Hi guys,
Thanks for your objections.

HJ, I scanned all AVX2 tests. So, every tests has at least <tab> which
distinguishes it from filename:
$ pwd
/export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386
$ grep "scan-assembler" avx2-* |grep -v "\t" |wc -l
0

Uros, you're right. Patch contains usless file. Updated one is attached.

Thanks, K


On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> According to Jakub's input, I've updated test to scan instruction, not
>> pattern name.
>>
>> Is it ok?
>>
>> Thanks, K
>>
>> On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>>> Hi,
>>> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>>>
>>> testsuite/ChangeLog entry:
>>>
>>> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>>>
>>>        PR testsuite/50185
>>>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>>>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>>>
>>> Test passes.
>>> Ok for trunk?
>>>
>>> Thanks, K
>>>
>>
>
> Please check ALL AVX2 tests to see if they have similar problems.
>
> --
> H.J.
>

[-- Attachment #2: pr50185-3.gcc.patch --]
[-- Type: application/octet-stream, Size: 1660 bytes --]

diff --git a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
deleted file mode 100644
index 6637d0c..0000000
--- a/gcc/testsuite/gcc.target/i386/avx2-vmovmskb-2.c
+++ /dev/null
@@ -1,26 +0,0 @@
-/* { dg-do compile } */
-/* { dg-options "-mavx2 -O2" } */
-/* { dg-final { scan-assembler "vmovmskb" } } */
-
-#include "avx2-check.h"
-
-static void
-avx2_test (void)
-{
-  union256i_b s;
-  int res, res_ref;
-  int i, e = 0;
-
-  s.x = _mm256_set_epi8 (1, 2, 3, 4, 10, 20, 30, 90, -80, -40, -100,
-			 15, 98, 25, 98, 7, 1, 2, 3, 4, 10, 20, 30, 90,
-			 -80, -40, -100, -15, 98, 25, 98, 7);
-
-  res = _mm256_movemask_epi8 (s.x);
-
-  for (i = 0; i < 32; i++)
-    if (s.a[i] & (1 << 7))
-      res_ref = res_ref | (1 << i);
-
-  if (res != res_ref)
-    abort ();
-}
diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
new file mode 100644
index 0000000..e5a9c10
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/avx2-vpmovmskb-2.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "-mavx2 -O2" } */
+/* { dg-final { scan-assembler "vpmovmskb\[ \\t\]+\[^\n\]*%ymm\[0-9\]" } } */
+
+#include "avx2-check.h"
+
+static void
+avx2_test (void)
+{
+  union256i_b s;
+  int res, res_ref;
+  int i, e = 0;
+
+  s.x = _mm256_set_epi8 (1, 2, 3, 4, 10, 20, 30, 90, -80, -40, -100,
+			 15, 98, 25, 98, 7, 1, 2, 3, 4, 10, 20, 30, 90,
+			 -80, -40, -100, -15, 98, 25, 98, 7);
+
+  res = _mm256_movemask_epi8 (s.x);
+
+  for (i = 0; i < 32; i++)
+    if (s.a[i] & (1 << 7))
+      res_ref = res_ref | (1 << i);
+
+  if (res != res_ref)
+    abort ();
+}

Re: [testsuite, i386] Fix for PR50185

[H.J. Lu]

On Fri, Aug 26, 2011 at 6:45 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hi guys,
> Thanks for your objections.
>
> HJ, I scanned all AVX2 tests. So, every tests has at least <tab> which
> distinguishes it from filename:
> $ pwd
> /export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386
> $ grep "scan-assembler" avx2-* |grep -v "\t" |wc -l
> 0
>
> Uros, you're right. Patch contains usless file. Updated one is attached.
>
> Thanks, K
>
>
> On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>>> According to Jakub's input, I've updated test to scan instruction, not
>>> pattern name.
>>>
>>> Is it ok?
>>>
>>> Thanks, K
>>>
>>> On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>>>> Hi,
>>>> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>>>>
>>>> testsuite/ChangeLog entry:
>>>>
>>>> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>>>>
>>>>        PR testsuite/50185
>>>>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>>>>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>>>>
>>>> Test passes.
>>>> Ok for trunk?
>>>>
>>>> Thanks, K
>>>>
>>>
>>
>> Please check ALL AVX2 tests to see if they have similar problems.

Thanks.



-- 
H.J.

Re: [testsuite, i386] Fix for PR50185

[Jakub Jelinek]

Hi!

On Fri, Aug 26, 2011 at 06:04:20AM -0700, H.J. Lu wrote:
> Please check ALL AVX2 tests to see if they have similar problems.

Checking all current i386 tests revealed another problematic testcase:
grep scan-assembler' "[a-z0-9]*"' testsuite/gcc.target/i386/*.c | grep '\(.*\).*"\1"'

(minmax-*.c only match the path, which will show up only with -g and
I bet many other scan-assembler tests would fail with
RUNTESTFLAGS=--target_board=unix/-g
(matching various stuff in the debug info)).

2011-08-26  Jakub Jelinek  <jakub@redhat.com>

	* gcc.target/i386/cmpxchg16b-1.c: Match also space after the
	instruction.

--- gcc/testsuite/gcc.target/i386/cmpxchg16b-1.c.jj	2011-07-11 10:39:29.000000000 +0200
+++ gcc/testsuite/gcc.target/i386/cmpxchg16b-1.c	2011-08-26 16:20:46.000000000 +0200
@@ -10,4 +10,4 @@ void test(TItype x_128)
   m_128 = __sync_val_compare_and_swap (&m_128, x_128, m_128);
 }
 
-/* { dg-final { scan-assembler "cmpxchg16b" } } */
+/* { dg-final { scan-assembler "cmpxchg16b\[ \\t]" } } */


	Jakub

Re: [testsuite, i386] Fix for PR50185

[Kirill Yukhin]

Hi,
This is a ping.

Is the patch ok for trunk?

Thanks, K

On Fri, Aug 26, 2011 at 5:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Aug 26, 2011 at 6:45 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> Hi guys,
>> Thanks for your objections.
>>
>> HJ, I scanned all AVX2 tests. So, every tests has at least <tab> which
>> distinguishes it from filename:
>> $ pwd
>> /export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386
>> $ grep "scan-assembler" avx2-* |grep -v "\t" |wc -l
>> 0
>>
>> Uros, you're right. Patch contains usless file. Updated one is attached.
>>
>> Thanks, K
>>
>>
>> On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>>>> According to Jakub's input, I've updated test to scan instruction, not
>>>> pattern name.
>>>>
>>>> Is it ok?
>>>>
>>>> Thanks, K
>>>>
>>>> On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>>>>> Hi,
>>>>> Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182
>>>>>
>>>>> testsuite/ChangeLog entry:
>>>>>
>>>>> 2011-08-26  Kirill Yukhin  <kirill.yukhin@intel.com>
>>>>>
>>>>>        PR testsuite/50185
>>>>>        * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ...
>>>>>        * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update.
>>>>>
>>>>> Test passes.
>>>>> Ok for trunk?
>>>>>
>>>>> Thanks, K
>>>>>
>>>>
>>>
>>> Please check ALL AVX2 tests to see if they have similar problems.
>
> Thanks.
>
>
>
> --
> H.J.
>

Re: [testsuite, i386] Fix for PR50185

[Uros Bizjak]

On Tue, Aug 30, 2011 at 8:39 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hi,
> This is a ping.
>
> Is the patch ok for trunk?

OK.

Thanks,
Uros.

Re: [testsuite, i386] Fix for PR50185

[Kirill Yukhin]

Thank you!

Guys who is able to write, could you please check-in my changes?

K

On Tue, Aug 30, 2011 at 12:12 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Tue, Aug 30, 2011 at 8:39 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> Hi,
>> This is a ping.
>>
>> Is the patch ok for trunk?
>
> OK.
>
> Thanks,
> Uros.
>