From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46637 invoked by alias); 11 Feb 2016 20:54:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46616 invoked by uid 89); 11 Feb 2016 20:54:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=segher@kernel.crashing.org, U*segher, 69567, D*crashing.org X-HELO: mail-qk0-f170.google.com Received: from mail-qk0-f170.google.com (HELO mail-qk0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 20:54:54 +0000 Received: by mail-qk0-f170.google.com with SMTP id x1so23884910qkc.1 for ; Thu, 11 Feb 2016 12:54:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=XohMazoOVRIrUi/NviHKAkjJFllSuO3K/RSZj36GMKs=; b=IOajf9D4e0gUiZjSb9WNNLPGicEE62buoAUCYxixj0fR2k+ExiRfA3Hu3ffPdDmmcA 0hXee3UFep2XDNfrZULSf8CIiyRQ5+eB9IAKDzDC2HqYIvlIe7B3Mp5KK5R58xlVL2Gk RT4n8oQCfQjmJaz/b9Kkj4oFzVwOaD5rJnPhTczcqagur97Mz7V/zji9qtWTdTBSrynH aUHiS38JDTQ0krh3R8wQDcxcUu1gc35ft+JRl65PtHSzhB7XmwSmHPEZEJx5AxUsDQgs GTVN9ZA3W6mV/2macfBDYjcVilUDZ4z5CHMSECYz6iifUeAxvFSiilqs5ctecqvXdQGi 8Eug== X-Gm-Message-State: AG10YORxDe6JcFvh/flmb4a80EGiaUIgKTgMP+ZtnbDVNpJpxYwGY304DW3QlrGmDQJTMW3O6pg1qJSCtiwTpg== MIME-Version: 1.0 X-Received: by 10.55.76.15 with SMTP id z15mr58080926qka.32.1455224092664; Thu, 11 Feb 2016 12:54:52 -0800 (PST) Received: by 10.55.20.129 with HTTP; Thu, 11 Feb 2016 12:54:52 -0800 (PST) In-Reply-To: <7c9ac3d29a29c4b1bc78294afb955f30fd36ad77.1455137361.git.segher@kernel.crashing.org> References: <7c9ac3d29a29c4b1bc78294afb955f30fd36ad77.1455137361.git.segher@kernel.crashing.org> Date: Thu, 11 Feb 2016 20:54:00 -0000 Message-ID: Subject: Re: [PATCH] combine: More distribute_notes trouble (PR69737) From: "H.J. Lu" To: Segher Boessenkool Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00804.txt.bz2 On Thu, Feb 11, 2016 at 9:04 AM, Segher Boessenkool wrote: > PR64682 is a problem in distribute_notes, where it has trouble putting > a REG_DEAD note for a reg that is set twice in the right spot. My fix > for that did the wrong thing for PR69567. And then my attempted fix > for that one made PR64682 fail again. > > Instead, let's just lose the note in such complicated cases, like we > already do in certain similar cases. > > Tested on powerpc64-linux and x86_64-linux. Also built Linux kernels > for some 30 supported targets; no difference in generated code was > observed. > > Committing to trunk. > > HJ, I tested this on GCC 5 for x86_64-linux, the failure is gone; > could you test it on your setup before I apply it there though? > > > Segher > > > 2016-02-11 Segher Boessenkool > > PR rtl-optimization/64682 > PR rtl-optimization/69567 > PR rtl-optimization/69737 > * combine.c (distribute_notes) : If the register is set > in I2 as well, just lose it. > > Yes, it fixed the regressions on ia32 and x96-64: New passes: FAIL: gcc.c-torture/execute/pr64682.c -O2 execution test FAIL: gcc.c-torture/execute/pr64682.c -O2 execution test FAIL: gcc.c-torture/execute/pr64682.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test FAIL: gcc.c-torture/execute/pr64682.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test FAIL: gcc.c-torture/execute/pr64682.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test FAIL: gcc.c-torture/execute/pr64682.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer -funroll-loops execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -fomit-frame-pointer -funroll-loops execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -g execution test FAIL: gcc.c-torture/execute/pr64682.c -O3 -g execution test Thanks. -- H.J.