From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 9BBDE3858D1E for ; Wed, 21 Dec 2022 22:44:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BBDE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32c.google.com with SMTP id p17-20020a9d6951000000b00678306ceb94so102578oto.5 for ; Wed, 21 Dec 2022 14:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2RacSFqYLjuGdVKu0upwQjN8NPhEcNNVGjuQJRKetLA=; b=gdY4ViDDZ/+JG8x9UuRfLLzVqEaHV4YCgJhji8CCsGhQ7r/HqGCLXRcBBDdVZTAfvj 1vbesr/H6YF6K/XXETioepl3ijEwqjx86ywtVeBTdtZgDF3QweJeTTyL7qzIAO1Dreuv OWwbj+GncKXxsoc5eeDZxujS55I7VFmcVeJZeVoj1A7JEAXKF6G9lAh6muOWR/QflImc yufuV4v1w1MxLNo6Y48UcUBUS4CzA02t/LjYzfQRQHPrDi2GCZlIcBQ3Ws1ayzftuhFh FkyKgeSKYLYiICB11YUAbi53TUpZlM089JTpfWdJNPmqRtTG6T7sm/JYAz4jNlWiCM/9 5BDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2RacSFqYLjuGdVKu0upwQjN8NPhEcNNVGjuQJRKetLA=; b=6TFfUriWVwTrfuJPilvmJA9T0dIOG/x217ZNIeZNIG7p7jrBkl5cuGc3+Wb2Ino9cQ TbmWzulQnSFTLB0xpSzqI4AsmEZiFjLjzbSbG3W4mXqqJ0qQ3jE5P1fIZEsqeOQbuYWz 5H3qTXbtbZHYpyiZ+sHJFGb/uYPY7H4W1w0sSIL6lSWgVAEgN18XKxIaa/tASgT1VFUS phypE0FG5rBdUq+4GCa+6+Hq1uMyAP2lDuQSLNj0ECyTQN5y8hWlMZVYr0WqTKOaC+Z1 Qk4m+C3c0byAhdYxqP2sNncM9qZ0FlKLIKOb33E5qO3eJL/HdJzOEAPA1yj5WBHDw6cD ACfw== X-Gm-Message-State: AFqh2krhF7CDv/LTfs8y92/dC5pqnL2pctVhLCKyhF2nn2PkkimrvF8M ZeMLyTm5Pd3jFlTrL2Zq1LctIE9ICocQ8/rf0Us= X-Google-Smtp-Source: AMrXdXtdd9iyiIDk3DWlmacOhQXgbvRl2J7hGN7z9lAMNJbrIKrFqRN3pbmAC1r72+eOOIkq29DAfHNaj2mjfpHrxC8= X-Received: by 2002:a9d:6182:0:b0:678:266b:9e55 with SMTP id g2-20020a9d6182000000b00678266b9e55mr195828otk.371.1671662659276; Wed, 21 Dec 2022 14:44:19 -0800 (PST) MIME-Version: 1.0 References: <20221215062137.3128845-1-hongtao.liu@intel.com> <20221215062137.3128845-2-hongtao.liu@intel.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 21 Dec 2022 14:43:43 -0800 Message-ID: Subject: Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR. To: Jakub Jelinek Cc: Hongtao Liu , liuhongt , gcc-patches@gcc.gnu.org, ubizjak@gmail.com Content-Type: multipart/mixed; boundary="000000000000fe6b9105f05e4a02" X-Spam-Status: No, score=-3023.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000fe6b9105f05e4a02 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2022 at 2:35 PM Jakub Jelinek wrote: > > On Wed, Dec 21, 2022 at 12:20:23PM -0800, H.J. Lu wrote: > > On Mon, Dec 19, 2022 at 8:52 PM Hongtao Liu wrote: > > > > > > On Thu, Dec 15, 2022 at 3:45 PM Hongtao Liu wrot= e: > > > > > > > > On Thu, Dec 15, 2022 at 3:39 PM Jakub Jelinek wr= ote: > > > > > > > > > > On Thu, Dec 15, 2022 at 02:21:37PM +0800, liuhongt via Gcc-patche= s wrote: > > > > > > --- a/gcc/config/i386/i386.opt > > > > > > +++ b/gcc/config/i386/i386.opt > > > > > > @@ -420,6 +420,10 @@ mpc80 > > > > > > Target RejectNegative > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > +mdaz-ftz > > > > > > +Target > > > > > > > > > > s/Target/Driver/ > > > > Change to Driver and Got error like:cc1: error: command-line option > > > > =E2=80=98-mdaz-ftz=E2=80=99 is valid for the driver but not for C. > > > Hi Jakub: > > > I didn't find a good solution to handle this error after changing > > > *Target* to *Driver*, Could you give some hints how to solve this > > > problem? > > > Or is it ok for you to mark this as *Target*(there won't be any save > > > and restore in cfun since there's no variable defined here.) > > > > Since all -m* options are passed to cc1, -mdaz-ftz can't be marked > > as Driver. We need to give it a different name to mark it as Driver. > > It is ok like that. > > Jakub > The GCC driver handles -mno-XXX automatically for -mXXX. Use a different name needs to handle the negation. Or we can do something like this to check for CL_DRIVER before passing it to cc1. --=20 H.J. --000000000000fe6b9105f05e4a02 Content-Type: text/x-patch; charset="US-ASCII"; name="p.diff" Content-Disposition: attachment; filename="p.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lby8p8dj0 ZGlmZiAtLWdpdCBhL2djYy9nY2MuY2MgYi9nY2MvZ2NjLmNjCmluZGV4IDI1NjhkNTQxMTk2Li44 N2NiZWExMWFlMSAxMDA2NDQKLS0tIGEvZ2NjL2djYy5jYworKysgYi9nY2MvZ2NjLmNjCkBAIC0z ODUxLDcgKzM4NTEsNyBAQCBhbGxvY19zd2l0Y2ggKHZvaWQpCiAKIHN0YXRpYyB2b2lkCiBzYXZl X3N3aXRjaCAoY29uc3QgY2hhciAqb3B0LCBzaXplX3Qgbl9hcmdzLCBjb25zdCBjaGFyICpjb25z dCAqYXJncywKLQkgICAgIGJvb2wgdmFsaWRhdGVkLCBib29sIGtub3duKQorCSAgICAgYm9vbCB2 YWxpZGF0ZWQsIGJvb2wga25vd24sIGJvb2wgZHJpdmVyID0gZmFsc2UpCiB7CiAgIGFsbG9jX3N3 aXRjaCAoKTsKICAgc3dpdGNoZXNbbl9zd2l0Y2hlc10ucGFydDEgPSBvcHQgKyAxOwpAQCAtMzg2 OCw2ICszODY4LDcgQEAgc2F2ZV9zd2l0Y2ggKGNvbnN0IGNoYXIgKm9wdCwgc2l6ZV90IG5fYXJn cywgY29uc3QgY2hhciAqY29uc3QgKmFyZ3MsCiAgIHN3aXRjaGVzW25fc3dpdGNoZXNdLnZhbGlk YXRlZCA9IHZhbGlkYXRlZDsKICAgc3dpdGNoZXNbbl9zd2l0Y2hlc10ua25vd24gPSBrbm93bjsK ICAgc3dpdGNoZXNbbl9zd2l0Y2hlc10ub3JkZXJpbmcgPSAwOworICBzd2l0Y2hlc1tuX3N3aXRj aGVzXS5kcml2ZXIgPSBkcml2ZXI7CiAgIG5fc3dpdGNoZXMrKzsKIH0KIApAQCAtNDU3NSw3ICs0 NTc2LDggQEAgZHJpdmVyX2hhbmRsZV9vcHRpb24gKHN0cnVjdCBnY2Nfb3B0aW9ucyAqb3B0cywK ICAgaWYgKGRvX3NhdmUpCiAgICAgc2F2ZV9zd2l0Y2ggKGRlY29kZWQtPmNhbm9uaWNhbF9vcHRp b25bMF0sCiAJCSBkZWNvZGVkLT5jYW5vbmljYWxfb3B0aW9uX251bV9lbGVtZW50cyAtIDEsCi0J CSAmZGVjb2RlZC0+Y2Fub25pY2FsX29wdGlvblsxXSwgdmFsaWRhdGVkLCB0cnVlKTsKKwkJICZk ZWNvZGVkLT5jYW5vbmljYWxfb3B0aW9uWzFdLCB2YWxpZGF0ZWQsIHRydWUsCisJCSBjbF9vcHRp b25zW29wdF9pbmRleF0uZmxhZ3MgPT0gQ0xfRFJJVkVSKTsKICAgcmV0dXJuIHRydWU7CiB9CiAK QEAgLTc0NjUsNyArNzQ2Nyw4IEBAIGNoZWNrX2xpdmVfc3dpdGNoIChpbnQgc3dpdGNobnVtLCBp bnQgcHJlZml4X2xlbmd0aCkKIHN0YXRpYyB2b2lkCiBnaXZlX3N3aXRjaCAoaW50IHN3aXRjaG51 bSwgaW50IG9taXRfZmlyc3Rfd29yZCkKIHsKLSAgaWYgKChzd2l0Y2hlc1tzd2l0Y2hudW1dLmxp dmVfY29uZCAmIFNXSVRDSF9JR05PUkUpICE9IDApCisgIGlmICgoc3dpdGNoZXNbc3dpdGNobnVt XS5saXZlX2NvbmQgJiBTV0lUQ0hfSUdOT1JFKSAhPSAwCisgICAgICB8fCBzd2l0Y2hlc1tzd2l0 Y2hudW1dLmRyaXZlcikKICAgICByZXR1cm47CiAKICAgaWYgKCFvbWl0X2ZpcnN0X3dvcmQpCmRp ZmYgLS1naXQgYS9nY2Mvb3B0cy5oIGIvZ2NjL29wdHMuaAppbmRleCBjZTRmZDVjMzliOS4uMjkw MGYwZDkxNjggMTAwNjQ0Ci0tLSBhL2djYy9vcHRzLmgKKysrIGIvZ2NjL29wdHMuaApAQCAtNTYx LDYgKzU2MSw3IEBAIHN0cnVjdCBzd2l0Y2hzdHIKICAgYm9vbCBrbm93bjsKICAgYm9vbCB2YWxp ZGF0ZWQ7CiAgIGJvb2wgb3JkZXJpbmc7CisgIGJvb2wgZHJpdmVyOwogfTsKIAogI2VuZGlmCg== --000000000000fe6b9105f05e4a02--