From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, i386, testsuite] FMA intrinsics
Date: Tue, 30 Aug 2011 14:02:00 -0000 [thread overview]
Message-ID: <CAMe9rOpW1+-V9WmU+VzyazhUj3VPAfBaGaND4gRStwKxe5T+FQ@mail.gmail.com> (raw)
In-Reply-To: <CAFFGCRAsu46Gpe-5jMDZ_pSd_XUTn3qyA=BvcqBpqR+ORigiag@mail.gmail.com>
On Tue, Aug 30, 2011 at 2:42 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> Fixed.
>
> 2011/8/26 H.J. Lu <hjl.tools@gmail.com>:
>> On Fri, Aug 26, 2011 at 8:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Aug 26, 2011 at 8:06 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>>>> Done.
>>>>
>>>>
>>>>
>>>> Also fixed changelog:
>>>>
>>>> 2011-08-26 Ilya Tocar <ilya.tocar@intel.com>
>>>>
>>>> * config/i386/fmaintrin.h: New.
>>>> * config.gcc: Add fmaintrin.h.
>>>> * config/i386/i386.c
>>>> (enum ix86_builtins) <IX86_BUILTIN_VFMADDSS3>: New.
>>>> <IX86_BUILTIN_VFMADDSD3>: Likewise.
>>>> * config/i386/sse.md (fmai_vmfmadd_<mode>): New.
>>>> (*fmai_fmadd_<mode>): Likewise.
>>>> (*fmai_fmsub_<mode>): Likewise.
>>>> (*fmai_fnmadd_<mode>): Likewise.
>>>> (*fmai_fnmsub_<mode>): Likewise.
>>>> * config/i386/immintrin.h: Add fmaintrin.h.
>>>>
>>>
>>>
>>> -- +++ b/gcc/config/i386/fmaintrin.h
>>> @@ -0,0 +1,229 @@
>>> +/* Copyright (C) 2007, 2008, 2009, 2010, 2011 Free Software Foundation, Inc.
>>> +
>>>
>>> It should be just 2011.
>>>
>>
>> Also lines in fmaintrin.h are too long. I prefer 72 columns.
>>
Your patch won't apply. Please merge with master first and regenerate it.
--
H.J.
next prev parent reply other threads:[~2011-08-30 13:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 11:23 Uros Bizjak
2011-08-22 17:32 ` Ilya Tocar
2011-08-22 20:41 ` Uros Bizjak
2011-08-23 14:55 ` Ilya Tocar
2011-08-23 15:33 ` Uros Bizjak
2011-08-24 10:06 ` Ilya Tocar
2011-08-24 10:12 ` Jakub Jelinek
2011-08-24 11:12 ` Ilya Tocar
2011-08-24 13:31 ` Uros Bizjak
2011-08-24 13:52 ` Ilya Tocar
2011-08-24 22:00 ` Uros Bizjak
2011-08-25 10:15 ` Ilya Tocar
2011-08-25 10:46 ` Uros Bizjak
2011-08-25 11:46 ` Ilya Tocar
2011-08-25 11:46 ` Jakub Jelinek
2011-08-25 11:49 ` Ilya Tocar
2011-08-26 11:03 ` Ilya Tocar
2011-08-26 14:07 ` H.J. Lu
2011-08-26 15:47 ` Ilya Tocar
2011-08-26 17:02 ` H.J. Lu
2011-08-26 17:06 ` H.J. Lu
2011-08-30 12:05 ` Ilya Tocar
2011-08-30 14:02 ` H.J. Lu [this message]
2011-08-30 14:10 ` Ilya Tocar
2011-08-30 14:32 ` Ilya Tocar
2011-08-30 15:25 ` H.J. Lu
-- strict thread matches above, loose matches on Subject: below --
2011-08-17 14:08 [PATCH, i386, testsuite]FMA intrinsics Ilya Tocar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpW1+-V9WmU+VzyazhUj3VPAfBaGaND4gRStwKxe5T+FQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tocarip.intel@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).