[PATCH] [graphite] make debug comment more explicit

[PATCH] [graphite] make debug comment more explicit

[Sebastian Pop]

2016-01-28  Abderrazek Zaafrani  <a.zaafrani@samsung.com>

	* graphite-optimize-isl.c (optimize_isl): Print a different debug
	message when isl does not return a valid schedule.
---
 gcc/graphite-optimize-isl.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gcc/graphite-optimize-isl.c b/gcc/graphite-optimize-isl.c
index d1620d5..6b3108d 100644
--- a/gcc/graphite-optimize-isl.c
+++ b/gcc/graphite-optimize-isl.c
@@ -477,8 +477,15 @@ optimize_isl (scop_p scop)
   if (!schedule || isl_ctx_last_error (scop->isl_context) == isl_error_quota)
     {
       if (dump_file && dump_flags)
-	fprintf (dump_file, "isl timed out --param max-isl-operations=%d\n",
-		 max_operations);
+	{
+	  if (!schedule)
+	    fprintf (dump_file, "isl did not return any schedule.\n",
+		     max_operations);
+	  else
+	    fprintf (dump_file, "isl timed out --param max-isl-operations=%d\n",
+		     max_operations);
+	}
+
       if (schedule)
 	isl_schedule_free (schedule);
       return false;
-- 
2.5.0

Re: [PATCH] [graphite] make debug comment more explicit

[H.J. Lu]

On Thu, Jan 28, 2016 at 8:32 AM, Sebastian Pop <s.pop@samsung.com> wrote:
> 2016-01-28  Abderrazek Zaafrani  <a.zaafrani@samsung.com>
>
>         * graphite-optimize-isl.c (optimize_isl): Print a different debug
>         message when isl does not return a valid schedule.
> ---
>  gcc/graphite-optimize-isl.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/graphite-optimize-isl.c b/gcc/graphite-optimize-isl.c
> index d1620d5..6b3108d 100644
> --- a/gcc/graphite-optimize-isl.c
> +++ b/gcc/graphite-optimize-isl.c
> @@ -477,8 +477,15 @@ optimize_isl (scop_p scop)
>    if (!schedule || isl_ctx_last_error (scop->isl_context) == isl_error_quota)
>      {
>        if (dump_file && dump_flags)
> -       fprintf (dump_file, "isl timed out --param max-isl-operations=%d\n",
> -                max_operations);
> +       {
> +         if (!schedule)
> +           fprintf (dump_file, "isl did not return any schedule.\n",
> +                    max_operations);
> +         else
> +           fprintf (dump_file, "isl timed out --param max-isl-operations=%d\n",
> +                    max_operations);
> +       }
> +
>        if (schedule)
>         isl_schedule_free (schedule);
>        return false;
> --
> 2.5.0
>

I checked in this to fix

/export/gnu/import/git/sources/gcc/gcc/graphite-optimize-isl.c:483:22:
error: too many arguments for format [-Werror=format-extra-args]
        max_operations);
                      ^
cc1plus: all warnings being treated as errors
Makefile:1085: recipe for target 'graphite-optimize-isl.o' failed
make[5]: *** [graphite-optimize-isl.o] Error 1
make[5]: *** Waiting for unfinished jobs....


-- 
H.J.
--
Index: ChangeLog
===================================================================
--- ChangeLog (revision 232938)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2016-01-28  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * graphite-optimize-isl.c (optimize_isl): Fix dump.
+
 2016-01-28  Richard Henderson  <rth@redhat.com>

  PR target/69305
Index: graphite-optimize-isl.c
===================================================================
--- graphite-optimize-isl.c (revision 232938)
+++ graphite-optimize-isl.c (working copy)
@@ -479,8 +479,7 @@ optimize_isl (scop_p scop)
       if (dump_file && dump_flags)
  {
   if (!schedule)
-    fprintf (dump_file, "isl did not return any schedule.\n",
-     max_operations);
+    fprintf (dump_file, "isl did not return any schedule.\n");
   else
     fprintf (dump_file, "isl timed out --param max-isl-operations=%d\n",
      max_operations);